* [igt-dev] [PATCH i-g-t] lib/igt_pm: make igt_pm_dmc_loaded() more robust
@ 2023-02-28 14:29 Jani Nikula
2023-02-28 14:33 ` Imre Deak
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Jani Nikula @ 2023-02-28 14:29 UTC (permalink / raw)
To: igt-dev; +Cc: Jani Nikula
Make igt_pm_dmc_loaded() more robust against changes in the debugfs
file. Read the entire contents of the file, at least with the current
output. Preserve logged output even if something gets added in front of
the file, and don't depend on exact length of the first line.
Cc: Imre Deak <imre.deak@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
lib/igt_pm.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 26e8c9f05fdf..6c84e94f6307 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -785,6 +785,11 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
return ret;
}
+static const char *yesno(bool x)
+{
+ return x ? "yes" : "no";
+}
+
/**
* dmc_loaded:
* @debugfs: fd to the debugfs dir.
@@ -798,7 +803,8 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
*/
bool igt_pm_dmc_loaded(int debugfs)
{
- char buf[15];
+ char buf[512];
+ bool loaded;
int len;
len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf) - 1);
@@ -807,8 +813,10 @@ bool igt_pm_dmc_loaded(int debugfs)
buf[len] = '\0';
- igt_info("DMC: %s\n", buf);
- return strstr(buf, "fw loaded: yes");
+ loaded = strstr(buf, "fw loaded: yes");
+ igt_info("DMC: fw loaded: %s\n", yesno(loaded));
+
+ return loaded;
}
/**
--
2.39.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_pm: make igt_pm_dmc_loaded() more robust
2023-02-28 14:29 [igt-dev] [PATCH i-g-t] lib/igt_pm: make igt_pm_dmc_loaded() more robust Jani Nikula
@ 2023-02-28 14:33 ` Imre Deak
2023-02-28 17:30 ` Jani Nikula
2023-02-28 14:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-02-28 15:53 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 1 reply; 5+ messages in thread
From: Imre Deak @ 2023-02-28 14:33 UTC (permalink / raw)
To: Jani Nikula; +Cc: igt-dev
On Tue, Feb 28, 2023 at 04:29:51PM +0200, Jani Nikula wrote:
> Make igt_pm_dmc_loaded() more robust against changes in the debugfs
> file. Read the entire contents of the file, at least with the current
> output. Preserve logged output even if something gets added in front of
> the file, and don't depend on exact length of the first line.
>
> Cc: Imre Deak <imre.deak@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> lib/igt_pm.c | 14 +++++++++++---
> 1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 26e8c9f05fdf..6c84e94f6307 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -785,6 +785,11 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
> return ret;
> }
>
> +static const char *yesno(bool x)
> +{
> + return x ? "yes" : "no";
> +}
> +
> /**
> * dmc_loaded:
> * @debugfs: fd to the debugfs dir.
> @@ -798,7 +803,8 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
> */
> bool igt_pm_dmc_loaded(int debugfs)
> {
> - char buf[15];
> + char buf[512];
> + bool loaded;
> int len;
>
> len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf) - 1);
> @@ -807,8 +813,10 @@ bool igt_pm_dmc_loaded(int debugfs)
>
> buf[len] = '\0';
>
> - igt_info("DMC: %s\n", buf);
> - return strstr(buf, "fw loaded: yes");
> + loaded = strstr(buf, "fw loaded: yes");
> + igt_info("DMC: fw loaded: %s\n", yesno(loaded));
> +
> + return loaded;
> }
>
> /**
> --
> 2.39.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for lib/igt_pm: make igt_pm_dmc_loaded() more robust
2023-02-28 14:29 [igt-dev] [PATCH i-g-t] lib/igt_pm: make igt_pm_dmc_loaded() more robust Jani Nikula
2023-02-28 14:33 ` Imre Deak
@ 2023-02-28 14:48 ` Patchwork
2023-02-28 15:53 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-02-28 14:48 UTC (permalink / raw)
To: Jani Nikula; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 14343 bytes --]
== Series Details ==
Series: lib/igt_pm: make igt_pm_dmc_loaded() more robust
URL : https://patchwork.freedesktop.org/series/114477/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12790 -> IGTPW_8540
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/index.html
Participating hosts (2 -> 37)
------------------------------
Additional (36): fi-kbl-soraka fi-rkl-11600 bat-dg1-6 bat-dg1-5 fi-apl-guc bat-adlp-6 fi-pnv-d510 bat-rpls-1 fi-blb-e6850 bat-rpls-2 fi-skl-6600u fi-bsw-n3050 bat-dg2-8 bat-adlm-1 bat-dg2-9 fi-ilk-650 fi-hsw-4770 bat-adln-1 fi-ivb-3770 fi-elk-e7500 bat-jsl-3 bat-rplp-1 bat-dg2-11 fi-bsw-nick fi-kbl-7567u bat-dg1-7 bat-adlp-9 fi-skl-guc fi-cfl-8700k fi-glk-j4005 bat-jsl-1 fi-tgl-1115g4 fi-cfl-guc fi-kbl-guc fi-kbl-x1275 fi-cfl-8109u
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in IGTPW_8540 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@basic-hwmon:
- fi-skl-guc: NOTRUN -> [SKIP][1] ([fdo#109271])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-skl-guc/igt@debugfs_test@basic-hwmon.html
- bat-rpls-2: NOTRUN -> [SKIP][2] ([i915#7456])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-rpls-2/igt@debugfs_test@basic-hwmon.html
- fi-kbl-soraka: NOTRUN -> [SKIP][3] ([fdo#109271])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-kbl-soraka/igt@debugfs_test@basic-hwmon.html
- fi-glk-j4005: NOTRUN -> [SKIP][4] ([fdo#109271])
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-glk-j4005/igt@debugfs_test@basic-hwmon.html
- fi-hsw-4770: NOTRUN -> [SKIP][5] ([fdo#109271])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-hsw-4770/igt@debugfs_test@basic-hwmon.html
- fi-cfl-8109u: NOTRUN -> [SKIP][6] ([fdo#109271])
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-cfl-8109u/igt@debugfs_test@basic-hwmon.html
- bat-adlp-9: NOTRUN -> [SKIP][7] ([i915#7456])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-adlp-9/igt@debugfs_test@basic-hwmon.html
- fi-kbl-7567u: NOTRUN -> [SKIP][8] ([fdo#109271])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-kbl-7567u/igt@debugfs_test@basic-hwmon.html
- bat-adln-1: NOTRUN -> [SKIP][9] ([i915#7456])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-adln-1/igt@debugfs_test@basic-hwmon.html
- fi-ivb-3770: NOTRUN -> [SKIP][10] ([fdo#109271])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-ivb-3770/igt@debugfs_test@basic-hwmon.html
- fi-elk-e7500: NOTRUN -> [SKIP][11] ([fdo#109271])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-elk-e7500/igt@debugfs_test@basic-hwmon.html
- fi-cfl-8700k: NOTRUN -> [SKIP][12] ([fdo#109271])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-cfl-8700k/igt@debugfs_test@basic-hwmon.html
- bat-adlm-1: NOTRUN -> [SKIP][13] ([i915#7456])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-adlm-1/igt@debugfs_test@basic-hwmon.html
- fi-ilk-650: NOTRUN -> [SKIP][14] ([fdo#109271])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-ilk-650/igt@debugfs_test@basic-hwmon.html
- bat-jsl-1: NOTRUN -> [SKIP][15] ([i915#7456])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-jsl-1/igt@debugfs_test@basic-hwmon.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][16] ([i915#7456])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-tgl-1115g4/igt@debugfs_test@basic-hwmon.html
- bat-adlp-6: NOTRUN -> [SKIP][17] ([i915#7456])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-adlp-6/igt@debugfs_test@basic-hwmon.html
- bat-rplp-1: NOTRUN -> [SKIP][18] ([i915#7456])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-rplp-1/igt@debugfs_test@basic-hwmon.html
- fi-rkl-11600: NOTRUN -> [SKIP][19] ([i915#7456])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-rkl-11600/igt@debugfs_test@basic-hwmon.html
- fi-bsw-n3050: NOTRUN -> [SKIP][20] ([fdo#109271])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-bsw-n3050/igt@debugfs_test@basic-hwmon.html
- bat-rpls-1: NOTRUN -> [SKIP][21] ([i915#7456])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-rpls-1/igt@debugfs_test@basic-hwmon.html
- fi-apl-guc: NOTRUN -> [SKIP][22] ([fdo#109271])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-apl-guc/igt@debugfs_test@basic-hwmon.html
- fi-cfl-guc: NOTRUN -> [SKIP][23] ([fdo#109271])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-cfl-guc/igt@debugfs_test@basic-hwmon.html
- fi-skl-6600u: NOTRUN -> [SKIP][24] ([fdo#109271])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-skl-6600u/igt@debugfs_test@basic-hwmon.html
- bat-jsl-3: NOTRUN -> [SKIP][25] ([i915#7456])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-jsl-3/igt@debugfs_test@basic-hwmon.html
* igt@fbdev@eof:
- fi-kbl-guc: NOTRUN -> [SKIP][26] ([fdo#109271]) +5 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-kbl-guc/igt@fbdev@eof.html
- bat-adlm-1: NOTRUN -> [SKIP][27] ([i915#2582]) +4 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-adlm-1/igt@fbdev@eof.html
- fi-bsw-nick: NOTRUN -> [SKIP][28] ([fdo#109271]) +5 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-bsw-nick/igt@fbdev@eof.html
* igt@fbdev@info:
- bat-dg1-7: NOTRUN -> [SKIP][29] ([i915#2582]) +4 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-dg1-7/igt@fbdev@info.html
* igt@fbdev@nullptr:
- bat-rpls-1: NOTRUN -> [SKIP][30] ([i915#2582]) +4 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-rpls-1/igt@fbdev@nullptr.html
* igt@fbdev@read:
- bat-rpls-2: NOTRUN -> [SKIP][31] ([i915#2582]) +4 similar issues
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-rpls-2/igt@fbdev@read.html
- fi-kbl-x1275: NOTRUN -> [SKIP][32] ([fdo#109271]) +5 similar issues
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-kbl-x1275/igt@fbdev@read.html
* igt@gem_ctx_create@basic:
- fi-blb-e6850: NOTRUN -> [SKIP][33] ([fdo#109271]) +3 similar issues
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-blb-e6850/igt@gem_ctx_create@basic.html
* igt@gem_ctx_create@basic-files:
- fi-pnv-d510: NOTRUN -> [SKIP][34] ([fdo#109271]) +3 similar issues
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-pnv-d510/igt@gem_ctx_create@basic-files.html
* igt@gem_exec_fence@basic-busy@ccs0:
- bat-dg2-11: NOTRUN -> [ABORT][35] ([i915#8233])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-dg2-11/igt@gem_exec_fence@basic-busy@ccs0.html
* igt@gem_exec_fence@basic-busy@ccs3:
- bat-dg2-9: NOTRUN -> [ABORT][36] ([i915#8233])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-dg2-9/igt@gem_exec_fence@basic-busy@ccs3.html
- bat-dg2-8: NOTRUN -> [ABORT][37] ([i915#8233])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-dg2-8/igt@gem_exec_fence@basic-busy@ccs3.html
* igt@gem_exec_fence@basic-busy@rcs0:
- fi-blb-e6850: NOTRUN -> [ABORT][38] ([i915#8233])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-blb-e6850/igt@gem_exec_fence@basic-busy@rcs0.html
- fi-pnv-d510: NOTRUN -> [ABORT][39] ([i915#8233])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-pnv-d510/igt@gem_exec_fence@basic-busy@rcs0.html
* igt@gem_exec_fence@basic-busy@vcs0:
- fi-ivb-3770: NOTRUN -> [ABORT][40] ([i915#8233])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-ivb-3770/igt@gem_exec_fence@basic-busy@vcs0.html
- fi-elk-e7500: NOTRUN -> [ABORT][41] ([i915#8233])
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-elk-e7500/igt@gem_exec_fence@basic-busy@vcs0.html
- fi-ilk-650: NOTRUN -> [ABORT][42] ([i915#8233])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-ilk-650/igt@gem_exec_fence@basic-busy@vcs0.html
* igt@gem_exec_fence@basic-busy@vecs0:
- bat-adlp-9: NOTRUN -> [ABORT][43] ([i915#8233])
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-adlp-9/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-skl-guc: NOTRUN -> [ABORT][44] ([i915#8233])
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-skl-guc/igt@gem_exec_fence@basic-busy@vecs0.html
- bat-rpls-2: NOTRUN -> [ABORT][45] ([i915#8233])
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-rpls-2/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-kbl-soraka: NOTRUN -> [ABORT][46] ([i915#8233])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@vecs0.html
- bat-dg1-6: NOTRUN -> [ABORT][47] ([i915#8233])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-dg1-6/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-cfl-8109u: NOTRUN -> [ABORT][48] ([i915#8233])
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-cfl-8109u/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-kbl-7567u: NOTRUN -> [ABORT][49] ([i915#8233])
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-kbl-7567u/igt@gem_exec_fence@basic-busy@vecs0.html
- bat-adln-1: NOTRUN -> [ABORT][50] ([i915#8233])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-adln-1/igt@gem_exec_fence@basic-busy@vecs0.html
- bat-jsl-1: NOTRUN -> [ABORT][51] ([i915#8233])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-jsl-1/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-bsw-nick: NOTRUN -> [ABORT][52] ([i915#8233])
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-bsw-nick/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-kbl-guc: NOTRUN -> [ABORT][53] ([i915#8233])
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-kbl-guc/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-cfl-8700k: NOTRUN -> [ABORT][54] ([i915#8233])
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-cfl-8700k/igt@gem_exec_fence@basic-busy@vecs0.html
- bat-adlm-1: NOTRUN -> [ABORT][55] ([i915#8233])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-adlm-1/igt@gem_exec_fence@basic-busy@vecs0.html
- bat-rplp-1: NOTRUN -> [ABORT][56] ([i915#8233])
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-rplp-1/igt@gem_exec_fence@basic-busy@vecs0.html
- bat-rpls-1: NOTRUN -> [ABORT][57] ([i915#8233])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-rpls-1/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-tgl-1115g4: NOTRUN -> [ABORT][58] ([i915#8233])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-tgl-1115g4/igt@gem_exec_fence@basic-busy@vecs0.html
- bat-adlp-6: NOTRUN -> [ABORT][59] ([i915#8233])
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-adlp-6/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-rkl-11600: NOTRUN -> [ABORT][60] ([i915#8233])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-rkl-11600/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-skl-6600u: NOTRUN -> [ABORT][61] ([i915#8233])
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-skl-6600u/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-bsw-n3050: NOTRUN -> [ABORT][62] ([i915#8233])
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-bsw-n3050/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-apl-guc: NOTRUN -> [ABORT][63] ([i915#8233])
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-apl-guc/igt@gem_exec_fence@basic-busy@vecs0.html
- bat-dg1-5: NOTRUN -> [ABORT][64] ([i915#8233])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-dg1-5/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-cfl-guc: NOTRUN -> [ABORT][65] ([i915#8233])
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-cfl-guc/igt@gem_exec_fence@basic-busy@vecs0.html
- bat-dg1-7: NOTRUN -> [ABORT][66] ([i915#8233])
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-dg1-7/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-kbl-x1275: NOTRUN -> [ABORT][67] ([i915#8233])
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-kbl-x1275/igt@gem_exec_fence@basic-busy@vecs0.html
- bat-jsl-3: NOTRUN -> [ABORT][68] ([i915#8233])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/bat-jsl-3/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-glk-j4005: NOTRUN -> [ABORT][69] ([i915#8233])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-glk-j4005/igt@gem_exec_fence@basic-busy@vecs0.html
- fi-hsw-4770: NOTRUN -> [ABORT][70] ([i915#8233])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/fi-hsw-4770/igt@gem_exec_fence@basic-busy@vecs0.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#8233]: https://gitlab.freedesktop.org/drm/intel/issues/8233
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7175 -> IGTPW_8540
CI-20190529: 20190529
CI_DRM_12790: 92b7ba2b502495a393b6db904061b6938a09db17 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8540: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/index.html
IGT_7175: e825eb183729902489365e56bd99f15af2aa3316 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/index.html
[-- Attachment #2: Type: text/html, Size: 20415 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for lib/igt_pm: make igt_pm_dmc_loaded() more robust
2023-02-28 14:29 [igt-dev] [PATCH i-g-t] lib/igt_pm: make igt_pm_dmc_loaded() more robust Jani Nikula
2023-02-28 14:33 ` Imre Deak
2023-02-28 14:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-02-28 15:53 ` Patchwork
2 siblings, 0 replies; 5+ messages in thread
From: Patchwork @ 2023-02-28 15:53 UTC (permalink / raw)
To: Jani Nikula; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 11975 bytes --]
== Series Details ==
Series: lib/igt_pm: make igt_pm_dmc_loaded() more robust
URL : https://patchwork.freedesktop.org/series/114477/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_12790_full -> IGTPW_8540_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_8540_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_8540_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/index.html
Participating hosts (9 -> 10)
------------------------------
Additional (1): shard-rkl
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_8540_full:
### IGT changes ###
#### Possible regressions ####
* igt@prime_vgem@fence-wait@rcs0:
- shard-snb: NOTRUN -> [ABORT][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-snb2/igt@prime_vgem@fence-wait@rcs0.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@vgem_basic@dmabuf-mmap:
- {shard-rkl}: NOTRUN -> [ABORT][2] +1 similar issue
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-rkl-1/igt@vgem_basic@dmabuf-mmap.html
Known issues
------------
Here are the changes found in IGTPW_8540_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@engines-mixed-process:
- shard-snb: NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#1099]) +10 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-snb4/igt@gem_ctx_persistence@engines-mixed-process.html
* igt@gem_exec_await@wide-all:
- shard-tglu-9: NOTRUN -> [ABORT][4] ([i915#8233]) +1 similar issue
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-tglu-9/igt@gem_exec_await@wide-all.html
* igt@gem_exec_fair@basic-none-rrul@rcs0:
- shard-tglu-9: NOTRUN -> [FAIL][5] ([i915#2842])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-tglu-9/igt@gem_exec_fair@basic-none-rrul@rcs0.html
* igt@gem_pread@exhaustion:
- shard-snb: NOTRUN -> [ABORT][6] ([i915#8233]) +22 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-snb4/igt@gem_pread@exhaustion.html
* igt@gem_pxp@reject-modify-context-protection-off-3:
- shard-snb: NOTRUN -> [SKIP][7] ([fdo#109271]) +498 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-snb4/igt@gem_pxp@reject-modify-context-protection-off-3.html
- shard-tglu-9: NOTRUN -> [SKIP][8] ([i915#4270])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-tglu-9/igt@gem_pxp@reject-modify-context-protection-off-3.html
* igt@gem_userptr_blits@unsync-unmap-after-close:
- shard-tglu-9: NOTRUN -> [SKIP][9] ([i915#3297])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-tglu-9/igt@gem_userptr_blits@unsync-unmap-after-close.html
* igt@gem_wait@write-busy@rcs0:
- shard-snb: NOTRUN -> [DMESG-WARN][10] ([i915#8233]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-snb4/igt@gem_wait@write-busy@rcs0.html
* igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip:
- shard-tglu-9: NOTRUN -> [SKIP][11] ([i915#1845] / [i915#7651]) +7 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-tglu-9/igt@kms_big_fb@x-tiled-max-hw-stride-32bpp-rotate-0-hflip.html
* igt@kms_busy@basic-hang:
- shard-tglu-9: NOTRUN -> [SKIP][12] ([i915#1845]) +4 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-tglu-9/igt@kms_busy@basic-hang.html
* igt@kms_chamelium_hpd@vga-hpd-after-suspend:
- shard-tglu-9: NOTRUN -> [SKIP][13] ([i915#7828])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-tglu-9/igt@kms_chamelium_hpd@vga-hpd-after-suspend.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt:
- shard-tglu-9: NOTRUN -> [SKIP][14] ([i915#1849]) +10 similar issues
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-tglu-9/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-indfb-msflip-blt.html
* igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf:
- shard-tglu-9: NOTRUN -> [SKIP][15] ([i915#658])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-tglu-9/igt@kms_psr2_sf@overlay-plane-move-continuous-exceed-sf.html
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-a:
- shard-tglu-9: NOTRUN -> [SKIP][16] ([fdo#109274])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/shard-tglu-9/igt@kms_universal_plane@disable-primary-vs-flip-pipe-a.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109307]: https://bugs.freedesktop.org/show_bug.cgi?id=109307
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1722]: https://gitlab.freedesktop.org/drm/intel/issues/1722
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1850]: https://gitlab.freedesktop.org/drm/intel/issues/1850
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3323]: https://gitlab.freedesktop.org/drm/intel/issues/3323
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3536]: https://gitlab.freedesktop.org/drm/intel/issues/3536
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3966]: https://gitlab.freedesktop.org/drm/intel/issues/3966
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6259]: https://gitlab.freedesktop.org/drm/intel/issues/6259
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6344]: https://gitlab.freedesktop.org/drm/intel/issues/6344
[i915#6412]: https://gitlab.freedesktop.org/drm/intel/issues/6412
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7178]: https://gitlab.freedesktop.org/drm/intel/issues/7178
[i915#7456]: https://gitlab.freedesktop.org/drm/intel/issues/7456
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7707]: https://gitlab.freedesktop.org/drm/intel/issues/7707
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
[i915#8154]: https://gitlab.freedesktop.org/drm/intel/issues/8154
[i915#8233]: https://gitlab.freedesktop.org/drm/intel/issues/8233
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7175 -> IGTPW_8540
CI-20190529: 20190529
CI_DRM_12790: 92b7ba2b502495a393b6db904061b6938a09db17 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_8540: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/index.html
IGT_7175: e825eb183729902489365e56bd99f15af2aa3316 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_8540/index.html
[-- Attachment #2: Type: text/html, Size: 7831 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] lib/igt_pm: make igt_pm_dmc_loaded() more robust
2023-02-28 14:33 ` Imre Deak
@ 2023-02-28 17:30 ` Jani Nikula
0 siblings, 0 replies; 5+ messages in thread
From: Jani Nikula @ 2023-02-28 17:30 UTC (permalink / raw)
To: imre.deak; +Cc: igt-dev
On Tue, 28 Feb 2023, Imre Deak <imre.deak@intel.com> wrote:
> On Tue, Feb 28, 2023 at 04:29:51PM +0200, Jani Nikula wrote:
>> Make igt_pm_dmc_loaded() more robust against changes in the debugfs
>> file. Read the entire contents of the file, at least with the current
>> output. Preserve logged output even if something gets added in front of
>> the file, and don't depend on exact length of the first line.
>>
>> Cc: Imre Deak <imre.deak@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Imre Deak <imre.deak@intel.com>
Thanks for the review, pushed.
BR,
Jani.
>
>> ---
>> lib/igt_pm.c | 14 +++++++++++---
>> 1 file changed, 11 insertions(+), 3 deletions(-)
>>
>> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
>> index 26e8c9f05fdf..6c84e94f6307 100644
>> --- a/lib/igt_pm.c
>> +++ b/lib/igt_pm.c
>> @@ -785,6 +785,11 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
>> return ret;
>> }
>>
>> +static const char *yesno(bool x)
>> +{
>> + return x ? "yes" : "no";
>> +}
>> +
>> /**
>> * dmc_loaded:
>> * @debugfs: fd to the debugfs dir.
>> @@ -798,7 +803,8 @@ bool igt_wait_for_pm_status(enum igt_runtime_pm_status status)
>> */
>> bool igt_pm_dmc_loaded(int debugfs)
>> {
>> - char buf[15];
>> + char buf[512];
>> + bool loaded;
>> int len;
>>
>> len = igt_sysfs_read(debugfs, "i915_dmc_info", buf, sizeof(buf) - 1);
>> @@ -807,8 +813,10 @@ bool igt_pm_dmc_loaded(int debugfs)
>>
>> buf[len] = '\0';
>>
>> - igt_info("DMC: %s\n", buf);
>> - return strstr(buf, "fw loaded: yes");
>> + loaded = strstr(buf, "fw loaded: yes");
>> + igt_info("DMC: fw loaded: %s\n", yesno(loaded));
>> +
>> + return loaded;
>> }
>>
>> /**
>> --
>> 2.39.1
>>
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-28 17:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-28 14:29 [igt-dev] [PATCH i-g-t] lib/igt_pm: make igt_pm_dmc_loaded() more robust Jani Nikula
2023-02-28 14:33 ` Imre Deak
2023-02-28 17:30 ` Jani Nikula
2023-02-28 14:48 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-02-28 15:53 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox