* [igt-dev] [PATCH i-g-t] sw_sync: Initialise struct before use
@ 2019-01-30 22:18 Chris Wilson
2019-01-30 23:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Chris Wilson @ 2019-01-30 22:18 UTC (permalink / raw)
To: igt-dev
sw_sync: ../lib/igt_core.c:1592: __igt_fork_helper: Assertion `!proc->running'
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108889
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
tests/sw_sync.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/sw_sync.c b/tests/sw_sync.c
index 207908ed7..ac4caf8ba 100644
--- a/tests/sw_sync.c
+++ b/tests/sw_sync.c
@@ -171,12 +171,11 @@ static void test_sync_busy(void)
static void test_sync_busy_fork_unixsocket(void)
{
+ struct igt_helper_process proc = {};
int fence;
int timeline;
int skip = 0;
int sv[2];
- struct igt_helper_process proc;
-
timeline = sw_sync_timeline_create();
fence = sw_sync_timeline_create_fence(timeline, 1);
@@ -258,10 +257,10 @@ out:
static void test_sync_busy_fork(void)
{
+ struct igt_helper_process proc = {};
int fence;
int timeline;
int skip = 0;
- struct igt_helper_process proc;
timeline = sw_sync_timeline_create();
fence = sw_sync_timeline_create_fence(timeline, 1);
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for sw_sync: Initialise struct before use
2019-01-30 22:18 [igt-dev] [PATCH i-g-t] sw_sync: Initialise struct before use Chris Wilson
@ 2019-01-30 23:01 ` Patchwork
2019-01-31 9:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-31 9:10 ` [igt-dev] [PATCH i-g-t] " Jani Nikula
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-01-30 23:01 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: sw_sync: Initialise struct before use
URL : https://patchwork.freedesktop.org/series/56011/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5514 -> IGTPW_2323
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56011/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2323 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
- fi-blb-e6850: PASS -> INCOMPLETE [fdo#107718]
* igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
- fi-apl-guc: PASS -> DMESG-WARN [fdo#108566]
- fi-kbl-7560u: PASS -> FAIL [fdo#103375]
* igt@pm_rpm@module-reload:
- fi-skl-6770hq: PASS -> FAIL [fdo#108511]
#### Possible fixes ####
* igt@kms_busy@basic-flip-b:
- fi-gdg-551: FAIL [fdo#103182] -> PASS
* igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
- fi-byt-clapper: FAIL [fdo#103191] / [fdo#107362] -> PASS +1
[fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
Participating hosts (44 -> 41)
------------------------------
Missing (3): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan
Build changes
-------------
* IGT: IGT_4801 -> IGTPW_2323
CI_DRM_5514: 8a7e6109652e58be9c43e2a7a4d318a7c5b34fef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2323: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2323/
IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2323/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for sw_sync: Initialise struct before use
2019-01-30 22:18 [igt-dev] [PATCH i-g-t] sw_sync: Initialise struct before use Chris Wilson
2019-01-30 23:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-01-31 9:00 ` Patchwork
2019-01-31 9:10 ` [igt-dev] [PATCH i-g-t] " Jani Nikula
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2019-01-31 9:00 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: sw_sync: Initialise struct before use
URL : https://patchwork.freedesktop.org/series/56011/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_5514_full -> IGTPW_2323_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/56011/revisions/1/mbox/
Known issues
------------
Here are the changes found in IGTPW_2323_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_suspend@basic-s3:
- shard-kbl: PASS -> INCOMPLETE [fdo#103665]
* igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
- shard-glk: PASS -> FAIL [fdo#108145]
* igt@kms_cursor_crc@cursor-128x42-random:
- shard-kbl: NOTRUN -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-glk: PASS -> FAIL [fdo#103232] +1
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-apl: PASS -> FAIL [fdo#103232] +4
* igt@kms_cursor_crc@cursor-256x85-sliding:
- shard-kbl: PASS -> FAIL [fdo#103232]
* igt@kms_cursor_crc@cursor-64x21-sliding:
- shard-hsw: PASS -> INCOMPLETE [fdo#103540]
* igt@kms_cursor_crc@cursor-64x64-suspend:
- shard-apl: PASS -> FAIL [fdo#103191] / [fdo#103232]
* igt@kms_cursor_legacy@2x-flip-vs-cursor-atomic:
- shard-glk: PASS -> FAIL [fdo#104873]
* igt@kms_flip@dpms-vs-vblank-race-interruptible:
- shard-glk: PASS -> FAIL [fdo#103060]
* igt@kms_plane@pixel-format-pipe-a-planes-source-clamping:
- shard-glk: PASS -> FAIL [fdo#108948]
- shard-apl: NOTRUN -> FAIL [fdo#108948]
- shard-kbl: PASS -> FAIL [fdo#108948]
* igt@kms_plane_multiple@atomic-pipe-b-tiling-none:
- shard-glk: PASS -> FAIL [fdo#103166] +2
* igt@kms_rotation_crc@multiplane-rotation-cropping-bottom:
- shard-glk: PASS -> DMESG-FAIL [fdo#105763] / [fdo#106538]
* igt@kms_setmode@basic:
- shard-hsw: PASS -> FAIL [fdo#99912]
* igt@perf_pmu@rc6-runtime-pm-long:
- shard-kbl: PASS -> FAIL [fdo#105010]
#### Possible fixes ####
* igt@gem_eio@reset-stress:
- shard-snb: INCOMPLETE [fdo#105411] -> PASS
* igt@gem_workarounds@suspend-resume:
- shard-kbl: INCOMPLETE [fdo#103665] -> PASS
* igt@kms_available_modes_crc@available_mode_test_crc:
- shard-kbl: FAIL [fdo#106641] -> PASS
* igt@kms_ccs@pipe-a-crc-sprite-planes-basic:
- shard-apl: FAIL [fdo#106510] / [fdo#108145] -> PASS
* igt@kms_color@pipe-a-degamma:
- shard-apl: FAIL [fdo#104782] / [fdo#108145] -> PASS
* igt@kms_cursor_crc@cursor-256x85-onscreen:
- shard-apl: FAIL [fdo#103232] -> PASS +2
* igt@kms_cursor_crc@cursor-256x85-random:
- shard-glk: FAIL [fdo#103232] -> PASS +1
* igt@kms_cursor_crc@cursor-64x64-sliding:
- shard-kbl: FAIL [fdo#103232] -> PASS
* igt@kms_cursor_legacy@2x-long-flip-vs-cursor-atomic:
- shard-glk: FAIL [fdo#104873] -> PASS
* igt@kms_flip@flip-vs-expired-vblank:
- shard-glk: FAIL [fdo#105363] -> PASS
* igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
- shard-apl: FAIL [fdo#108145] -> PASS
* igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
- shard-glk: FAIL [fdo#103166] -> PASS +4
* igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
- shard-apl: FAIL [fdo#103166] -> PASS +6
- shard-kbl: FAIL [fdo#103166] -> PASS +2
* igt@kms_setmode@basic:
- shard-apl: FAIL [fdo#99912] -> PASS
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
[fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
[fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
[fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
[fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
[fdo#104873]: https://bugs.freedesktop.org/show_bug.cgi?id=104873
[fdo#105010]: https://bugs.freedesktop.org/show_bug.cgi?id=105010
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#106510]: https://bugs.freedesktop.org/show_bug.cgi?id=106510
[fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
[fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
Participating hosts (7 -> 5)
------------------------------
Missing (2): shard-skl shard-iclb
Build changes
-------------
* IGT: IGT_4801 -> IGTPW_2323
* Piglit: piglit_4509 -> None
CI_DRM_5514: 8a7e6109652e58be9c43e2a7a4d318a7c5b34fef @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_2323: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2323/
IGT_4801: 6f6bacf12759fb319ade3ba37861ae711f8a5cd9 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2323/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] sw_sync: Initialise struct before use
2019-01-30 22:18 [igt-dev] [PATCH i-g-t] sw_sync: Initialise struct before use Chris Wilson
2019-01-30 23:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-31 9:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2019-01-31 9:10 ` Jani Nikula
2019-01-31 9:16 ` Chris Wilson
2 siblings, 1 reply; 6+ messages in thread
From: Jani Nikula @ 2019-01-31 9:10 UTC (permalink / raw)
To: Chris Wilson, igt-dev
On Wed, 30 Jan 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> sw_sync: ../lib/igt_core.c:1592: __igt_fork_helper: Assertion `!proc->running'
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108889
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
So the compiler sees the variable is uninitialized, but it's being
passed to a function... jolly good, that must do the initialization. :/
I trust you checked the other call sites.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> tests/sw_sync.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/tests/sw_sync.c b/tests/sw_sync.c
> index 207908ed7..ac4caf8ba 100644
> --- a/tests/sw_sync.c
> +++ b/tests/sw_sync.c
> @@ -171,12 +171,11 @@ static void test_sync_busy(void)
>
> static void test_sync_busy_fork_unixsocket(void)
> {
> + struct igt_helper_process proc = {};
> int fence;
> int timeline;
> int skip = 0;
> int sv[2];
> - struct igt_helper_process proc;
> -
>
> timeline = sw_sync_timeline_create();
> fence = sw_sync_timeline_create_fence(timeline, 1);
> @@ -258,10 +257,10 @@ out:
>
> static void test_sync_busy_fork(void)
> {
> + struct igt_helper_process proc = {};
> int fence;
> int timeline;
> int skip = 0;
> - struct igt_helper_process proc;
>
> timeline = sw_sync_timeline_create();
> fence = sw_sync_timeline_create_fence(timeline, 1);
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] sw_sync: Initialise struct before use
2019-01-31 9:10 ` [igt-dev] [PATCH i-g-t] " Jani Nikula
@ 2019-01-31 9:16 ` Chris Wilson
2019-01-31 9:18 ` Chris Wilson
0 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2019-01-31 9:16 UTC (permalink / raw)
To: Jani Nikula, igt-dev
Quoting Jani Nikula (2019-01-31 09:10:53)
> On Wed, 30 Jan 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > sw_sync: ../lib/igt_core.c:1592: __igt_fork_helper: Assertion `!proc->running'
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108889
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> So the compiler sees the variable is uninitialized, but it's being
> passed to a function... jolly good, that must do the initialization. :/
>
> I trust you checked the other call sites.
In this file only.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] sw_sync: Initialise struct before use
2019-01-31 9:16 ` Chris Wilson
@ 2019-01-31 9:18 ` Chris Wilson
0 siblings, 0 replies; 6+ messages in thread
From: Chris Wilson @ 2019-01-31 9:18 UTC (permalink / raw)
To: Jani Nikula, igt-dev
Quoting Chris Wilson (2019-01-31 09:16:51)
> Quoting Jani Nikula (2019-01-31 09:10:53)
> > On Wed, 30 Jan 2019, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > > sw_sync: ../lib/igt_core.c:1592: __igt_fork_helper: Assertion `!proc->running'
> > >
> > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108889
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >
> > So the compiler sees the variable is uninitialized, but it's being
> > passed to a function... jolly good, that must do the initialization. :/
> >
> > I trust you checked the other call sites.
>
> In this file only.
All others check out.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-01-31 9:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-30 22:18 [igt-dev] [PATCH i-g-t] sw_sync: Initialise struct before use Chris Wilson
2019-01-30 23:01 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-01-31 9:00 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-01-31 9:10 ` [igt-dev] [PATCH i-g-t] " Jani Nikula
2019-01-31 9:16 ` Chris Wilson
2019-01-31 9:18 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox