From: Eric Anholt <eric@anholt.net>
To: Jani Nikula <jani.nikula@linux.intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 2/2] v3d: Add tests for hanging V3D using an RCL.
Date: Wed, 28 Nov 2018 14:04:13 -0800 [thread overview]
Message-ID: <87k1kweu5e.fsf@anholt.net> (raw)
In-Reply-To: <87lg5da1ho.fsf@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 413 bytes --]
Jani Nikula <jani.nikula@linux.intel.com> writes:
> On Tue, 27 Nov 2018, Eric Anholt <eric@anholt.net> wrote:
>> +/** Creates a simple CL consisting of a single NOP instruction. */
>> +struct v3d_cl *
>> +igt_v3d_cl_create_nop(int fd)
>> +{
>> + struct v3d_cl *cl = igt_v3d_cl_create(fd, 1);
>> + uint8_t nop_opcode = 1;
>
> Not really reviewing this, the indents with spaces just caught my eyes.
Fixed.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-11-28 22:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 20:46 [igt-dev] [PATCH i-g-t 1/2] meson: Drop -Wdeclaration-after-statement Eric Anholt
2018-11-27 20:46 ` [igt-dev] [PATCH i-g-t 2/2] v3d: Add tests for hanging V3D using an RCL Eric Anholt
2018-11-28 11:24 ` Jani Nikula
2018-11-28 22:04 ` Eric Anholt [this message]
2018-11-27 23:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] meson: Drop -Wdeclaration-after-statement Patchwork
2018-11-28 11:21 ` [igt-dev] [PATCH i-g-t 1/2] " Jani Nikula
2018-11-28 11:48 ` [igt-dev] ✗ Fi.CI.IGT: failure for series starting with [i-g-t,1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1kweu5e.fsf@anholt.net \
--to=eric@anholt.net \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox