From: Jani Nikula <jani.nikula@linux.intel.com>
To: Eric Anholt <eric@anholt.net>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] meson: Drop -Wdeclaration-after-statement.
Date: Wed, 28 Nov 2018 13:21:57 +0200 [thread overview]
Message-ID: <87o9a9a1m2.fsf@intel.com> (raw)
In-Reply-To: <20181127204603.24042-1-eric@anholt.net>
On Tue, 27 Nov 2018, Eric Anholt <eric@anholt.net> wrote:
> Being able to move declarations later is very useful in making clear,
> concise code.
I guess you primarily need this in patch 2/2 for declaring the loop
variable in the for statement. I like that, just not the general case of
declarations after statements. Anyway, I'll let others fight the holy
wars on this. ;)
BR,
Jani.
>
> Signed-off-by: Eric Anholt <eric@anholt.net>
> ---
> meson.build | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/meson.build b/meson.build
> index 469723dc4633..c5aab78716d5 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -11,7 +11,6 @@ cc = meson.get_compiler('c')
>
> cc_args = [
> '-Wbad-function-cast',
> - '-Wdeclaration-after-statement',
> '-Wformat=2',
> # igt_assert(0) in switch statements triggers a bunch of this.
> '-Wimplicit-fallthrough=0',
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-11-28 11:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 20:46 [igt-dev] [PATCH i-g-t 1/2] meson: Drop -Wdeclaration-after-statement Eric Anholt
2018-11-27 20:46 ` [igt-dev] [PATCH i-g-t 2/2] v3d: Add tests for hanging V3D using an RCL Eric Anholt
2018-11-28 11:24 ` Jani Nikula
2018-11-28 22:04 ` Eric Anholt
2018-11-27 23:30 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] meson: Drop -Wdeclaration-after-statement Patchwork
2018-11-28 11:21 ` Jani Nikula [this message]
2018-11-28 11:48 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9a9a1m2.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=eric@anholt.net \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox