Re: [PATCH] drm/xe/oa: Wa_14026633728

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 24 Apr 2026 01:13:54 -0700, Shekhar Chauhan wrote:
>

Hi Shekhar,

The patch title prefix "drm/xe/oa: " is incorrect. Please use the same
prefix as in previous commits.

> For MERT_OA in CRI, the OA_Buffer is in device memory. The minimum
> exponent needed for it is 8. Bump it up.

For MERTOA in CRI, oa buffer can be in device memory. Because of slower
device mem access, OA exponent values lower than 8 can result in buffer
overflows. Bump the OA exponent value.

>
> Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
> ---
>  tests/intel/xe_oa.c | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index 988c46df6..7bd9d17c4 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -2645,6 +2645,12 @@ test_non_zero_reason(const struct drm_xe_oa_unit *oau, size_t oa_buffer_size)
>  {
>	/* ~20 micro second period */
>	int oa_exponent = max_oa_exponent_for_period_lte(20000);
> +
> +	/* Wa_14026633728: MERTOA buffer on CRI is in device memory,
> +	 * minimum exponent to avoid overflow is 8 */

/*
 * Wa_14026633728: For MERTOA in CRI, oa buffer can be in device memory.
 * Because of slower device mem access, OA exponent values lower than 8 can
 * result in buffer overflows.
 */

> +	if (oau->oa_unit_type == DRM_XE_OA_UNIT_TYPE_MERT && IS_CRESCENTISLAND(devid))
> +		oa_exponent = max(oa_exponent, 8);
> +

The actual code is good!!!


>	struct intel_xe_perf_metric_set *test_set = oa_unit_metric_set(oau);
>	uint64_t fmt = test_set->perf_oa_format;
>	size_t report_size = get_oa_format(fmt).size;
> --
> 2.53.0
>

Thanks.
--
Ashutosh