Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_gt: Check for shared reset domain

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 07 Jan 2022 08:19:19 -0800, <priyanka.dandamudi@intel.com> wrote:
>
> +bool has_shared_reset_domain(int fd, const intel_ctx_t *ctx, const struct intel_execution_engine2 *e)

e is just a variable for the iterator, do not pass it in, declare locally.

> +	for_each_ctx_engine (fd, ctx, e) {
> +                if (rcs0 && ccs0)
> +                        break;
> +                else if (e->class == I915_ENGINE_CLASS_RENDER && e->instance == 0)
> +                                rcs0 = true;
> +                else if (e->class == I915_ENGINE_CLASS_COMPUTE && e->instance == 0)
> +                                ccs0 = true;
> +        }
> +        return (rcs0 && ccs0);

* Code above uses spaces instead of tabs
* Indentation is wrong
* Check for e->instance is unnecessary, remove it

Let's fix this cosmetic stuff first and then we can actually review the
patch and see how it gels with other series pending review in this area.