Re: [PATCH i-g-t 1/1] tests/intel/xe_eu_stall: Use the fastest sampling rate from the query IOCTL data

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Wed, 10 Sep 2025 18:36:13 -0700, Harish Chegondi wrote:
>
> Earlier commit 157b34af65168 ("tests/intel/xe_eu_stall: Use default sampling rate
> from the query IOCTL data") used a mid sampling rate from those returned
> from the query IOCTL, if the user doesn't pass a sampling rate. However, some
> GPUs, sometimes, aren't generating any EU stall data with the mid sampling
> rate with 100 iterations of GPGPU fill. So, Use the fastest sampling rate
> from the query IOCTL data so that there is always some EU stall data
> generated with GPGPU fill.

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Signed-off-by: Harish Chegondi <harish.chegondi@intel.com>
> ---
>  tests/intel/xe_eu_stall.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/tests/intel/xe_eu_stall.c b/tests/intel/xe_eu_stall.c
> index f09e525eb..f5c57a9b3 100644
> --- a/tests/intel/xe_eu_stall.c
> +++ b/tests/intel/xe_eu_stall.c
> @@ -648,7 +648,7 @@ igt_main_args("e:g:o:r:u:w:", long_options, help_str, opt_handler, NULL)
>  {
>	bool blocking_read = true;
>	struct xe_device *xe_dev;
> -	int drm_fd, idx;
> +	int drm_fd;
>	uint32_t devid;
>	struct stat sb;
>
> @@ -665,10 +665,8 @@ igt_main_args("e:g:o:r:u:w:", long_options, help_str, opt_handler, NULL)
>		query_eu_stall_data = xe_dev->eu_stall;
>		igt_assert(query_eu_stall_data->num_sampling_rates > 0);
>		/* If the user doesn't pass a sampling rate, use a mid sampling rate */
> -		if (p_rate == 0) {
> -			idx = query_eu_stall_data->num_sampling_rates / 2;
> -			p_rate = query_eu_stall_data->sampling_rates[idx];
> -		}
> +		if (p_rate == 0)
> +			p_rate = query_eu_stall_data->sampling_rates[0];
>
>		if (output_file) {
>			output = fopen(output_file, "w");
> --
> 2.51.0
>