From: Mika Kuoppala <mika.kuoppala@linux.intel.com>
To: Talha Nassar <talha.nassar@intel.com>, igt-dev@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_workarounds: adding 0xe420 register to WO list
Date: Thu, 20 Dec 2018 12:54:33 +0200 [thread overview]
Message-ID: <87o99g5uza.fsf@gaia.fi.intel.com> (raw)
In-Reply-To: <1545239432-4936-1-git-send-email-talha.nassar@intel.com>
Talha Nassar <talha.nassar@intel.com> writes:
> From: talha nassar <talha.nassar@intel.com>
>
> HW team confirmed that this register is write-only.
It could be that it is that bit only. We don't need
to care about that now,
Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=107338
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> Signed-off-by: talha nassar <talha.nassar@intel.com>
> ---
> tests/i915/gem_workarounds.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_workarounds.c b/tests/i915/gem_workarounds.c
> index 78478ad..b7d7d9c 100644
> --- a/tests/i915/gem_workarounds.c
> +++ b/tests/i915/gem_workarounds.c
> @@ -51,7 +51,8 @@ static struct write_only_list {
> unsigned int gen;
> uint32_t addr;
> } wo_list[] = {
> - { 10, 0xE5F0 } /* WaForceContextSaveRestoreNonCoherent:cnl */
> + { 10, 0xE5F0 }, /* WaForceContextSaveRestoreNonCoherent:cnl */
> + { 11, 0xE420 } /* WaEnableFloatBlendOptimization:icl */
>
> /*
> * FIXME: If you are contemplating adding stuff here
> --
> 2.7.4
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-12-20 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 17:10 [igt-dev] [PATCH i-g-t] i915/gem_workarounds: adding 0xe420 register to WO list Talha Nassar
2018-12-19 17:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-19 19:13 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-12-20 10:54 ` Mika Kuoppala [this message]
2018-12-20 11:01 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o99g5uza.fsf@gaia.fi.intel.com \
--to=mika.kuoppala@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=talha.nassar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox