Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org, Jason Ekstrand <jason@jlekstrand.net>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/gem_exec_params: Fix context within which batch is executed
Date: Wed, 25 Aug 2021 11:48:07 -0700	[thread overview]
Message-ID: <87pmu1z7h4.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20210825075149.81624-1-zbigniew.kempczynski@intel.com>

On Wed, 25 Aug 2021 00:51:49 -0700, Zbigniew Kempczyński wrote:
>
> With new intel_ctx_t we're responsible to set execbuf rsvd1 (context) id
> field. As same field exists for exec object there's risk to mechanically
> set improper field and compiler won't complain.

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Cc: Jason Ekstrand <jason@jlekstrand.net>
> ---
>  tests/i915/gem_exec_params.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_exec_params.c b/tests/i915/gem_exec_params.c
> index ba79791a1..d247b8a61 100644
> --- a/tests/i915/gem_exec_params.c
> +++ b/tests/i915/gem_exec_params.c
> @@ -334,11 +334,11 @@ static void test_larger_than_life_batch(int fd)
>	const intel_ctx_t *ctx = intel_ctx_create_all_physical(fd);
>	struct drm_i915_gem_exec_object2 exec = {
>		.handle = batch_create_size(fd, size),
> -		.rsvd1 = ctx->id,
>	};
>	struct drm_i915_gem_execbuffer2 execbuf = {
>		.buffers_ptr = to_user_pointer(&exec),
>		.buffer_count = 1,
> +		.rsvd1 = ctx->id,
>	};
>
>	/*
> --
> 2.26.0
>

      parent reply	other threads:[~2021-08-25 18:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25  7:51 [igt-dev] [PATCH i-g-t] tests/gem_exec_params: Fix context within which batch is executed Zbigniew Kempczyński
2021-08-25  8:34 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-08-25 14:35 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-08-25 17:36   ` Zbigniew Kempczyński
2021-08-25 18:05     ` Vudum, Lakshminarayana
2021-08-25 17:51 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
2021-08-25 18:48 ` Dixit, Ashutosh [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmu1z7h4.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jason@jlekstrand.net \
    --cc=zbigniew.kempczynski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox