Re: [igt-dev] [PATCH i-g-t] lib/i915: Add i915_drm_local.h

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Thu, 29 Jul 2021 01:25:18 -0700, Petri Latvala wrote:
>
> On Tue, Jul 27, 2021 at 10:17:00PM -0700, Ashutosh Dixit wrote:
> > It is necessary on occasion to add uapi declarations to IGT before they
> > appear in imported kernel uapi headers. This is typically done at present
> > using LOCAL declarations (or #ifndef's) which are dispersed across multiple
> > source and header files. Such declarations sometimes linger on in the code
> > for months or years till someone thinks of cleaning them up.
> >
> > As opposed to this, provide a central location (in i915_drm_local.h) for
> > such early uapi declarations in IGT. These declarations will be added to
> > i915_drm_local.h exactly as they are expected to appear in the kernel uapi
> > headers, i.e. without the LOCAL_ or local_ prefix. They can be cleaned up
> > when the uapi headers are sync'd or they can live on (if they don't
> > conflict with the kernel headers) but at least they will be in a single
> > place and more visible. At least that is the hope.
> >
> > Cc: Petri Latvala <petri.latvala@intel.com>
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> Centralizing these should make cleanup easier and happen more
> often.
>
> Reviewed-by: Petri Latvala <petri.latvala@intel.com>

Thanks Petri, merged.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev