Re: [igt-dev] [PATCH i-g-t v3] meson: Add options to control optional parts

From: Jani Nikula <jani.nikula@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: igt-dev@lists.freedesktop.org, Matt Turner <mattst88@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [igt-dev] [PATCH i-g-t v3] meson: Add options to control optional parts
Date: Thu, 28 Jun 2018 15:09:05 +0300	[thread overview]
Message-ID: <87po0bru3i.fsf@intel.com> (raw)
In-Reply-To: <20180628114608.GT13978@phenom.ffwll.local>

On Thu, 28 Jun 2018, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Thu, Jun 28, 2018 at 12:29:27PM +0300, Jani Nikula wrote:
>> On Mon, 25 Jun 2018, Arkadiusz Hiler <arkadiusz.hiler@intel.com> wrote:
>> > From: Petri Latvala <petri.latvala@intel.com>
>> >
>> > Distributions want explicit control over optional parts so they can
>> > state runtime dependencies before building. Let's restore the
>> > functionality autotools used to provide.
>> >
>> > Where possible, the selection is done by choosing whether to build a
>> > particular item and the option name is build_$item. Example:
>> > build_overlay. Where not possible, the option name is
>> > with_$item. Example: with_valgrind.
>> >
>> > Array options require a bump of required meson version to 0.44. Debian
>> > stable has meson 0.37 which is already too old, stable-backports has
>> > 0.45, CI uses 0.45. Mesa's meson requirement is 0.44.1, for a
>> > perspective.
>> 
>> I'm fine with the meson version requirement. However, for some reason
>> the meson_version : '>0.44.0' doesn't take effect for meson_options.txt:
>> 
>> """
>> $ rm -rf build; meson build
>> The Meson build system
>> Version: 0.42.1
>> Source dir: /home/jani/src/intel-gpu-tools
>> Build dir: /home/jani/src/intel-gpu-tools/build
>> Build type: native build
>> 
>> Meson encountered an error in file meson_options.txt, line 7, column 0:
>> Unknown type array.
>> """
>> 
>> I can obviously just update meson now that I figured it out, but is
>> there something we could do to be more helpful for the next person
>> hitting this?
>
> Huh, in my testing with older meson it bailed out right away after
> spotting the version requirement in the main meson.build file in the root
> directory. No idea how you managed to get past that.

Maybe that requires a newer version of meson! ;)

> Count me baffled ...

Makes two of us.

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev