Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
	igt-dev@lists.freedesktop.org
Cc: Matt Turner <mattst88@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [igt-dev] [PATCH i-g-t v3] meson: Add options to control optional parts
Date: Thu, 28 Jun 2018 12:29:27 +0300	[thread overview]
Message-ID: <87zhzfs1hk.fsf@intel.com> (raw)
In-Reply-To: <20180625071006.12736-1-arkadiusz.hiler@intel.com>

On Mon, 25 Jun 2018, Arkadiusz Hiler <arkadiusz.hiler@intel.com> wrote:
> From: Petri Latvala <petri.latvala@intel.com>
>
> Distributions want explicit control over optional parts so they can
> state runtime dependencies before building. Let's restore the
> functionality autotools used to provide.
>
> Where possible, the selection is done by choosing whether to build a
> particular item and the option name is build_$item. Example:
> build_overlay. Where not possible, the option name is
> with_$item. Example: with_valgrind.
>
> Array options require a bump of required meson version to 0.44. Debian
> stable has meson 0.37 which is already too old, stable-backports has
> 0.45, CI uses 0.45. Mesa's meson requirement is 0.44.1, for a
> perspective.

I'm fine with the meson version requirement. However, for some reason
the meson_version : '>0.44.0' doesn't take effect for meson_options.txt:

"""
$ rm -rf build; meson build
The Meson build system
Version: 0.42.1
Source dir: /home/jani/src/intel-gpu-tools
Build dir: /home/jani/src/intel-gpu-tools/build
Build type: native build

Meson encountered an error in file meson_options.txt, line 7, column 0:
Unknown type array.
"""

I can obviously just update meson now that I figured it out, but is
there something we could do to be more helpful for the next person
hitting this?

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-06-28  9:29 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-21 11:06 [igt-dev] [PATCH i-g-t 1/2] Make GLib mandatory Petri Latvala
2018-06-21 11:06 ` [igt-dev] [PATCH i-g-t 2/2] meson: Add options to control optional parts Petri Latvala
2018-06-21 11:29   ` Petri Latvala
2018-06-21 14:27     ` Daniel Vetter
2018-06-21 16:46     ` Lucas De Marchi
2018-06-22  8:27       ` Daniel Vetter
2018-06-25  7:10   ` [igt-dev] [PATCH i-g-t v3] " Arkadiusz Hiler
2018-06-28  9:29     ` Jani Nikula [this message]
2018-06-28 11:46       ` Daniel Vetter
2018-06-28 12:09         ` Jani Nikula
2018-06-21 11:32 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] Make GLib mandatory Patchwork
2018-06-21 13:59 ` [igt-dev] [PATCH i-g-t 1/2] " Daniel Vetter
2018-06-21 14:00   ` Daniel Vetter
2018-06-21 15:30 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] " Patchwork
2018-06-25  9:52 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] Make GLib mandatory (rev2) Patchwork
2018-06-25 12:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zhzfs1hk.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=arkadiusz.hiler@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mattst88@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox