Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	igt-dev@lists.freedesktop.org
Cc: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>,
	kamil.konieczny@intel.com, katarzyna.piecielska@intel.com
Subject: Re: [PATCH i-g-t v4] tools/mk_detect_intel_gpu: add a tool to detect Intel GPUs from their PCI IDs
Date: Thu, 23 May 2024 10:30:37 +0300	[thread overview]
Message-ID: <87r0dtouhu.fsf@intel.com> (raw)
In-Reply-To: <20240522144627.tdiadqyfgk67ox55@kamilkon-DESK.igk.intel.com>

On Wed, 22 May 2024, Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
> Looks like a good idea but this is also dependancy, btw

[snip]

> But this one is creating one more dependancy, one should have
> modules compiled in current running kernel.

Reading the comments about dependencies, I think this needs a different
perspective.

What is the target audience of the tool? What are they expected to have
around? What is the easiest for them to install?

lspci and modinfo are trivial to install, and most people have them
installed already. modinfo does not require the modules to be probed,
you can also point it at the .ko under /usr/lib/modules. For a user,
this gives information about the modules they actually have on their
system, which may be different from kernel or igt sources.

OTOH most people won't have kernel or igt sources available. (Let alone
specific versions of the source, which match the expectations of the
patch at hand.) Indeed, you can install igt via the distro package
manager, with no need to check out the sources.


BR,
Jani.


-- 
Jani Nikula, Intel

  parent reply	other threads:[~2024-05-23  7:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-22 12:02 [PATCH i-g-t v4] tools/mk_detect_intel_gpu: add a tool to detect Intel GPUs from their PCI IDs Mauro Carvalho Chehab
2024-05-22 12:54 ` Jani Nikula
2024-05-22 13:26   ` Jani Nikula
2024-05-22 14:46     ` Kamil Konieczny
2024-05-23  5:03       ` Mauro Carvalho Chehab
2024-05-23  7:26         ` Jani Nikula
2024-05-23  7:30       ` Jani Nikula [this message]
2024-05-23  8:36         ` Mauro Carvalho Chehab
2024-05-23  9:10           ` Jani Nikula
2024-05-23 17:31             ` Kamil Konieczny
2024-05-24  8:49               ` Jani Nikula
2024-05-25  5:44                 ` Mauro Carvalho Chehab
2024-06-03  7:35             ` Zbigniew Kempczyński
2024-06-04  8:05               ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0dtouhu.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@intel.com \
    --cc=kamil.konieczny@linux.intel.com \
    --cc=katarzyna.piecielska@intel.com \
    --cc=mauro.chehab@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox