Re: [PATCH i-g-t v4] tools/mk_detect_intel_gpu: add a tool to detect Intel GPUs from their PCI IDs

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 23 May 2024, Mauro Carvalho Chehab <mauro.chehab@linux.intel.com> wrote:
> On Wed, 22 May 2024 16:46:27 +0200
> Kamil Konieczny <kamil.konieczny@linux.intel.com> wrote:
>
>> Hi Jani,
>> On 2024-05-22 at 16:26:44 +0300, Jani Nikula wrote:
>> > On Wed, 22 May 2024, Jani Nikula <jani.nikula@intel.com> wrote:  
>> > > On Wed, 22 May 2024, Mauro Carvalho Chehab <mauro.chehab@linux.intel.com> wrote:  
>> > >> From: Mauro Carvalho Chehab <mchehab@kernel.org>
>> > >>
>> > >> Such tool parses the Kernel drivers for both i915 and Xe and
>> > >> generates a script that helps detecting Intel GPU models.  
>> > >
>> > > I acknowledge the usefulness of such a tool, but to be brutally honest,
>> > > this implementation is horrible in so many levels.
>> > >
>> > > IGT uses meson and avoids perl.  
>> 
>> imho this could also be a python script.
>
> Converting the output to a python script should be trivial and can be done
> later on. The generated script has a a simple hash/dict lookup logic.

It should not be a generated script in the first place. It should not
grep the kernel or igt sources for certain patterns which will
change. It should not have to be this complicated.

If it's C, it should be a regular build (via meson). If it's Python, it
should do all it needs to do when running it.


BR,
Jani.


-- 
Jani Nikula, Intel