From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Tauro, Riana" <riana.tauro@intel.com>
Cc: igt-dev@lists.freedesktop.org, Badal Nilawar <badal.nilawar@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/3] lib/igt_sysfs: Generic verification of writable sysfs attributes
Date: Thu, 15 Dec 2022 10:20:16 -0800 [thread overview]
Message-ID: <87r0x01qcf.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <fcf4298a-8f6b-c1e8-58c5-bdb9bb368587@intel.com>
On Thu, 15 Dec 2022 03:49:30 -0800, Tauro, Riana wrote:
>
> On 12/15/2022 8:01 AM, Ashutosh Dixit wrote:
> > +/* Sweep the range of values for an attribute to identify matching reads/writes */
> > +static int rw_attr_sweep(igt_sysfs_rw_attr_t *rw)
> > +{
> > + uint64_t get, set = rw->start;
> > + int num_points = 0;
> > + bool ret;
> > +
> Hi Ashutosh
>
> Thanks for the clarification regarding the clamp max on the previous rev.
> done sweeping igt_debug can be retained outside the while since there is no
> break/return anywhere else.
>
> Though not necessary since it behaves the same.
>
> Looks good to me
> Reviewed-by: Riana Tauro <riana.tauro@intel.com>
Thanks Riana, I made the above change and merged :)
next prev parent reply other threads:[~2022-12-15 18:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 2:31 [igt-dev] [PATCH i-g-t 0/3] i915/i915_hwmon: General verification of hwmon attributes Ashutosh Dixit
2022-12-15 2:31 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_sysfs: Generic verification of writable sysfs attributes Ashutosh Dixit
2022-12-15 11:49 ` Tauro, Riana
2022-12-15 18:20 ` Dixit, Ashutosh [this message]
2022-12-15 2:31 ` [igt-dev] [PATCH i-g-t 2/3] i915/i915_hwmon: General verification of hwmon attributes Ashutosh Dixit
2022-12-15 5:30 ` Tauro, Riana
2022-12-15 2:31 ` [igt-dev] [PATCH i-g-t 3/3] HAX: Add i915_hwmon* to fast-feedback.testlist Ashutosh Dixit
2022-12-15 3:08 ` [igt-dev] ✓ Fi.CI.BAT: success for i915/i915_hwmon: General verification of hwmon attributes (rev5) Patchwork
2022-12-16 10:43 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2022-12-14 3:09 [igt-dev] [PATCH i-g-t 0/3] i915/i915_hwmon: General verification of hwmon attributes Ashutosh Dixit
2022-12-14 3:09 ` [igt-dev] [PATCH i-g-t 1/3] lib/igt_sysfs: Generic verification of writable sysfs attributes Ashutosh Dixit
2022-12-14 6:51 ` Tauro, Riana
2022-12-14 16:37 ` Dixit, Ashutosh
2022-12-15 2:34 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0x01qcf.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=badal.nilawar@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=riana.tauro@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox