Re: [igt-dev] [PATCH i-g-t v5 55/65] tests/i915_pm_rps: Alter to use no-reloc

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Mon, 09 Aug 2021 06:05:23 -0700, Zbigniew Kempczyński wrote:
>
> diff --git a/tests/i915/i915_pm_rps.c b/tests/i915/i915_pm_rps.c
> index f51a47479..ada06aa94 100644
> --- a/tests/i915/i915_pm_rps.c
> +++ b/tests/i915/i915_pm_rps.c
> @@ -250,6 +250,10 @@ static void load_helper_run(enum load load)
>		igt_spin_t *spin[2] = {};
>		bool prev_load;
>		uint32_t handle;
> +		uint64_t ahnd;
> +
> +		intel_allocator_init();

OK, this extra step is needed because there is no igt_constructor
here. Also each child process is completely independent.

> @@ -542,11 +547,14 @@ static void boost_freq(int fd, int *boost_freqs)
>  {
>	int64_t timeout = 1;
>	igt_spin_t *load;
> +	/* We need to keep dependency spin offset for load->handle */
> +	uint64_t ahnd = get_simple_l2h_ahnd(fd, 0);
>
> -	load = igt_spin_new(fd);
> +	//get_offset(ahnd, 1000, 0x1000000, 0);

Please delete this line, with that:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>