From: Jani Nikula <jani.nikula@intel.com>
To: juhapekka.heikkila@gmail.com, Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 2/8] lib/params: start renaming functions igt_params_*
Date: Tue, 21 Apr 2020 11:07:29 +0300 [thread overview]
Message-ID: <87r1whz2gu.fsf@intel.com> (raw)
In-Reply-To: <5f97be54-85cf-d4e3-0534-45a132ed33f1@gmail.com>
On Tue, 21 Apr 2020, Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> wrote:
> On 20.4.2020 12.33, Petri Latvala wrote:
>> On Sun, Apr 19, 2020 at 06:17:44PM +0300, Juha-Pekka Heikkila wrote:
>>> From: Jani Nikula <jani.nikula@intel.com>
>>>
>>> based on patch from Jani Nikula.
>>
>>
>> From Jani, and then based on Jani.
>>
>> Please keep the original S-o-b as well as your own.
>>
>>
>
> Yea, that look like a mess now. I'm thinking I should take authorship on
> changed patches. I don't think I can keep Jani's S-o-b for changed
> patches. I'll anyway need to make changes yet so this it's not final
> revision, currently I have i915 hardcoded there for parameter path.
Like I've said way back when, it's fine with me for you to take
authorship when you change the patches. The starting point was a hacky
pile of patches that I threw over the fence, and I think it would be
silly for me to insist on retaining the authorship.
That said, Signed-off-by is a legal thing, and you *should* retain
that. See https://developercertificate.org/ for what it signifies.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-04-21 8:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-19 15:17 [igt-dev] [PATCH i-g-t 0/8] Use device dependant module parameters Juha-Pekka Heikkila
2020-04-19 15:17 ` [igt-dev] [PATCH i-g-t 1/8] lib/params: add igt_params.c for module parameter access Juha-Pekka Heikkila
2020-04-19 15:17 ` [igt-dev] [PATCH i-g-t 2/8] lib/params: start renaming functions igt_params_* Juha-Pekka Heikkila
2020-04-20 9:33 ` Petri Latvala
2020-04-21 7:38 ` Juha-Pekka Heikkila
2020-04-21 8:07 ` Jani Nikula [this message]
2020-04-19 15:17 ` [igt-dev] [PATCH i-g-t 3/8] lib/params: overhaul param saving Juha-Pekka Heikkila
2020-04-19 15:17 ` [igt-dev] [PATCH i-g-t 4/8] params open with path return Juha-Pekka Heikkila
2020-04-19 15:17 ` [igt-dev] [PATCH i-g-t 5/8] igt/params: add generic saving module parameter set Juha-Pekka Heikkila
2020-04-19 15:17 ` [igt-dev] [PATCH i-g-t 6/8] igt/params: use igt_params_set_save for igt_set_module_param* Juha-Pekka Heikkila
2020-04-19 15:17 ` [igt-dev] [PATCH i-g-t 7/8] BROKEN lib/debugfs: use regular module param functions for prefault_disable Juha-Pekka Heikkila
2020-04-19 15:17 ` [igt-dev] [PATCH i-g-t 8/8] tests/gem_eio: switch to using igt_params_set() Juha-Pekka Heikkila
2020-04-19 15:31 ` [igt-dev] ✗ GitLab.Pipeline: warning for Use device dependant module parameters Patchwork
2020-04-19 15:47 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-04-20 12:17 [igt-dev] [PATCH i-g-t 0/8] " Juha-Pekka Heikkila
2020-04-20 12:17 ` [igt-dev] [PATCH i-g-t 2/8] lib/params: start renaming functions igt_params_* Juha-Pekka Heikkila
2020-04-21 16:17 [igt-dev] [PATCH i-g-t 0/8] Use device dependant module parameters Juha-Pekka Heikkila
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 2/8] lib/params: start renaming functions igt_params_* Juha-Pekka Heikkila
2020-04-22 8:28 ` Petri Latvala
2020-04-22 8:34 ` Jani Nikula
2020-04-22 8:43 ` Petri Latvala
2020-04-22 8:48 ` Jani Nikula
2020-04-22 9:04 ` Arkadiusz Hiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1whz2gu.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox