From: Petri Latvala <petri.latvala@intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Cc: igt-dev@lists.freedesktop.org, Jani Nikula <jani.nikula@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 2/8] lib/params: start renaming functions igt_params_*
Date: Wed, 22 Apr 2020 11:28:18 +0300 [thread overview]
Message-ID: <20200422082818.GD9497@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20200421161725.12249-3-juhapekka.heikkila@gmail.com>
On Tue, Apr 21, 2020 at 07:17:19PM +0300, Juha-Pekka Heikkila wrote:
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> lib/drmtest.c | 2 +-
> lib/i915/gem_submission.c | 2 +-
> lib/igt_aux.c | 3 +--
> lib/igt_gt.c | 2 +-
> lib/igt_params.c | 12 +++++-------
> lib/igt_params.h | 5 ++---
> tests/i915/gem_ctx_exec.c | 2 +-
> tests/i915/gem_ctx_persistence.c | 9 ++++-----
> tests/i915/gem_mmap_gtt.c | 2 +-
> tests/i915/gem_reset_stats.c | 6 ++----
> tests/i915/sysfs_heartbeat_interval.c | 3 ++-
> tests/i915/sysfs_preempt_timeout.c | 3 ++-
> tests/i915/sysfs_timeslice_duration.c | 3 ++-
> 13 files changed, 25 insertions(+), 29 deletions(-)
>
> diff --git a/lib/drmtest.c b/lib/drmtest.c
> index 1fc39925..17067843 100644
> --- a/lib/drmtest.c
> +++ b/lib/drmtest.c
> @@ -393,7 +393,7 @@ static void __cancel_work_at_exit(int fd)
> {
> igt_terminate_spins(); /* for older kernels */
>
> - igt_sysfs_set_parameter(fd, "reset", "%x", -1u /* any method */);
> + igt_params_set(fd, "reset", "%x", -1u /* any method */);
Hmm. Now that we're renaming anyway, we have a good chance to consider
if the name is good.
igt_module_params_set()? No, the point of this series is to make the
params not module-specific. igt_device_params_set()?
I don't have a strong opinion on this and I can live with
igt_params_set() as well. Just calling out for opinions! Arek?
As for the patch, whatever the name, straight up renames all around.
Reviewed-by: Petri Latvala <petri.latvala@intel.com>
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-04-22 8:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 16:17 [igt-dev] [PATCH i-g-t 0/8] Use device dependant module parameters Juha-Pekka Heikkila
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 1/8] lib/params: add igt_params.c for module parameter access Juha-Pekka Heikkila
2020-04-22 8:02 ` Petri Latvala
2020-04-22 8:13 ` Juha-Pekka Heikkila
2020-04-22 8:19 ` Petri Latvala
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 2/8] lib/params: start renaming functions igt_params_* Juha-Pekka Heikkila
2020-04-22 8:28 ` Petri Latvala [this message]
2020-04-22 8:34 ` Jani Nikula
2020-04-22 8:43 ` Petri Latvala
2020-04-22 8:48 ` Jani Nikula
2020-04-22 9:04 ` Arkadiusz Hiler
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 3/8] lib/params: overhaul param saving Juha-Pekka Heikkila
2020-04-28 12:26 ` Petri Latvala
2020-04-28 18:40 ` Juha-Pekka Heikkila
2020-04-28 19:29 ` Juha-Pekka Heikkila
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 4/8] params open with path return Juha-Pekka Heikkila
2020-04-28 12:31 ` Petri Latvala
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 5/8] igt/params: add generic saving module parameter set Juha-Pekka Heikkila
2020-04-28 12:40 ` Petri Latvala
2020-04-28 18:43 ` Juha-Pekka Heikkila
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 6/8] igt/params: use igt_params_set_save for igt_set_module_param* Juha-Pekka Heikkila
2020-04-28 12:54 ` Petri Latvala
2020-04-28 19:04 ` Juha-Pekka Heikkila
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 7/8] lib/debugfs: use regular module param functions for prefault_disable Juha-Pekka Heikkila
2020-04-21 18:10 ` Chris Wilson
2020-04-21 18:30 ` Juha-Pekka Heikkila
2020-04-21 18:36 ` Chris Wilson
2020-04-21 18:59 ` Juha-Pekka Heikkila
2020-04-22 6:13 ` Jani Nikula
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 8/8] tests/gem_eio: switch to using igt_params_set() Juha-Pekka Heikkila
2020-04-21 17:02 ` [igt-dev] ✗ Fi.CI.BAT: failure for Use device dependant module parameters (rev3) Patchwork
2020-04-21 18:08 ` [igt-dev] ✓ Fi.CI.BAT: success for Use device dependant module parameters (rev4) Patchwork
2020-04-22 1:05 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-04-20 12:17 [igt-dev] [PATCH i-g-t 0/8] Use device dependant module parameters Juha-Pekka Heikkila
2020-04-20 12:17 ` [igt-dev] [PATCH i-g-t 2/8] lib/params: start renaming functions igt_params_* Juha-Pekka Heikkila
2020-04-19 15:17 [igt-dev] [PATCH i-g-t 0/8] Use device dependant module parameters Juha-Pekka Heikkila
2020-04-19 15:17 ` [igt-dev] [PATCH i-g-t 2/8] lib/params: start renaming functions igt_params_* Juha-Pekka Heikkila
2020-04-20 9:33 ` Petri Latvala
2020-04-21 7:38 ` Juha-Pekka Heikkila
2020-04-21 8:07 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422082818.GD9497@platvala-desk.ger.corp.intel.com \
--to=petri.latvala@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox