From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Jani Nikula <jani.nikula@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 7/8] lib/debugfs: use regular module param functions for prefault_disable
Date: Tue, 21 Apr 2020 21:59:46 +0300 [thread overview]
Message-ID: <cc21fa6e-582a-69af-def1-572a3def50e6@gmail.com> (raw)
In-Reply-To: <158749418519.11203.15109734100555990375@build.alporthouse.com>
On 21.4.2020 21.36, Chris Wilson wrote:
> Quoting Juha-Pekka Heikkila (2020-04-21 19:30:00)
>> On 21.4.2020 21.10, Chris Wilson wrote:
>>> Quoting Juha-Pekka Heikkila (2020-04-21 17:17:24)
>>>> From: Jani Nikula <jani.nikula@intel.com>
>>>>
>>>> Functional change switches from igt_require to igt_assert on errors.
>>>
>>> Adding entirely unused functions for fun?
>>
>> That probably is from legacy, Jani's igt branch that I took was not very
>> new.
>>
>> Chris, you have opinion about patch 6/8 on what's going on there?
>> There's in __igt_params_open(..) those two blocks of file checking which
>> on first block is checking if wanted parameter file is in selected
>> device directory and second block is just about 'guessing' default
>> device name. I'm somehow thinking there would be easier way for those
>> but I didn't find other way so I ended up reading and parsing files. It
>> seems to work but not feeling comfortable with it.
>
> Heh, not guilty of igt_set_module_param(). I would rip out any implicit
> device lookup and make sure there's always a device fd to work with. If
> that is not possible, then make the module name a parameter.
I'll need to give it some thought with making module name as parameter.
There's not many tests that would require change but those tests will
need to be added with some code that will recognize what driver are they on.
/Juha-Pekka
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-04-21 18:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 16:17 [igt-dev] [PATCH i-g-t 0/8] Use device dependant module parameters Juha-Pekka Heikkila
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 1/8] lib/params: add igt_params.c for module parameter access Juha-Pekka Heikkila
2020-04-22 8:02 ` Petri Latvala
2020-04-22 8:13 ` Juha-Pekka Heikkila
2020-04-22 8:19 ` Petri Latvala
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 2/8] lib/params: start renaming functions igt_params_* Juha-Pekka Heikkila
2020-04-22 8:28 ` Petri Latvala
2020-04-22 8:34 ` Jani Nikula
2020-04-22 8:43 ` Petri Latvala
2020-04-22 8:48 ` Jani Nikula
2020-04-22 9:04 ` Arkadiusz Hiler
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 3/8] lib/params: overhaul param saving Juha-Pekka Heikkila
2020-04-28 12:26 ` Petri Latvala
2020-04-28 18:40 ` Juha-Pekka Heikkila
2020-04-28 19:29 ` Juha-Pekka Heikkila
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 4/8] params open with path return Juha-Pekka Heikkila
2020-04-28 12:31 ` Petri Latvala
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 5/8] igt/params: add generic saving module parameter set Juha-Pekka Heikkila
2020-04-28 12:40 ` Petri Latvala
2020-04-28 18:43 ` Juha-Pekka Heikkila
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 6/8] igt/params: use igt_params_set_save for igt_set_module_param* Juha-Pekka Heikkila
2020-04-28 12:54 ` Petri Latvala
2020-04-28 19:04 ` Juha-Pekka Heikkila
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 7/8] lib/debugfs: use regular module param functions for prefault_disable Juha-Pekka Heikkila
2020-04-21 18:10 ` Chris Wilson
2020-04-21 18:30 ` Juha-Pekka Heikkila
2020-04-21 18:36 ` Chris Wilson
2020-04-21 18:59 ` Juha-Pekka Heikkila [this message]
2020-04-22 6:13 ` Jani Nikula
2020-04-21 16:17 ` [igt-dev] [PATCH i-g-t 8/8] tests/gem_eio: switch to using igt_params_set() Juha-Pekka Heikkila
2020-04-21 17:02 ` [igt-dev] ✗ Fi.CI.BAT: failure for Use device dependant module parameters (rev3) Patchwork
2020-04-21 18:08 ` [igt-dev] ✓ Fi.CI.BAT: success for Use device dependant module parameters (rev4) Patchwork
2020-04-22 1:05 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-04-20 12:17 [igt-dev] [PATCH i-g-t 0/8] Use device dependant module parameters Juha-Pekka Heikkila
2020-04-20 12:17 ` [igt-dev] [PATCH i-g-t 7/8] lib/debugfs: use regular module param functions for prefault_disable Juha-Pekka Heikkila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc21fa6e-582a-69af-def1-572a3def50e6@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox