From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/perf: add a test for OA data polling reads using "small" buffers
Date: Fri, 27 Mar 2020 12:03:42 -0700 [thread overview]
Message-ID: <87v9mpsjqp.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <91876d66-5ba8-0351-583e-8baf1ff4a1e1@intel.com>
On Fri, 27 Mar 2020 09:09:41 -0700, Lionel Landwerlin wrote:
>
> On 27/03/2020 06:50, Dixit, Ashutosh wrote:
> > On Thu, 26 Mar 2020 21:42:50 -0700, Ashutosh Dixit wrote:
> >> diff --git a/tests/perf.c b/tests/perf.c
> >> index 724f6f809..3dc757c3b 100644
> >> --- a/tests/perf.c
> >> +++ b/tests/perf.c
> >> +static void test_polling_small_buf(void)
> >> +{
> > /snip/
> >
> >> +
> >> + igt_assert(abs(n_expect_read_bytes - n_bytes_read) < (0.10 * n_expect_read_bytes));
> >> +}
> >> +
> > I'd be wary of a 90% match on slow platforms like Atom? Maybe 80% is safer?
>
>
> Do we have any experiment showing them behaving differently?
No I don't have any data, but considering that in previous stable versions
we can only read < 10% of the data, I think it should be ok to go down to
80%? So that we don't start getting unnecessary false alarms in CI, even
when the issue is fixed.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-03-27 19:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 4:42 [igt-dev] [PATCH i-g-t] tests/perf: add a test for OA data polling reads using "small" buffers Ashutosh Dixit
2020-03-27 4:50 ` Dixit, Ashutosh
2020-03-27 16:09 ` Lionel Landwerlin
2020-03-27 19:03 ` Dixit, Ashutosh [this message]
2020-03-27 19:06 ` Lionel Landwerlin
2020-03-27 19:49 ` Dixit, Ashutosh
2020-03-31 6:06 ` Dixit, Ashutosh
2020-03-31 7:36 ` Lionel Landwerlin
2020-03-31 7:48 ` Dixit, Ashutosh
2020-04-03 1:19 ` Dixit, Ashutosh
2020-03-27 5:23 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/perf: add a test for OA data polling reads using "small" buffers (rev2) Patchwork
2020-03-27 15:19 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-03-27 20:56 ` [igt-dev] [PATCH i-g-t] tests/perf: add a test for OA data polling reads using "small" buffers Umesh Nerlige Ramappa
2020-03-27 22:02 ` Dixit, Ashutosh
-- strict thread matches above, loose matches on Subject: below --
2020-03-27 22:29 Ashutosh Dixit
2020-03-26 5:42 Ashutosh Dixit
2020-03-26 9:02 ` Lionel Landwerlin
2020-03-27 4:08 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v9mpsjqp.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=lionel.g.landwerlin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox