From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] tests/perf: add a test for OA data polling reads using "small" buffers
Date: Thu, 26 Mar 2020 21:08:41 -0700 [thread overview]
Message-ID: <87y2rmsaly.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <ceae76dd-d0e4-3c30-8541-04c54648dc79@intel.com>
On Thu, 26 Mar 2020 02:02:40 -0700, Lionel Landwerlin wrote:
>
> On 26/03/2020 07:42, Ashutosh Dixit wrote:
> > Add a test for OA data non-blocking reads using buffers smaller than
> > the available data. This test would fail for perf revisions < 5
> > because poll would block even when data was available. Therefore the
> > amount of data read was limited by the buffer size and the timer
> > interval and it was impossible to read all available data. This issue
> > is fixed in perf revision 5.
>
>
> There seems to be a fundamental issue with this test, it's supposed to
> test a broken behavior with revision < 5 but then avoid testing anything
> there ;)
It was guaranteed to fail, but I see your point, you are saying let if fail
for rev < 5 but then submit the kernel patch as a fix.
> I've modified this test a bit here :
> https://gitlab.freedesktop.org/llandwerlin/igt-gpu-tools/-/tree/for-ashutosh
>
> It's failing stable kernels.
>
> Increasing the size of the buffer to 1Mb make the test pass.
I like it, I didn't know you could estimate the amount of OA data. I will
clean it up, test and post it as v2.
Thanks!
--
Ashutosh
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2020-03-27 4:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-26 5:42 [igt-dev] [PATCH i-g-t] tests/perf: add a test for OA data polling reads using "small" buffers Ashutosh Dixit
2020-03-26 5:52 ` [igt-dev] ✗ Fi.CI.BUILD: failure for " Patchwork
2020-03-26 6:01 ` [igt-dev] ✗ GitLab.Pipeline: warning " Patchwork
2020-03-26 9:02 ` [igt-dev] [PATCH i-g-t] " Lionel Landwerlin
2020-03-27 4:08 ` Dixit, Ashutosh [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-03-27 4:42 Ashutosh Dixit
2020-03-27 4:50 ` Dixit, Ashutosh
2020-03-27 16:09 ` Lionel Landwerlin
2020-03-27 19:03 ` Dixit, Ashutosh
2020-03-27 19:06 ` Lionel Landwerlin
2020-03-27 19:49 ` Dixit, Ashutosh
2020-03-31 6:06 ` Dixit, Ashutosh
2020-03-31 7:36 ` Lionel Landwerlin
2020-03-31 7:48 ` Dixit, Ashutosh
2020-04-03 1:19 ` Dixit, Ashutosh
2020-03-27 20:56 ` Umesh Nerlige Ramappa
2020-03-27 22:02 ` Dixit, Ashutosh
2020-03-27 22:29 Ashutosh Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2rmsaly.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=lionel.g.landwerlin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox