Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH igt] tools: Clear unused fields in register spec
@ 2018-02-02 10:10 Chris Wilson
  2018-02-02 10:29 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: Chris Wilson @ 2018-02-02 10:10 UTC (permalink / raw)
  To: igt-dev; +Cc: Mika Kuoppala, Joonas Lahtinen

If we fail to clear the other fields inside the register spec, that may
be left with garbage instructing us to access the register via an
invalid path.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104895
Fixes: 7f0be0e7d9be ("tools/intel_reg: Add reading and writing registers through engine")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Jani Nikula <jani.nikula@intel.com>
CC: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Mika Kuoppala <mika.kuoppala@linux.intel.com>
---
 tools/intel_reg_spec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/intel_reg_spec.c b/tools/intel_reg_spec.c
index 5594d7077..58c8f7e4c 100644
--- a/tools/intel_reg_spec.c
+++ b/tools/intel_reg_spec.c
@@ -267,7 +267,7 @@ static ssize_t parse_file(struct reg **regs, size_t *nregs,
 	}
 
 	while (getline(&line, &linesize, file) != -1) {
-		struct reg reg;
+		struct reg reg = {};
 
 		lineno++;
 
-- 
2.15.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-02-02 15:48 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-02 10:10 [igt-dev] [PATCH igt] tools: Clear unused fields in register spec Chris Wilson
2018-02-02 10:29 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-02-02 11:16 ` [igt-dev] [PATCH igt] " Jani Nikula
2018-02-02 11:22 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2018-02-02 13:06 ` [igt-dev] [PATCH igt] " Mika Kuoppala
2018-02-02 13:15 ` [igt-dev] [PATCH igt v2] " Chris Wilson
2018-02-02 13:21   ` Mika Kuoppala
2018-02-02 13:57 ` [igt-dev] ✓ Fi.CI.BAT: success for tools: Clear unused fields in register spec (rev2) Patchwork
2018-02-02 15:48 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox