From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Vidya Srinivas <vidya.srinivas@intel.com>
Cc: kunal1.joshi@intel.com, petri.latvala@intel.com,
igt-dev@lists.freedesktop.org, juha-pekka.heikkila@intel.com,
Lin Charlton <charlton.lin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms: Return false in gem_has_lmem for kernels not having DRM_I915_QUERY_MEMORY_REGIONS support
Date: Sat, 24 Jul 2021 14:20:19 -0700 [thread overview]
Message-ID: <87wnpfo1d8.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20210724165317.32000-1-vidya.srinivas@intel.com>
On Sat, 24 Jul 2021 09:53:17 -0700, Vidya Srinivas wrote:
>
> @@ -164,6 +175,9 @@ uint8_t gem_get_lmem_region_count(int fd)
> */
> bool gem_has_lmem(int fd)
> {
> + int ret = gem_has_memregion_query_support(fd);
> + if (ret == ENOSYS || ret == ENOTSUP)
> + return false;
> return gem_get_lmem_region_count(fd) > 0;
gem_get_query_memory_regions is still broken. So we should use
__i915_query_items there.
The patch title also should not say tests/kms.
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-07-24 21:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 9:35 [igt-dev] [PATCH i-g-t] tests/kms: Return false in gem_has_lmem for platforms not having LMEM support Vidya Srinivas
2021-07-23 12:12 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-07-23 17:16 ` [igt-dev] [PATCH i-g-t] " Dixit, Ashutosh
2021-07-24 16:07 ` Srinivas, Vidya
2021-07-24 17:00 ` Srinivas, Vidya
2021-07-24 17:43 ` Srinivas, Vidya
2021-07-23 18:19 ` [igt-dev] ✗ Fi.CI.IGT: failure for " Patchwork
2021-07-24 16:46 ` [igt-dev] [PATCH] tests/kms: Return false in gem_has_lmem for kernels not having DRM_I915_QUERY_MEMORY_REGIONS support Vidya Srinivas
2021-07-24 16:53 ` [igt-dev] [PATCH i-g-t] " Vidya Srinivas
2021-07-24 21:20 ` Dixit, Ashutosh [this message]
2021-07-26 6:18 ` Srinivas, Vidya
2021-07-26 6:06 ` [igt-dev] [PATCH i-g-t] lib/i915: " Vidya Srinivas
2021-07-26 6:52 ` Modem, Bhanuprakash
2021-07-24 17:32 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms: Return false in gem_has_lmem for platforms not having LMEM support (rev2) Patchwork
2021-07-24 18:03 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms: Return false in gem_has_lmem for platforms not having LMEM support (rev3) Patchwork
2021-07-24 18:40 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms: Return false in gem_has_lmem for platforms not having LMEM support (rev2) Patchwork
2021-07-24 19:34 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms: Return false in gem_has_lmem for platforms not having LMEM support (rev3) Patchwork
2021-07-26 6:52 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms: Return false in gem_has_lmem for platforms not having LMEM support (rev4) Patchwork
2021-07-26 8:27 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnpfo1d8.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=charlton.lin@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juha-pekka.heikkila@intel.com \
--cc=kunal1.joshi@intel.com \
--cc=petri.latvala@intel.com \
--cc=vidya.srinivas@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox