* [PATCH v1 0/1] Fix assert vs error in lib/intel_wa
@ 2026-05-13 4:36 Shekhar Chauhan
2026-05-13 4:36 ` [PATCH v1 1/1] lib/intel_wa: Assert on error instead of returning -1 Shekhar Chauhan
` (4 more replies)
0 siblings, 5 replies; 8+ messages in thread
From: Shekhar Chauhan @ 2026-05-13 4:36 UTC (permalink / raw)
To: igt-dev; +Cc: shekhar.chauhan, ashutosh.dixit
igt_has_intel_wa() currently returns -1 on error, 0 if the workaround
is not present, and 1 if it is. There is no point in distinguishing
between the error and no-workaround cases for callers. If the debugfs
directory cannot be opened, that is an unexpected test environment
failure and should be caught immediately with an assert.
Simplify debugfs_file_has_wa() by removing the igt_debugfs_exists()
check — igt_sysfs_get() returns NULL for missing files, so the helper
naturally returns 0 without it. Guard the device-level workarounds
check in igt_has_intel_wa() with igt_debugfs_exists() since that file
may not exist on kernels without device OOB workaround support.
v1: Initial set of changes.
Shekhar Chauhan (1):
lib/intel_wa: Assert on error instead of returning -1
lib/intel_wa.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
--
2.53.0
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v1 1/1] lib/intel_wa: Assert on error instead of returning -1
2026-05-13 4:36 [PATCH v1 0/1] Fix assert vs error in lib/intel_wa Shekhar Chauhan
@ 2026-05-13 4:36 ` Shekhar Chauhan
2026-05-13 6:41 ` Dixit, Ashutosh
2026-05-13 5:50 ` ✗ i915.CI.BAT: failure for Fix assert vs error in lib/intel_wa Patchwork
` (3 subsequent siblings)
4 siblings, 1 reply; 8+ messages in thread
From: Shekhar Chauhan @ 2026-05-13 4:36 UTC (permalink / raw)
To: igt-dev; +Cc: shekhar.chauhan, ashutosh.dixit
igt_has_intel_wa() returns 0, 1, or -1, but there is no point
distinguishing the error and no-workaround cases for callers. Replace
the error return with igt_assert() and simplify debugfs_file_has_wa() by
dropping the igt_debugfs_exists() check, since igt_sysfs_get() returns
NULL for missing files anyway.
Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
---
lib/intel_wa.c | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/lib/intel_wa.c b/lib/intel_wa.c
index 727dd6c98..5d50dcc28 100644
--- a/lib/intel_wa.c
+++ b/lib/intel_wa.c
@@ -7,6 +7,7 @@
#include <stdint.h>
#include <stdio.h>
+#include "igt_core.h"
#include "igt_debugfs.h"
#include "igt_sysfs.h"
#include "intel_wa.h"
@@ -17,9 +18,6 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
{
char *debugfs_dump;
- if (!igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY))
- return -1;
-
debugfs_dump = igt_sysfs_get(debugfs_fd, debugfs_name);
if (debugfs_dump) {
char *has_wa = strstr(debugfs_dump, wa);
@@ -38,7 +36,7 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
* @drm_fd: A drm file descriptor
* @check_wa: Workaround to be checked
*
- * Returns: 0 if no WA, 1 if WA present, -1 on error
+ * Returns: 1 if WA present, 0 otherwise
*/
int igt_has_intel_wa(int drm_fd, const char *check_wa)
{
@@ -48,8 +46,7 @@ int igt_has_intel_wa(int drm_fd, const char *check_wa)
char name[256];
debugfs_fd = igt_debugfs_dir(drm_fd);
- if (debugfs_fd == -1)
- return -1;
+ igt_assert(debugfs_fd >= 0);
xe_for_each_gt(drm_fd, xe) {
sprintf(name, "gt%d/workarounds", xe);
@@ -58,7 +55,7 @@ int igt_has_intel_wa(int drm_fd, const char *check_wa)
break;
}
- if (!ret)
+ if (!ret && igt_debugfs_exists(drm_fd, "workarounds", O_RDONLY))
ret = debugfs_file_has_wa(drm_fd, debugfs_fd, "workarounds", check_wa);
close(debugfs_fd);
--
2.53.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* ✗ i915.CI.BAT: failure for Fix assert vs error in lib/intel_wa
2026-05-13 4:36 [PATCH v1 0/1] Fix assert vs error in lib/intel_wa Shekhar Chauhan
2026-05-13 4:36 ` [PATCH v1 1/1] lib/intel_wa: Assert on error instead of returning -1 Shekhar Chauhan
@ 2026-05-13 5:50 ` Patchwork
2026-05-13 5:50 ` Patchwork
` (2 subsequent siblings)
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2026-05-13 5:50 UTC (permalink / raw)
To: Shekhar Chauhan; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 4821 bytes --]
== Series Details ==
Series: Fix assert vs error in lib/intel_wa
URL : https://patchwork.freedesktop.org/series/166464/
State : failure
== Summary ==
CI Bug Log - changes from IGT_8908 -> IGTPW_15171
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_15171 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_15171, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/index.html
Participating hosts (42 -> 40)
------------------------------
Missing (2): bat-dg2-13 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_15171:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hangcheck:
- bat-atsm-1: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/bat-atsm-1/igt@i915_selftest@live@hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-atsm-1/igt@i915_selftest@live@hangcheck.html
Known issues
------------
Here are the changes found in IGTPW_15171 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@dmabuf@all-tests:
- bat-rpls-4: NOTRUN -> [SKIP][3] ([i915#15931])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-rpls-4/igt@dmabuf@all-tests.html
- fi-skl-6600u: NOTRUN -> [SKIP][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/fi-skl-6600u/igt@dmabuf@all-tests.html
* igt@gem_lmem_swapping@random-engines:
- fi-skl-6600u: NOTRUN -> [SKIP][5] ([i915#4613]) +3 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/fi-skl-6600u/igt@gem_lmem_swapping@random-engines.html
* igt@i915_selftest@live:
- bat-mtlp-8: [PASS][6] -> [DMESG-FAIL][7] ([i915#12061]) +1 other test dmesg-fail
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/bat-mtlp-8/igt@i915_selftest@live.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-mtlp-8/igt@i915_selftest@live.html
* igt@i915_selftest@live@workarounds:
- bat-arls-6: [PASS][8] -> [DMESG-FAIL][9] ([i915#12061]) +1 other test dmesg-fail
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/bat-arls-6/igt@i915_selftest@live@workarounds.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-arls-6/igt@i915_selftest@live@workarounds.html
#### Possible fixes ####
* igt@i915_selftest@live:
- bat-dg2-8: [DMESG-FAIL][10] ([i915#12061]) -> [PASS][11] +1 other test pass
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/bat-dg2-8/igt@i915_selftest@live.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-dg2-8/igt@i915_selftest@live.html
- bat-rpls-4: [INCOMPLETE][12] ([i915#15957]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/bat-rpls-4/igt@i915_selftest@live.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-rpls-4/igt@i915_selftest@live.html
* igt@i915_selftest@live@gem_contexts:
- bat-rpls-4: [INCOMPLETE][14] -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/bat-rpls-4/igt@i915_selftest@live@gem_contexts.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-rpls-4/igt@i915_selftest@live@gem_contexts.html
* igt@prime_vgem@basic-fence-flip:
- fi-skl-6600u: [INCOMPLETE][16] -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/fi-skl-6600u/igt@prime_vgem@basic-fence-flip.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/fi-skl-6600u/igt@prime_vgem@basic-fence-flip.html
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#15931]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15931
[i915#15957]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15957
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_8908 -> IGTPW_15171
CI-20190529: 20190529
CI_DRM_18479: 8fbb3d48e61c7e68cefdba85c3fa3ba59e7a93b4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_15171: 3c31b3543ad48e730ad9834218574314fec69947 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8908: d920ab298100bf1ee545ed419e4d9c3eb0499ba0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/index.html
[-- Attachment #2: Type: text/html, Size: 5789 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✗ i915.CI.BAT: failure for Fix assert vs error in lib/intel_wa
2026-05-13 4:36 [PATCH v1 0/1] Fix assert vs error in lib/intel_wa Shekhar Chauhan
2026-05-13 4:36 ` [PATCH v1 1/1] lib/intel_wa: Assert on error instead of returning -1 Shekhar Chauhan
2026-05-13 5:50 ` ✗ i915.CI.BAT: failure for Fix assert vs error in lib/intel_wa Patchwork
@ 2026-05-13 5:50 ` Patchwork
2026-05-13 6:00 ` ✓ Xe.CI.BAT: success " Patchwork
2026-05-14 2:24 ` ✗ Xe.CI.FULL: failure " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2026-05-13 5:50 UTC (permalink / raw)
To: Shekhar Chauhan; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 4821 bytes --]
== Series Details ==
Series: Fix assert vs error in lib/intel_wa
URL : https://patchwork.freedesktop.org/series/166464/
State : failure
== Summary ==
CI Bug Log - changes from IGT_8908 -> IGTPW_15171
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_15171 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_15171, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/index.html
Participating hosts (42 -> 40)
------------------------------
Missing (2): bat-dg2-13 fi-snb-2520m
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_15171:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@hangcheck:
- bat-atsm-1: [PASS][1] -> [DMESG-WARN][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/bat-atsm-1/igt@i915_selftest@live@hangcheck.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-atsm-1/igt@i915_selftest@live@hangcheck.html
Known issues
------------
Here are the changes found in IGTPW_15171 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@dmabuf@all-tests:
- bat-rpls-4: NOTRUN -> [SKIP][3] ([i915#15931])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-rpls-4/igt@dmabuf@all-tests.html
- fi-skl-6600u: NOTRUN -> [SKIP][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/fi-skl-6600u/igt@dmabuf@all-tests.html
* igt@gem_lmem_swapping@random-engines:
- fi-skl-6600u: NOTRUN -> [SKIP][5] ([i915#4613]) +3 other tests skip
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/fi-skl-6600u/igt@gem_lmem_swapping@random-engines.html
* igt@i915_selftest@live:
- bat-mtlp-8: [PASS][6] -> [DMESG-FAIL][7] ([i915#12061]) +1 other test dmesg-fail
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/bat-mtlp-8/igt@i915_selftest@live.html
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-mtlp-8/igt@i915_selftest@live.html
* igt@i915_selftest@live@workarounds:
- bat-arls-6: [PASS][8] -> [DMESG-FAIL][9] ([i915#12061]) +1 other test dmesg-fail
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/bat-arls-6/igt@i915_selftest@live@workarounds.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-arls-6/igt@i915_selftest@live@workarounds.html
#### Possible fixes ####
* igt@i915_selftest@live:
- bat-dg2-8: [DMESG-FAIL][10] ([i915#12061]) -> [PASS][11] +1 other test pass
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/bat-dg2-8/igt@i915_selftest@live.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-dg2-8/igt@i915_selftest@live.html
- bat-rpls-4: [INCOMPLETE][12] ([i915#15957]) -> [PASS][13]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/bat-rpls-4/igt@i915_selftest@live.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-rpls-4/igt@i915_selftest@live.html
* igt@i915_selftest@live@gem_contexts:
- bat-rpls-4: [INCOMPLETE][14] -> [PASS][15]
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/bat-rpls-4/igt@i915_selftest@live@gem_contexts.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/bat-rpls-4/igt@i915_selftest@live@gem_contexts.html
* igt@prime_vgem@basic-fence-flip:
- fi-skl-6600u: [INCOMPLETE][16] -> [PASS][17]
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_8908/fi-skl-6600u/igt@prime_vgem@basic-fence-flip.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/fi-skl-6600u/igt@prime_vgem@basic-fence-flip.html
[i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
[i915#15931]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15931
[i915#15957]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/15957
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_8908 -> IGTPW_15171
CI-20190529: 20190529
CI_DRM_18479: 8fbb3d48e61c7e68cefdba85c3fa3ba59e7a93b4 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_15171: 3c31b3543ad48e730ad9834218574314fec69947 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8908: d920ab298100bf1ee545ed419e4d9c3eb0499ba0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_15171/index.html
[-- Attachment #2: Type: text/html, Size: 5789 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Xe.CI.BAT: success for Fix assert vs error in lib/intel_wa
2026-05-13 4:36 [PATCH v1 0/1] Fix assert vs error in lib/intel_wa Shekhar Chauhan
` (2 preceding siblings ...)
2026-05-13 5:50 ` Patchwork
@ 2026-05-13 6:00 ` Patchwork
2026-05-14 2:24 ` ✗ Xe.CI.FULL: failure " Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2026-05-13 6:00 UTC (permalink / raw)
To: Shekhar Chauhan; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 946 bytes --]
== Series Details ==
Series: Fix assert vs error in lib/intel_wa
URL : https://patchwork.freedesktop.org/series/166464/
State : success
== Summary ==
CI Bug Log - changes from XEIGT_8908_BAT -> XEIGTPW_15171_BAT
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (13 -> 13)
------------------------------
No changes in participating hosts
Changes
-------
No changes found
Build changes
-------------
* IGT: IGT_8908 -> IGTPW_15171
IGTPW_15171: 3c31b3543ad48e730ad9834218574314fec69947 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8908: d920ab298100bf1ee545ed419e4d9c3eb0499ba0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-5053-8fbb3d48e61c7e68cefdba85c3fa3ba59e7a93b4: 8fbb3d48e61c7e68cefdba85c3fa3ba59e7a93b4
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/index.html
[-- Attachment #2: Type: text/html, Size: 1491 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/1] lib/intel_wa: Assert on error instead of returning -1
2026-05-13 4:36 ` [PATCH v1 1/1] lib/intel_wa: Assert on error instead of returning -1 Shekhar Chauhan
@ 2026-05-13 6:41 ` Dixit, Ashutosh
2026-05-13 21:30 ` Dixit, Ashutosh
0 siblings, 1 reply; 8+ messages in thread
From: Dixit, Ashutosh @ 2026-05-13 6:41 UTC (permalink / raw)
To: Shekhar Chauhan; +Cc: igt-dev
On Tue, 12 May 2026 21:36:27 -0700, Shekhar Chauhan wrote:
>
> igt_has_intel_wa() returns 0, 1, or -1, but there is no point
> distinguishing the error and no-workaround cases for callers. Replace
> the error return with igt_assert() and simplify debugfs_file_has_wa() by
> dropping the igt_debugfs_exists() check, since igt_sysfs_get() returns
> NULL for missing files anyway.
>
> Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
> ---
> lib/intel_wa.c | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/lib/intel_wa.c b/lib/intel_wa.c
> index 727dd6c98..5d50dcc28 100644
> --- a/lib/intel_wa.c
> +++ b/lib/intel_wa.c
> @@ -7,6 +7,7 @@
> #include <stdint.h>
> #include <stdio.h>
>
> +#include "igt_core.h"
> #include "igt_debugfs.h"
> #include "igt_sysfs.h"
> #include "intel_wa.h"
> @@ -17,9 +18,6 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> {
> char *debugfs_dump;
>
> - if (!igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY))
> - return -1;
> -
> debugfs_dump = igt_sysfs_get(debugfs_fd, debugfs_name);
> if (debugfs_dump) {
> char *has_wa = strstr(debugfs_dump, wa);
> @@ -38,7 +36,7 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> * @drm_fd: A drm file descriptor
> * @check_wa: Workaround to be checked
> *
> - * Returns: 0 if no WA, 1 if WA present, -1 on error
> + * Returns: 1 if WA present, 0 otherwise
> */
> int igt_has_intel_wa(int drm_fd, const char *check_wa)
I'll take a look tomorrow, but one thing I would like to change in these
functions is:
* If we want to return 1 if WA present, change return type to bool and
return true/false, instead of 1/0
* If we want to retain the int return type, return 0 if WA present and
something else (maybe 1 is ok) if WA is not present
Because either of these is a more standard convention to follow. So these
are in addition to changes here, which I will review tomorrow. Thanks.
> {
> @@ -48,8 +46,7 @@ int igt_has_intel_wa(int drm_fd, const char *check_wa)
> char name[256];
>
> debugfs_fd = igt_debugfs_dir(drm_fd);
> - if (debugfs_fd == -1)
> - return -1;
> + igt_assert(debugfs_fd >= 0);
>
> xe_for_each_gt(drm_fd, xe) {
> sprintf(name, "gt%d/workarounds", xe);
> @@ -58,7 +55,7 @@ int igt_has_intel_wa(int drm_fd, const char *check_wa)
> break;
> }
>
> - if (!ret)
> + if (!ret && igt_debugfs_exists(drm_fd, "workarounds", O_RDONLY))
> ret = debugfs_file_has_wa(drm_fd, debugfs_fd, "workarounds", check_wa);
>
> close(debugfs_fd);
> --
> 2.53.0
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v1 1/1] lib/intel_wa: Assert on error instead of returning -1
2026-05-13 6:41 ` Dixit, Ashutosh
@ 2026-05-13 21:30 ` Dixit, Ashutosh
0 siblings, 0 replies; 8+ messages in thread
From: Dixit, Ashutosh @ 2026-05-13 21:30 UTC (permalink / raw)
To: Shekhar Chauhan; +Cc: igt-dev
On Tue, 12 May 2026 23:41:26 -0700, Dixit, Ashutosh wrote:
>
> On Tue, 12 May 2026 21:36:27 -0700, Shekhar Chauhan wrote:
> >
> > igt_has_intel_wa() returns 0, 1, or -1, but there is no point
> > distinguishing the error and no-workaround cases for callers. Replace
> > the error return with igt_assert() and simplify debugfs_file_has_wa() by
> > dropping the igt_debugfs_exists() check, since igt_sysfs_get() returns
> > NULL for missing files anyway.
> >
> > Signed-off-by: Shekhar Chauhan <shekhar.chauhan@intel.com>
> > ---
> > lib/intel_wa.c | 11 ++++-------
> > 1 file changed, 4 insertions(+), 7 deletions(-)
> >
> > diff --git a/lib/intel_wa.c b/lib/intel_wa.c
> > index 727dd6c98..5d50dcc28 100644
> > --- a/lib/intel_wa.c
> > +++ b/lib/intel_wa.c
> > @@ -7,6 +7,7 @@
> > #include <stdint.h>
> > #include <stdio.h>
> >
> > +#include "igt_core.h"
> > #include "igt_debugfs.h"
> > #include "igt_sysfs.h"
> > #include "intel_wa.h"
> > @@ -17,9 +18,6 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > {
> > char *debugfs_dump;
> >
> > - if (!igt_debugfs_exists(drm_fd, debugfs_name, O_RDONLY))
> > - return -1;
> > -
This should also be an assert, since kernel is expected to create the
device level workarounds directory. So add assert here and remove the
condition added below.
Also for a single patch a cover letter is generally not needed.
Further, from what I am seeing, debugfs is always mounted when running
IGT's, so it is ok to change these to assert's. But maybe double check that
too. That is probably the reason the assert was not added here
originally. But from what I am seeing, assert's should be ok here.
> > debugfs_dump = igt_sysfs_get(debugfs_fd, debugfs_name);
> > if (debugfs_dump) {
> > char *has_wa = strstr(debugfs_dump, wa);
> > @@ -38,7 +36,7 @@ static int debugfs_file_has_wa(int drm_fd, int debugfs_fd,
> > * @drm_fd: A drm file descriptor
> > * @check_wa: Workaround to be checked
> > *
> > - * Returns: 0 if no WA, 1 if WA present, -1 on error
> > + * Returns: 1 if WA present, 0 otherwise
> > */
> > int igt_has_intel_wa(int drm_fd, const char *check_wa)
>
> I'll take a look tomorrow, but one thing I would like to change in these
> functions is:
>
> * If we want to return 1 if WA present, change return type to bool and
> return true/false, instead of 1/0
>
> * If we want to retain the int return type, return 0 if WA present and
> something else (maybe 1 is ok) if WA is not present
>
> Because either of these is a more standard convention to follow. So these
> are in addition to changes here, which I will review tomorrow. Thanks.
>
> > {
> > @@ -48,8 +46,7 @@ int igt_has_intel_wa(int drm_fd, const char *check_wa)
> > char name[256];
> >
> > debugfs_fd = igt_debugfs_dir(drm_fd);
> > - if (debugfs_fd == -1)
> > - return -1;
> > + igt_assert(debugfs_fd >= 0);
> >
> > xe_for_each_gt(drm_fd, xe) {
> > sprintf(name, "gt%d/workarounds", xe);
> > @@ -58,7 +55,7 @@ int igt_has_intel_wa(int drm_fd, const char *check_wa)
> > break;
> > }
> >
> > - if (!ret)
> > + if (!ret && igt_debugfs_exists(drm_fd, "workarounds", O_RDONLY))
> > ret = debugfs_file_has_wa(drm_fd, debugfs_fd, "workarounds", check_wa);
> >
> > close(debugfs_fd);
> > --
> > 2.53.0
> >
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✗ Xe.CI.FULL: failure for Fix assert vs error in lib/intel_wa
2026-05-13 4:36 [PATCH v1 0/1] Fix assert vs error in lib/intel_wa Shekhar Chauhan
` (3 preceding siblings ...)
2026-05-13 6:00 ` ✓ Xe.CI.BAT: success " Patchwork
@ 2026-05-14 2:24 ` Patchwork
4 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2026-05-14 2:24 UTC (permalink / raw)
To: Shekhar Chauhan; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 29485 bytes --]
== Series Details ==
Series: Fix assert vs error in lib/intel_wa
URL : https://patchwork.freedesktop.org/series/166464/
State : failure
== Summary ==
CI Bug Log - changes from XEIGT_8908_FULL -> XEIGTPW_15171_FULL
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with XEIGTPW_15171_FULL absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_15171_FULL, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
to document this new failure mode, which will reduce false positives in CI.
Participating hosts (2 -> 2)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in XEIGTPW_15171_FULL:
### IGT changes ###
#### Possible regressions ####
* igt@xe_exec_system_allocator@twice-large-mmap-race:
- shard-lnl: [PASS][1] -> [ABORT][2]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-lnl-8/igt@xe_exec_system_allocator@twice-large-mmap-race.html
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-7/igt@xe_exec_system_allocator@twice-large-mmap-race.html
Known issues
------------
Here are the changes found in XEIGTPW_15171_FULL that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip:
- shard-lnl: NOTRUN -> [SKIP][3] ([Intel XE#3658] / [Intel XE#7360])
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-1/igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-180-hflip-async-flip.html
* igt@kms_big_fb@linear-64bpp-rotate-90:
- shard-bmg: NOTRUN -> [SKIP][4] ([Intel XE#2327])
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-2/igt@kms_big_fb@linear-64bpp-rotate-90.html
* igt@kms_big_fb@yf-tiled-16bpp-rotate-90:
- shard-bmg: NOTRUN -> [SKIP][5] ([Intel XE#1124])
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-3/igt@kms_big_fb@yf-tiled-16bpp-rotate-90.html
- shard-lnl: NOTRUN -> [SKIP][6] ([Intel XE#1124])
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-4/igt@kms_big_fb@yf-tiled-16bpp-rotate-90.html
* igt@kms_bw@connected-linear-tiling-2-displays-target-2560x1440p:
- shard-bmg: NOTRUN -> [SKIP][7] ([Intel XE#7679]) +1 other test skip
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-3/igt@kms_bw@connected-linear-tiling-2-displays-target-2560x1440p.html
* igt@kms_bw@connected-linear-tiling-3-displays-target-3840x2160p:
- shard-lnl: NOTRUN -> [SKIP][8] ([Intel XE#7679])
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-4/igt@kms_bw@connected-linear-tiling-3-displays-target-3840x2160p.html
* igt@kms_ccs@bad-rotation-90-4-tiled-mtl-mc-ccs:
- shard-bmg: NOTRUN -> [SKIP][9] ([Intel XE#2887]) +4 other tests skip
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-3/igt@kms_ccs@bad-rotation-90-4-tiled-mtl-mc-ccs.html
- shard-lnl: NOTRUN -> [SKIP][10] ([Intel XE#2887])
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-4/igt@kms_ccs@bad-rotation-90-4-tiled-mtl-mc-ccs.html
* igt@kms_chamelium_audio@hdmi-audio:
- shard-bmg: NOTRUN -> [SKIP][11] ([Intel XE#2252]) +1 other test skip
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-6/igt@kms_chamelium_audio@hdmi-audio.html
- shard-lnl: NOTRUN -> [SKIP][12] ([Intel XE#373])
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-2/igt@kms_chamelium_audio@hdmi-audio.html
* igt@kms_content_protection@dp-mst-type-0:
- shard-bmg: NOTRUN -> [SKIP][13] ([Intel XE#2390] / [Intel XE#6974])
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-1/igt@kms_content_protection@dp-mst-type-0.html
- shard-lnl: NOTRUN -> [SKIP][14] ([Intel XE#307] / [Intel XE#6974])
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-8/igt@kms_content_protection@dp-mst-type-0.html
* igt@kms_content_protection@suspend-resume:
- shard-bmg: NOTRUN -> [FAIL][15] ([Intel XE#1178] / [Intel XE#3304] / [Intel XE#7374]) +1 other test fail
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-3/igt@kms_content_protection@suspend-resume.html
* igt@kms_cursor_crc@cursor-rapid-movement-32x10:
- shard-bmg: NOTRUN -> [SKIP][16] ([Intel XE#2320]) +1 other test skip
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-8/igt@kms_cursor_crc@cursor-rapid-movement-32x10.html
- shard-lnl: NOTRUN -> [SKIP][17] ([Intel XE#1424])
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-5/igt@kms_cursor_crc@cursor-rapid-movement-32x10.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle:
- shard-bmg: NOTRUN -> [SKIP][18] ([Intel XE#2286] / [Intel XE#6035])
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-8/igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle.html
* igt@kms_fbcon_fbt@psr:
- shard-bmg: NOTRUN -> [SKIP][19] ([Intel XE#6126] / [Intel XE#776])
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-5/igt@kms_fbcon_fbt@psr.html
* igt@kms_feature_discovery@psr1:
- shard-bmg: NOTRUN -> [SKIP][20] ([Intel XE#2374] / [Intel XE#6127])
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-10/igt@kms_feature_discovery@psr1.html
* igt@kms_flip@2x-dpms-vs-vblank-race:
- shard-lnl: NOTRUN -> [SKIP][21] ([Intel XE#1421])
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-7/igt@kms_flip@2x-dpms-vs-vblank-race.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1:
- shard-lnl: [PASS][22] -> [FAIL][23] ([Intel XE#301])
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-lnl-5/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-4/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-edp1.html
* igt@kms_frontbuffer_tracking@drrs-2p-primscrn-cur-indfb-onoff:
- shard-lnl: NOTRUN -> [SKIP][24] ([Intel XE#656] / [Intel XE#7905]) +4 other tests skip
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-3/igt@kms_frontbuffer_tracking@drrs-2p-primscrn-cur-indfb-onoff.html
* igt@kms_frontbuffer_tracking@drrs-rgb565-draw-render:
- shard-bmg: NOTRUN -> [SKIP][25] ([Intel XE#2311]) +19 other tests skip
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-7/igt@kms_frontbuffer_tracking@drrs-rgb565-draw-render.html
- shard-lnl: NOTRUN -> [SKIP][26] ([Intel XE#6312] / [Intel XE#651]) +1 other test skip
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-4/igt@kms_frontbuffer_tracking@drrs-rgb565-draw-render.html
* igt@kms_frontbuffer_tracking@drrshdr-argb161616f-draw-mmap-wc:
- shard-lnl: NOTRUN -> [SKIP][27] ([Intel XE#7061])
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-4/igt@kms_frontbuffer_tracking@drrshdr-argb161616f-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
- shard-bmg: NOTRUN -> [SKIP][28] ([Intel XE#4141]) +1 other test skip
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-5/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
* igt@kms_frontbuffer_tracking@fbcdrrshdr-2p-primscrn-shrfb-pgflip-blt:
- shard-lnl: NOTRUN -> [SKIP][29] ([Intel XE#7905]) +4 other tests skip
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-3/igt@kms_frontbuffer_tracking@fbcdrrshdr-2p-primscrn-shrfb-pgflip-blt.html
* igt@kms_frontbuffer_tracking@fbcdrrshdr-rgb101010-draw-render:
- shard-lnl: NOTRUN -> [SKIP][30] ([Intel XE#6312]) +1 other test skip
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-4/igt@kms_frontbuffer_tracking@fbcdrrshdr-rgb101010-draw-render.html
* igt@kms_frontbuffer_tracking@fbcpsrhdr-1p-offscreen-pri-indfb-draw-mmap-wc:
- shard-lnl: NOTRUN -> [SKIP][31] ([Intel XE#7865]) +3 other tests skip
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-8/igt@kms_frontbuffer_tracking@fbcpsrhdr-1p-offscreen-pri-indfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psrhdr-1p-primscrn-pri-shrfb-draw-blt:
- shard-bmg: NOTRUN -> [SKIP][32] ([Intel XE#2313]) +17 other tests skip
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-3/igt@kms_frontbuffer_tracking@psrhdr-1p-primscrn-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@psrhdr-argb161616f-draw-mmap-wc:
- shard-bmg: NOTRUN -> [SKIP][33] ([Intel XE#7061]) +2 other tests skip
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-8/igt@kms_frontbuffer_tracking@psrhdr-argb161616f-draw-mmap-wc.html
* igt@kms_hdr@static-toggle@pipe-a-hdmi-a-3-xrgb16161616f:
- shard-bmg: [PASS][34] -> [SKIP][35] ([Intel XE#7915]) +3 other tests skip
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-bmg-9/igt@kms_hdr@static-toggle@pipe-a-hdmi-a-3-xrgb16161616f.html
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-7/igt@kms_hdr@static-toggle@pipe-a-hdmi-a-3-xrgb16161616f.html
* igt@kms_joiner@basic-max-non-joiner:
- shard-bmg: NOTRUN -> [SKIP][36] ([Intel XE#4298] / [Intel XE#5873])
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-8/igt@kms_joiner@basic-max-non-joiner.html
* igt@kms_plane@pixel-format-4-tiled-bmg-ccs-modifier-source-clamping:
- shard-lnl: NOTRUN -> [SKIP][37] ([Intel XE#7283])
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-4/igt@kms_plane@pixel-format-4-tiled-bmg-ccs-modifier-source-clamping.html
* igt@kms_plane@pixel-format-4-tiled-dg2-rc-ccs-cc-modifier:
- shard-bmg: NOTRUN -> [SKIP][38] ([Intel XE#7283])
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-5/igt@kms_plane@pixel-format-4-tiled-dg2-rc-ccs-cc-modifier.html
* igt@kms_pm_backlight@brightness-with-dpms:
- shard-bmg: NOTRUN -> [SKIP][39] ([Intel XE#2938] / [Intel XE#7376])
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-1/igt@kms_pm_backlight@brightness-with-dpms.html
* igt@kms_pm_dc@dc5-psr:
- shard-lnl: [PASS][40] -> [FAIL][41] ([Intel XE#7340])
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-lnl-7/igt@kms_pm_dc@dc5-psr.html
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-1/igt@kms_pm_dc@dc5-psr.html
* igt@kms_psr2_sf@fbc-pr-overlay-plane-move-continuous-sf:
- shard-lnl: NOTRUN -> [SKIP][42] ([Intel XE#2893] / [Intel XE#7304])
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-4/igt@kms_psr2_sf@fbc-pr-overlay-plane-move-continuous-sf.html
- shard-bmg: NOTRUN -> [SKIP][43] ([Intel XE#1489])
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-7/igt@kms_psr2_sf@fbc-pr-overlay-plane-move-continuous-sf.html
* igt@kms_psr@pr-cursor-plane-onoff:
- shard-lnl: NOTRUN -> [SKIP][44] ([Intel XE#1406])
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-8/igt@kms_psr@pr-cursor-plane-onoff.html
* igt@kms_psr@psr2-suspend:
- shard-bmg: NOTRUN -> [SKIP][45] ([Intel XE#2234] / [Intel XE#2850]) +2 other tests skip
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-9/igt@kms_psr@psr2-suspend.html
* igt@kms_sharpness_filter@filter-toggle:
- shard-bmg: NOTRUN -> [SKIP][46] ([Intel XE#6503]) +1 other test skip
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-3/igt@kms_sharpness_filter@filter-toggle.html
* igt@xe_eudebug@basic-vm-access-parameters-userptr:
- shard-lnl: NOTRUN -> [SKIP][47] ([Intel XE#7636])
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-5/igt@xe_eudebug@basic-vm-access-parameters-userptr.html
* igt@xe_eudebug@basic-vm-bind-metadata-discovery:
- shard-bmg: NOTRUN -> [SKIP][48] ([Intel XE#7636]) +5 other tests skip
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-5/igt@xe_eudebug@basic-vm-bind-metadata-discovery.html
* igt@xe_evict@evict-beng-mixed-many-threads-small:
- shard-bmg: NOTRUN -> [INCOMPLETE][49] ([Intel XE#6321])
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-6/igt@xe_evict@evict-beng-mixed-many-threads-small.html
* igt@xe_evict@evict-cm-threads-small-multi-queue:
- shard-bmg: NOTRUN -> [SKIP][50] ([Intel XE#7140])
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-2/igt@xe_evict@evict-cm-threads-small-multi-queue.html
- shard-lnl: NOTRUN -> [SKIP][51] ([Intel XE#6540] / [Intel XE#688])
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-4/igt@xe_evict@evict-cm-threads-small-multi-queue.html
* igt@xe_exec_balancer@once-cm-virtual-rebind:
- shard-lnl: NOTRUN -> [SKIP][52] ([Intel XE#7482])
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-3/igt@xe_exec_balancer@once-cm-virtual-rebind.html
* igt@xe_exec_basic@multigpu-many-execqueues-many-vm-userptr-invalidate:
- shard-bmg: NOTRUN -> [SKIP][53] ([Intel XE#2322] / [Intel XE#7372])
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-2/igt@xe_exec_basic@multigpu-many-execqueues-many-vm-userptr-invalidate.html
- shard-lnl: NOTRUN -> [SKIP][54] ([Intel XE#1392])
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-4/igt@xe_exec_basic@multigpu-many-execqueues-many-vm-userptr-invalidate.html
* igt@xe_exec_fault_mode@many-execqueues-multi-queue-rebind-prefetch:
- shard-bmg: NOTRUN -> [SKIP][55] ([Intel XE#7136]) +4 other tests skip
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-10/igt@xe_exec_fault_mode@many-execqueues-multi-queue-rebind-prefetch.html
- shard-lnl: NOTRUN -> [SKIP][56] ([Intel XE#7136]) +2 other tests skip
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-3/igt@xe_exec_fault_mode@many-execqueues-multi-queue-rebind-prefetch.html
* igt@xe_exec_multi_queue@max-queues-close-fd:
- shard-bmg: NOTRUN -> [SKIP][57] ([Intel XE#6874]) +9 other tests skip
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-9/igt@xe_exec_multi_queue@max-queues-close-fd.html
* igt@xe_exec_multi_queue@max-queues-dyn-priority:
- shard-lnl: NOTRUN -> [SKIP][58] ([Intel XE#6874]) +4 other tests skip
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-2/igt@xe_exec_multi_queue@max-queues-dyn-priority.html
* igt@xe_exec_reset@cm-multi-queue-close-fd:
- shard-bmg: NOTRUN -> [SKIP][59] ([Intel XE#7866])
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-7/igt@xe_exec_reset@cm-multi-queue-close-fd.html
* igt@xe_exec_threads@threads-multi-queue-cm-rebind:
- shard-lnl: NOTRUN -> [SKIP][60] ([Intel XE#7138]) +1 other test skip
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-2/igt@xe_exec_threads@threads-multi-queue-cm-rebind.html
* igt@xe_exec_threads@threads-multi-queue-cm-shared-vm-userptr:
- shard-bmg: NOTRUN -> [SKIP][61] ([Intel XE#7138]) +3 other tests skip
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-10/igt@xe_exec_threads@threads-multi-queue-cm-shared-vm-userptr.html
* igt@xe_multigpu_svm@mgpu-latency-prefetch:
- shard-bmg: NOTRUN -> [SKIP][62] ([Intel XE#6964])
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-1/igt@xe_multigpu_svm@mgpu-latency-prefetch.html
* igt@xe_pxp@pxp-stale-bo-bind-post-termination-irq:
- shard-bmg: NOTRUN -> [SKIP][63] ([Intel XE#4733] / [Intel XE#7417])
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-2/igt@xe_pxp@pxp-stale-bo-bind-post-termination-irq.html
* igt@xe_sriov_vram@vf-access-provisioned:
- shard-lnl: NOTRUN -> [SKIP][64] ([Intel XE#6376] / [Intel XE#7330] / [Intel XE#7422])
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-8/igt@xe_sriov_vram@vf-access-provisioned.html
* igt@xe_wedged@wedged-mode-toggle:
- shard-bmg: [PASS][65] -> [ABORT][66] ([Intel XE#7914])
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-bmg-2/igt@xe_wedged@wedged-mode-toggle.html
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-7/igt@xe_wedged@wedged-mode-toggle.html
#### Possible fixes ####
* igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs:
- shard-bmg: [INCOMPLETE][67] ([Intel XE#7084]) -> [PASS][68] +1 other test pass
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-bmg-4/igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs.html
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-6/igt@kms_ccs@crc-primary-suspend-4-tiled-bmg-ccs.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp2:
- shard-bmg: [FAIL][69] ([Intel XE#3321]) -> [PASS][70] +1 other test pass
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-bmg-6/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp2.html
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-3/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-dp2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1:
- shard-lnl: [FAIL][71] ([Intel XE#301] / [Intel XE#3149]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-lnl-5/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-4/igt@kms_flip@flip-vs-expired-vblank-interruptible@c-edp1.html
* igt@kms_hdr@invalid-metadata-sizes@pipe-a-hdmi-a-3-xrgb16161616f:
- shard-bmg: [SKIP][73] ([Intel XE#7915]) -> [PASS][74] +1 other test pass
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-bmg-8/igt@kms_hdr@invalid-metadata-sizes@pipe-a-hdmi-a-3-xrgb16161616f.html
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-5/igt@kms_hdr@invalid-metadata-sizes@pipe-a-hdmi-a-3-xrgb16161616f.html
* igt@xe_evict@evict-mixed-many-threads-small:
- shard-bmg: [INCOMPLETE][75] ([Intel XE#6321]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-bmg-9/igt@xe_evict@evict-mixed-many-threads-small.html
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-1/igt@xe_evict@evict-mixed-many-threads-small.html
* igt@xe_exec_reset@long-spin-reuse-many-preempt-gt0-threads:
- shard-bmg: [FAIL][77] ([Intel XE#7850]) -> [PASS][78]
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-bmg-3/igt@xe_exec_reset@long-spin-reuse-many-preempt-gt0-threads.html
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-4/igt@xe_exec_reset@long-spin-reuse-many-preempt-gt0-threads.html
* igt@xe_exec_system_allocator@many-mmap-remap-eocheck:
- shard-bmg: [ABORT][79] -> [PASS][80]
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-bmg-2/igt@xe_exec_system_allocator@many-mmap-remap-eocheck.html
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-3/igt@xe_exec_system_allocator@many-mmap-remap-eocheck.html
* igt@xe_sriov_flr@flr-each-isolation:
- shard-bmg: [FAIL][81] ([Intel XE#6569]) -> [PASS][82]
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-bmg-10/igt@xe_sriov_flr@flr-each-isolation.html
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-3/igt@xe_sriov_flr@flr-each-isolation.html
* igt@xe_survivability@runtime-survivability:
- shard-bmg: [DMESG-WARN][83] ([Intel XE#6627] / [Intel XE#7419]) -> [PASS][84]
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-bmg-7/igt@xe_survivability@runtime-survivability.html
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-1/igt@xe_survivability@runtime-survivability.html
* igt@xe_waitfence@engine:
- shard-bmg: [FAIL][85] ([Intel XE#6519]) -> [PASS][86]
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-bmg-5/igt@xe_waitfence@engine.html
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-2/igt@xe_waitfence@engine.html
* igt@xe_wedged@wedged-mode-toggle:
- shard-lnl: [ABORT][87] ([Intel XE#7914]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-lnl-4/igt@xe_wedged@wedged-mode-toggle.html
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-7/igt@xe_wedged@wedged-mode-toggle.html
#### Warnings ####
* igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions:
- shard-lnl: [SKIP][89] ([Intel XE#309] / [Intel XE#7343] / [Intel XE#7935]) -> [SKIP][90] ([Intel XE#309] / [Intel XE#7343])
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-lnl-8/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions.html
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-3/igt@kms_cursor_legacy@cursorb-vs-flipb-atomic-transitions.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible:
- shard-lnl: [FAIL][91] ([Intel XE#301] / [Intel XE#3149]) -> [FAIL][92] ([Intel XE#301])
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-lnl-5/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-lnl-4/igt@kms_flip@flip-vs-expired-vblank-interruptible.html
* igt@kms_tiled_display@basic-test-pattern:
- shard-bmg: [SKIP][93] ([Intel XE#2426] / [Intel XE#5848]) -> [FAIL][94] ([Intel XE#1729] / [Intel XE#7424])
[93]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_8908/shard-bmg-3/igt@kms_tiled_display@basic-test-pattern.html
[94]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/shard-bmg-10/igt@kms_tiled_display@basic-test-pattern.html
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1178]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1178
[Intel XE#1392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1392
[Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
[Intel XE#1421]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1421
[Intel XE#1424]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1424
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
[Intel XE#2286]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2286
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2327
[Intel XE#2374]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2374
[Intel XE#2390]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2390
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2850
[Intel XE#2887]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2887
[Intel XE#2893]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2893
[Intel XE#2938]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2938
[Intel XE#301]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/301
[Intel XE#307]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/307
[Intel XE#309]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/309
[Intel XE#3149]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3149
[Intel XE#3304]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3304
[Intel XE#3321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3321
[Intel XE#3658]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/3658
[Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373
[Intel XE#4141]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4141
[Intel XE#4298]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4298
[Intel XE#4733]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/4733
[Intel XE#5848]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5848
[Intel XE#5873]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/5873
[Intel XE#6035]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6035
[Intel XE#6126]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6126
[Intel XE#6127]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6127
[Intel XE#6312]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6312
[Intel XE#6321]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6321
[Intel XE#6376]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6376
[Intel XE#6503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6503
[Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
[Intel XE#6519]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6519
[Intel XE#6540]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6540
[Intel XE#656]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/656
[Intel XE#6569]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6569
[Intel XE#6627]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6627
[Intel XE#6874]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6874
[Intel XE#688]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/688
[Intel XE#6964]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6964
[Intel XE#6974]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/6974
[Intel XE#7061]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7061
[Intel XE#7084]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7084
[Intel XE#7136]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7136
[Intel XE#7138]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7138
[Intel XE#7140]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7140
[Intel XE#7283]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7283
[Intel XE#7304]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7304
[Intel XE#7330]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7330
[Intel XE#7340]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7340
[Intel XE#7343]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7343
[Intel XE#7360]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7360
[Intel XE#7372]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7372
[Intel XE#7374]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7374
[Intel XE#7376]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7376
[Intel XE#7417]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7417
[Intel XE#7419]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7419
[Intel XE#7422]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7422
[Intel XE#7424]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7424
[Intel XE#7482]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7482
[Intel XE#7636]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7636
[Intel XE#7679]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7679
[Intel XE#776]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/776
[Intel XE#7850]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7850
[Intel XE#7865]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7865
[Intel XE#7866]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7866
[Intel XE#7905]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7905
[Intel XE#7914]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7914
[Intel XE#7915]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7915
[Intel XE#7935]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/7935
Build changes
-------------
* IGT: IGT_8908 -> IGTPW_15171
IGTPW_15171: 3c31b3543ad48e730ad9834218574314fec69947 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
IGT_8908: d920ab298100bf1ee545ed419e4d9c3eb0499ba0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-5053-8fbb3d48e61c7e68cefdba85c3fa3ba59e7a93b4: 8fbb3d48e61c7e68cefdba85c3fa3ba59e7a93b4
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_15171/index.html
[-- Attachment #2: Type: text/html, Size: 32865 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2026-05-14 2:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-13 4:36 [PATCH v1 0/1] Fix assert vs error in lib/intel_wa Shekhar Chauhan
2026-05-13 4:36 ` [PATCH v1 1/1] lib/intel_wa: Assert on error instead of returning -1 Shekhar Chauhan
2026-05-13 6:41 ` Dixit, Ashutosh
2026-05-13 21:30 ` Dixit, Ashutosh
2026-05-13 5:50 ` ✗ i915.CI.BAT: failure for Fix assert vs error in lib/intel_wa Patchwork
2026-05-13 5:50 ` Patchwork
2026-05-13 6:00 ` ✓ Xe.CI.BAT: success " Patchwork
2026-05-14 2:24 ` ✗ Xe.CI.FULL: failure " Patchwork
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox