public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Shekhar Chauhan <shekhar.chauhan@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH v2 i-g-t] lib/xe/oa: Add support for 192B_MPEC8LL_NOA16 OAM format
Date: Thu, 16 Apr 2026 20:35:24 -0700	[thread overview]
Message-ID: <87y0im6yyr.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <4d5988f1-09a5-4e48-b133-2b1f2440cb5a@intel.com>

On Thu, 16 Apr 2026 19:09:57 -0700, Shekhar Chauhan wrote:
>
> On 4/17/2026 0:18, Ashutosh Dixit wrote:
> > Support for CRI 192B_MPEC8LL_NOA16 OAM format was previously missed
> > out. Add it.
> >
> > v2: Fix B/C counter accumulation (Shekhar C)
> >
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > ---
> >   lib/xe/oa-configs/oa-metricset-codegen.py | 13 +++++++++++-
> >   lib/xe/xe_oa.c                            | 24 +++++++++++++++++++++++
> >   2 files changed, 36 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/xe/oa-configs/oa-metricset-codegen.py b/lib/xe/oa-configs/oa-metricset-codegen.py
> > index c5c7a2c8d4..b44d4d73af 100644
>
> The patch itself makes sense now. But there's one change missing in 2
> places. The function "intel_xe_perf_read_record_timestamp" and
> "intel_xe_perf_read_record_timestamp_raw" both need this new format
> recognised there else they'll still fallback to "assert(0)".
>
> Other than that, this looks fine and we can merge it after that.

OK, thanks again, fixed in v3.

  reply	other threads:[~2026-04-17  3:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-16 18:48 [PATCH v2 i-g-t] lib/xe/oa: Add support for 192B_MPEC8LL_NOA16 OAM format Ashutosh Dixit
2026-04-17  0:52 ` ✓ i915.CI.BAT: success for lib/xe/oa: Add support for 192B_MPEC8LL_NOA16 OAM format (rev2) Patchwork
2026-04-17  1:03 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-17  2:09 ` [PATCH v2 i-g-t] lib/xe/oa: Add support for 192B_MPEC8LL_NOA16 OAM format Shekhar Chauhan
2026-04-17  3:35   ` Dixit, Ashutosh [this message]
2026-04-17  3:50 ` ✓ Xe.CI.FULL: success for lib/xe/oa: Add support for 192B_MPEC8LL_NOA16 OAM format (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y0im6yyr.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=shekhar.chauhan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox