Re: [PATCH i-g-t v3 3/4] xe/oa: Update scripts to support BMG

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Tue, 03 Sep 2024 13:54:56 -0700, José Roberto de Souza wrote:
>
> diff --git a/lib/xe/xe_oa.c b/lib/xe/xe_oa.c
> index 4764ed1fcf..a7df68488c 100644
> --- a/lib/xe/xe_oa.c
> +++ b/lib/xe/xe_oa.c
> @@ -38,6 +38,7 @@
>  #include "xe_oa_metrics_mtlgt3.h"
>  #include "xe_oa_metrics_pvc.h"
>  #include "xe_oa_metrics_lnl.h"
> +#include "xe_oa_metrics_bmg.h"
>
>  static struct intel_xe_perf_logical_counter_group *
>  intel_xe_perf_logical_counter_group_new(struct intel_xe_perf *perf,
> @@ -300,8 +301,10 @@ intel_xe_perf_for_devinfo(uint32_t device_id,
>	} else if (devinfo->is_pontevecchio) {
>		perf->devinfo.eu_threads_count = 8;
>		intel_xe_perf_load_metrics_pvc(perf);
> -	} else if (intel_graphics_ver(device_id) >= IP_VER(20, 0)) {
> +	} else if (devinfo->is_lunarlake) {
>		intel_xe_perf_load_metrics_lnl(perf);
> +	} else if (devinfo->is_battlemage) {
> +		intel_xe_perf_load_metrics_bmg(perf);

I made a small change to this patch here:

https://patchwork.freedesktop.org/patch/612713/?series=138273&rev=1

Basically retaining the "else if (intel_graphics_ver(device_id) >=
IP_VER(20, 0))" line, so that we can have LNL as the default platform for
Xe2+. Since generally LNL metrics will work, even for new platforms, at
least for the initial checkout, say during power-on's. And if not, we can
add a condition for that specific platform, which we anyway need to do with
the above code. So may save a little bit of work for the initial checkout.

Thanks.
--
Ashutosh