From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Mastan Katragadda <mastanx.katragadda@intel.com>
Cc: igt-dev@lists.freedesktop.org,
tejaskumarx.surendrakumar.upadhyay@intel.com,
jason@jlekstrand.net, matthew.brost@intel.com
Subject: Re: [igt-dev] [i-g-t] tests/i915/exec_balancer: Added Skip invalid-bonds
Date: Thu, 19 Aug 2021 13:00:43 -0700 [thread overview]
Message-ID: <87y28xb3x0.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <87zgtdb4kq.wl-ashutosh.dixit@intel.com>
On Thu, 19 Aug 2021 12:46:29 -0700, Dixit, Ashutosh wrote:
>
> On Wed, 18 Aug 2021 23:10:29 -0700, Mastan Katragadda wrote:
> >
> > Added skip which ever gen12+ platforms not supporing bonding.
> >
> > Disable bonding on gen12+ platforms aside from ones already supported by
> > the i915 - TGL, RKL, and ADL-S.
> >
> > Link: https://cgit.freedesktop.org/drm-tip/commit/?id=ce7e75c7ef1bf8ea3d947da8c674d2f40fd7d73
> >
> > Signed-off-by: Mastan Katragadda <mastanx.katragadda@intel.com>
> > ---
> > tests/i915/gem_exec_balancer.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
> > index 2f98950b..2d9c1a53 100644
> > --- a/tests/i915/gem_exec_balancer.c
> > +++ b/tests/i915/gem_exec_balancer.c
> > @@ -349,6 +349,10 @@ static void invalid_bonds(int i915)
> > bonds[n].num_bonds = 1;
> > }
> > engines.extensions = to_user_pointer(&bonds);
> > +
> > + igt_skip_on_f(__set_param_fresh_context(i915, p) == -ENODEV,
> > + "Bonding not supported\n");
> > +
> > igt_assert_eq(__set_param_fresh_context(i915, p), 0);
>
> int ret;
>
> ret = __set_param_fresh_context(i915, p);
> igt_skip_on_f(ret == -ENODEV, "Bonding not supported\n");
> igt_assert_eq(ret, 0);
>
> Also, is this the only test failing in gem_exec_balancer when bonding is
> not supported? Or are there others too? Thanks.
Looks like the invalid_balancer test introduced in 17914147aaf will also
fail since kernel will now return -ENODEV and not -EINVAL?
next prev parent reply other threads:[~2021-08-19 20:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 6:10 [igt-dev] [i-g-t] tests/i915/exec_balancer: Added Skip invalid-bonds Mastan Katragadda
2021-08-19 9:24 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-08-19 11:31 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-08-19 19:46 ` [igt-dev] [i-g-t] " Dixit, Ashutosh
2021-08-19 20:00 ` Dixit, Ashutosh [this message]
2021-08-20 1:47 ` Katragadda, MastanX
-- strict thread matches above, loose matches on Subject: below --
2021-08-20 2:03 Mastan Katragadda
2021-08-20 21:44 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y28xb3x0.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jason@jlekstrand.net \
--cc=mastanx.katragadda@intel.com \
--cc=matthew.brost@intel.com \
--cc=tejaskumarx.surendrakumar.upadhyay@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox