From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org, jasmine.newsome@intel.com
Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_dummyload: Drop ahnd from igt_spin_t
Date: Fri, 25 Feb 2022 14:18:21 -0800 [thread overview]
Message-ID: <87zgmefv4i.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <Yhi9t7mBg4pFncI+@zkempczy-mobl2>
On Fri, 25 Feb 2022 03:29:59 -0800, Zbigniew Kempczyński wrote:
>
> On Thu, Feb 24, 2022 at 02:02:29PM -0800, Ashutosh Dixit wrote:
> > In 4d9396e67930 we have started storing the opts with which the spin was
> > created as part of igt_spin_t. The ahnd stored as part of igt_spin_t is
> > therefore redundant. We can get ahnd from opts.ahnd.
>
> More than redundancy I like to keep opts which comes from the caller
> and thus suggests spinner code that's immune. Unfortunatelly we cannot
> block this after memcmp using c-syntax (I'm not able to do this).
Sorry, didn't follow what you are referring to here?
> Anyway, keeping caller vars in opts suggests this so:
>
> Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Thanks, but will wait for your reply before merging.
next prev parent reply other threads:[~2022-02-25 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 22:02 [igt-dev] [PATCH i-g-t] lib/igt_dummyload: Drop ahnd from igt_spin_t Ashutosh Dixit
2022-02-24 23:09 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2022-02-25 11:29 ` [igt-dev] [PATCH i-g-t] " Zbigniew Kempczyński
2022-02-25 22:18 ` Dixit, Ashutosh [this message]
2022-03-01 6:25 ` Zbigniew Kempczyński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgmefv4i.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jasmine.newsome@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox