* [igt-dev] [PATCH i-g-t] tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size
@ 2023-06-02 10:50 Juha-Pekka Heikkila
2023-06-02 11:40 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Juha-Pekka Heikkila @ 2023-06-02 10:50 UTC (permalink / raw)
To: igt-dev
Moved check for setting 64x64 plane size for pixel format tests into its own
function and added debug prints if couldn't use smaller than full mode size
plane for testing.
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_plane.c | 57 +++++++++++++++++++++++++++++------------------
1 file changed, 35 insertions(+), 22 deletions(-)
diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 90b68a47..dfc6a8c5 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -896,6 +896,40 @@ struct format_mod {
uint32_t format;
};
+/*
+ * See if test can go use 64x64 plane size for testing. If driver is not
+ * reporting to be atomic, will not try to use 64x64 plane size.
+*/
+static void check_allowed_plane_size_64x64(data_t *data, igt_plane_t *plane,
+ uint64_t *width, uint64_t *height,
+ uint32_t format)
+{
+ struct igt_fb test_fb;
+ int ret;
+
+ if (!data->display.is_atomic) {
+ igt_debug("Not using 64x64 plane size on non-atomic platform\n");
+ return;
+ }
+
+ igt_create_fb(data->drm_fd, 64, 64, format, DRM_FORMAT_MOD_LINEAR, &test_fb);
+ igt_plane_set_fb(plane, &test_fb);
+
+ ret = igt_display_try_commit_atomic(&data->display,
+ DRM_MODE_ATOMIC_TEST_ONLY |
+ DRM_MODE_ATOMIC_ALLOW_MODESET,
+ NULL);
+ if (!ret) {
+ *width = test_fb.width;
+ *height = test_fb.height;
+ } else {
+ igt_debug("Not using 64x64 plane size, atomic commit did not "
+ "accept 64x64 plane size\n");
+ }
+
+ igt_remove_fb(data->drm_fd, &test_fb);
+}
+
static bool test_format_plane(data_t *data, enum pipe pipe,
igt_output_t *output, igt_plane_t *plane, igt_fb_t *primary_fb)
{
@@ -944,28 +978,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
IGT_FORMAT_ARGS(ref.format), IGT_MODIFIER_ARGS(ref.modifier),
kmstest_pipe_name(pipe), plane->index);
- if (data->display.is_atomic) {
- struct igt_fb test_fb;
- int ret;
-
- igt_create_fb(data->drm_fd, 64, 64, ref.format,
- DRM_FORMAT_MOD_LINEAR, &test_fb);
-
- igt_plane_set_fb(plane, &test_fb);
-
- ret = igt_display_try_commit_atomic(&data->display,
- DRM_MODE_ATOMIC_TEST_ONLY |
- DRM_MODE_ATOMIC_ALLOW_MODESET,
- NULL);
- if (!ret) {
- width = test_fb.width;
- height = test_fb.height;
- }
-
- igt_plane_set_fb(plane, clear_fb);
-
- igt_remove_fb(data->drm_fd, &test_fb);
- }
+ check_allowed_plane_size_64x64(data, plane, &width, &height, ref.format);
capture_format_crcs_single(data, pipe, plane, ref.format, ref.modifier,
width, height, IGT_COLOR_YCBCR_BT709,
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size
2023-06-02 10:50 [igt-dev] [PATCH i-g-t] tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size Juha-Pekka Heikkila
@ 2023-06-02 11:40 ` Patchwork
2023-06-04 11:48 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-06-02 11:40 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 7873 bytes --]
== Series Details ==
Series: tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size
URL : https://patchwork.freedesktop.org/series/118768/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13218 -> IGTPW_9097
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/index.html
Participating hosts (38 -> 37)
------------------------------
Missing (1): fi-kbl-soraka
Known issues
------------
Here are the changes found in IGTPW_9097 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@core_hotunplug@unbind-rebind:
- fi-kbl-8809g: NOTRUN -> [ABORT][1] ([i915#8298] / [i915#8299] / [i915#8397])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/fi-kbl-8809g/igt@core_hotunplug@unbind-rebind.html
* igt@gem_huc_copy@huc-copy:
- fi-kbl-8809g: NOTRUN -> [SKIP][2] ([fdo#109271] / [i915#2190])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-hsw-4770: [PASS][3] -> [SKIP][4] ([fdo#109271])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/fi-hsw-4770/igt@i915_pm_rpm@basic-pci-d3-state.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/fi-hsw-4770/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@basic-rte:
- fi-hsw-4770: [PASS][5] -> [FAIL][6] ([i915#7364])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/fi-hsw-4770/igt@i915_pm_rpm@basic-rte.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/fi-hsw-4770/igt@i915_pm_rpm@basic-rte.html
* igt@i915_selftest@live@gt_pm:
- bat-rpls-2: [PASS][7] -> [DMESG-FAIL][8] ([i915#4258] / [i915#7913])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/bat-rpls-2/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@slpc:
- bat-rpls-2: NOTRUN -> [DMESG-WARN][9] ([i915#6367])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/bat-rpls-2/igt@i915_selftest@live@slpc.html
* igt@i915_suspend@basic-s2idle-without-i915:
- bat-rpls-2: NOTRUN -> [ABORT][10] ([i915#6687])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/bat-rpls-2/igt@i915_suspend@basic-s2idle-without-i915.html
* igt@i915_suspend@basic-s3-without-i915:
- bat-rpls-1: NOTRUN -> [ABORT][11] ([i915#6687] / [i915#7978])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/bat-rpls-1/igt@i915_suspend@basic-s3-without-i915.html
* igt@kms_addfb_basic@too-high:
- fi-kbl-8809g: NOTRUN -> [FAIL][12] ([i915#8296]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/fi-kbl-8809g/igt@kms_addfb_basic@too-high.html
* igt@kms_force_connector_basic@force-connector-state:
- fi-kbl-8809g: NOTRUN -> [DMESG-FAIL][13] ([i915#8299])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/fi-kbl-8809g/igt@kms_force_connector_basic@force-connector-state.html
* igt@kms_force_connector_basic@force-edid:
- fi-kbl-8809g: NOTRUN -> [CRASH][14] ([i915#8299])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/fi-kbl-8809g/igt@kms_force_connector_basic@force-edid.html
* igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1:
- bat-dg2-8: [PASS][15] -> [FAIL][16] ([i915#7932]) +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/bat-dg2-8/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence@pipe-c-dp-1.html
* igt@kms_psr@cursor_plane_move:
- fi-kbl-8809g: NOTRUN -> [SKIP][17] ([fdo#109271]) +59 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/fi-kbl-8809g/igt@kms_psr@cursor_plane_move.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-kbl-8809g: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#4579])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/fi-kbl-8809g/igt@kms_setmode@basic-clone-single-crtc.html
#### Possible fixes ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [DMESG-FAIL][19] ([i915#5334]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@hugepages:
- fi-apl-guc: [DMESG-FAIL][21] -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/fi-apl-guc/igt@i915_selftest@live@hugepages.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/fi-apl-guc/igt@i915_selftest@live@hugepages.html
* igt@i915_selftest@live@requests:
- bat-rpls-2: [ABORT][23] ([i915#4983] / [i915#7913]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/bat-rpls-2/igt@i915_selftest@live@requests.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/bat-rpls-2/igt@i915_selftest@live@requests.html
* igt@i915_selftest@live@reset:
- bat-rpls-1: [ABORT][25] ([i915#4983] / [i915#7461] / [i915#7981] / [i915#8347] / [i915#8384]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/bat-rpls-1/igt@i915_selftest@live@reset.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/bat-rpls-1/igt@i915_selftest@live@reset.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#4423]: https://gitlab.freedesktop.org/drm/intel/issues/4423
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4983]: https://gitlab.freedesktop.org/drm/intel/issues/4983
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6687]: https://gitlab.freedesktop.org/drm/intel/issues/6687
[i915#7364]: https://gitlab.freedesktop.org/drm/intel/issues/7364
[i915#7461]: https://gitlab.freedesktop.org/drm/intel/issues/7461
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7932]: https://gitlab.freedesktop.org/drm/intel/issues/7932
[i915#7978]: https://gitlab.freedesktop.org/drm/intel/issues/7978
[i915#7981]: https://gitlab.freedesktop.org/drm/intel/issues/7981
[i915#8296]: https://gitlab.freedesktop.org/drm/intel/issues/8296
[i915#8298]: https://gitlab.freedesktop.org/drm/intel/issues/8298
[i915#8299]: https://gitlab.freedesktop.org/drm/intel/issues/8299
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8384]: https://gitlab.freedesktop.org/drm/intel/issues/8384
[i915#8397]: https://gitlab.freedesktop.org/drm/intel/issues/8397
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7317 -> IGTPW_9097
CI-20190529: 20190529
CI_DRM_13218: 42043133c83c69e384fb66060c97b093df67aed7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9097: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/index.html
IGT_7317: c902b72df45aa49faa38205bc5be3c748d33a3e0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/index.html
[-- Attachment #2: Type: text/html, Size: 9379 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size
2023-06-02 10:50 [igt-dev] [PATCH i-g-t] tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size Juha-Pekka Heikkila
2023-06-02 11:40 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2023-06-04 11:48 ` Patchwork
2023-06-05 12:46 ` [igt-dev] [PATCH i-g-t] " Zbigniew Kempczyński
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2023-06-04 11:48 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
[-- Attachment #1: Type: text/plain, Size: 16284 bytes --]
== Series Details ==
Series: tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size
URL : https://patchwork.freedesktop.org/series/118768/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_13218_full -> IGTPW_9097_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/index.html
Participating hosts (7 -> 7)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_9097_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@kms_hdmi_inject@inject-audio:
- {shard-rkl}: [SKIP][1] ([i915#433]) -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-rkl-3/igt@kms_hdmi_inject@inject-audio.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-rkl-4/igt@kms_hdmi_inject@inject-audio.html
Known issues
------------
Here are the changes found in IGTPW_9097_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_workarounds@suspend-resume:
- shard-apl: [PASS][3] -> [ABORT][4] ([i915#180])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-apl6/igt@gem_workarounds@suspend-resume.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-apl1/igt@gem_workarounds@suspend-resume.html
* igt@i915_selftest@live@gt_heartbeat:
- shard-glk: [PASS][5] -> [DMESG-FAIL][6] ([i915#5334])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-glk4/igt@i915_selftest@live@gt_heartbeat.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-glk1/igt@i915_selftest@live@gt_heartbeat.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [PASS][7] -> [FAIL][8] ([i915#2346])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2:
- shard-glk: [PASS][9] -> [FAIL][10] ([i915#2122])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-glk7/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-glk8/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1:
- shard-glk: [PASS][11] -> [FAIL][12] ([i915#79])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-glk8/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-glk7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a1.html
* igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1:
- shard-apl: [PASS][13] -> [FAIL][14] ([i915#1188])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-apl1/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-apl2/igt@kms_hdr@bpc-switch-suspend@pipe-a-dp-1.html
* igt@kms_plane_lowres@tiling-x@pipe-a-dp-1:
- shard-apl: [PASS][15] -> [DMESG-WARN][16] ([i915#180])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-apl1/igt@kms_plane_lowres@tiling-x@pipe-a-dp-1.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-apl1/igt@kms_plane_lowres@tiling-x@pipe-a-dp-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-75-unity-scaling@pipe-b-vga-1:
- shard-snb: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4579]) +9 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-snb4/igt@kms_plane_scaling@planes-downscale-factor-0-75-unity-scaling@pipe-b-vga-1.html
* igt@kms_plane_scaling@planes-downscale-factor-0-75-upscale-20x20@pipe-a-hdmi-a-1:
- shard-snb: NOTRUN -> [SKIP][18] ([fdo#109271]) +11 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-snb1/igt@kms_plane_scaling@planes-downscale-factor-0-75-upscale-20x20@pipe-a-hdmi-a-1.html
* igt@kms_vblank@pipe-c-wait-forked-busy-hang:
- shard-apl: [PASS][19] -> [SKIP][20] ([fdo#109271])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-apl7/igt@kms_vblank@pipe-c-wait-forked-busy-hang.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-apl4/igt@kms_vblank@pipe-c-wait-forked-busy-hang.html
- shard-glk: [PASS][21] -> [SKIP][22] ([fdo#109271])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-glk8/igt@kms_vblank@pipe-c-wait-forked-busy-hang.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-glk5/igt@kms_vblank@pipe-c-wait-forked-busy-hang.html
#### Possible fixes ####
* igt@gem_ctx_freq@sysfs:
- {shard-dg1}: [FAIL][23] ([i915#6786]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-dg1-19/igt@gem_ctx_freq@sysfs.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-dg1-17/igt@gem_ctx_freq@sysfs.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-apl: [FAIL][25] ([i915#2842]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-apl7/igt@gem_exec_fair@basic-none-solo@rcs0.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-apl2/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-pace-share@rcs0:
- shard-glk: [FAIL][27] ([i915#2842]) -> [PASS][28] +2 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-glk7/igt@gem_exec_fair@basic-pace-share@rcs0.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-glk4/igt@gem_exec_fair@basic-pace-share@rcs0.html
* igt@gem_exec_fair@basic-pace@rcs0:
- {shard-rkl}: [FAIL][29] ([i915#2842]) -> [PASS][30] +1 similar issue
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-rkl-1/igt@gem_exec_fair@basic-pace@rcs0.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-rkl-3/igt@gem_exec_fair@basic-pace@rcs0.html
* igt@i915_pm_dc@dc6-dpms:
- {shard-tglu}: [FAIL][31] ([i915#3989] / [i915#454]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-tglu-10/igt@i915_pm_dc@dc6-dpms.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-tglu-9/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_rpm@dpms-mode-unset-lpsp:
- {shard-rkl}: [SKIP][33] ([i915#1397]) -> [PASS][34] +1 similar issue
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-rkl-1/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-rkl-7/igt@i915_pm_rpm@dpms-mode-unset-lpsp.html
* igt@i915_pm_rpm@modeset-non-lpsp:
- {shard-dg1}: [SKIP][35] ([i915#1397]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-dg1-19/igt@i915_pm_rpm@modeset-non-lpsp.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-dg1-14/igt@i915_pm_rpm@modeset-non-lpsp.html
* igt@kms_big_fb@y-tiled-32bpp-rotate-90:
- shard-glk: [DMESG-WARN][37] -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-glk9/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-glk4/igt@kms_big_fb@y-tiled-32bpp-rotate-90.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [FAIL][39] ([i915#2346]) -> [PASS][40]
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-glk8/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@forked-move@pipe-b:
- {shard-dg1}: [INCOMPLETE][41] ([i915#8011] / [i915#8347]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-dg1-19/igt@kms_cursor_legacy@forked-move@pipe-b.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-dg1-18/igt@kms_cursor_legacy@forked-move@pipe-b.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1:
- shard-apl: [FAIL][43] ([i915#79]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-apl3/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-dp1.html
* igt@kms_hdmi_inject@inject-audio:
- {shard-tglu}: [SKIP][45] ([i915#433]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-tglu-9/igt@kms_hdmi_inject@inject-audio.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-tglu-4/igt@kms_hdmi_inject@inject-audio.html
- shard-glk: [SKIP][47] ([fdo#109271]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13218/shard-glk8/igt@kms_hdmi_inject@inject-audio.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/shard-glk5/igt@kms_hdmi_inject@inject-audio.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#3023]: https://gitlab.freedesktop.org/drm/intel/issues/3023
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3591]: https://gitlab.freedesktop.org/drm/intel/issues/3591
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#404]: https://gitlab.freedesktop.org/drm/intel/issues/404
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#433]: https://gitlab.freedesktop.org/drm/intel/issues/433
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4525]: https://gitlab.freedesktop.org/drm/intel/issues/4525
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4565]: https://gitlab.freedesktop.org/drm/intel/issues/4565
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6786]: https://gitlab.freedesktop.org/drm/intel/issues/6786
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#8011]: https://gitlab.freedesktop.org/drm/intel/issues/8011
[i915#8292]: https://gitlab.freedesktop.org/drm/intel/issues/8292
[i915#8347]: https://gitlab.freedesktop.org/drm/intel/issues/8347
[i915#8411]: https://gitlab.freedesktop.org/drm/intel/issues/8411
[i915#8502]: https://gitlab.freedesktop.org/drm/intel/issues/8502
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_7317 -> IGTPW_9097
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_13218: 42043133c83c69e384fb66060c97b093df67aed7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_9097: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/index.html
IGT_7317: c902b72df45aa49faa38205bc5be3c748d33a3e0 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_9097/index.html
[-- Attachment #2: Type: text/html, Size: 13636 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size
2023-06-02 10:50 [igt-dev] [PATCH i-g-t] tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size Juha-Pekka Heikkila
2023-06-02 11:40 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-04 11:48 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2023-06-05 12:46 ` Zbigniew Kempczyński
2023-06-05 15:25 ` Sharma, Swati2
2023-06-05 15:27 ` Sharma, Swati2
4 siblings, 0 replies; 6+ messages in thread
From: Zbigniew Kempczyński @ 2023-06-05 12:46 UTC (permalink / raw)
To: Juha-Pekka Heikkila; +Cc: igt-dev
On Fri, Jun 02, 2023 at 01:50:01PM +0300, Juha-Pekka Heikkila wrote:
> Moved check for setting 64x64 plane size for pixel format tests into its own
> function and added debug prints if couldn't use smaller than full mode size
> plane for testing.
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
LGTM:
Acked-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
--
Zbigniew
> ---
> tests/kms_plane.c | 57 +++++++++++++++++++++++++++++------------------
> 1 file changed, 35 insertions(+), 22 deletions(-)
>
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 90b68a47..dfc6a8c5 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -896,6 +896,40 @@ struct format_mod {
> uint32_t format;
> };
>
> +/*
> + * See if test can go use 64x64 plane size for testing. If driver is not
> + * reporting to be atomic, will not try to use 64x64 plane size.
> +*/
> +static void check_allowed_plane_size_64x64(data_t *data, igt_plane_t *plane,
> + uint64_t *width, uint64_t *height,
> + uint32_t format)
> +{
> + struct igt_fb test_fb;
> + int ret;
> +
> + if (!data->display.is_atomic) {
> + igt_debug("Not using 64x64 plane size on non-atomic platform\n");
> + return;
> + }
> +
> + igt_create_fb(data->drm_fd, 64, 64, format, DRM_FORMAT_MOD_LINEAR, &test_fb);
> + igt_plane_set_fb(plane, &test_fb);
> +
> + ret = igt_display_try_commit_atomic(&data->display,
> + DRM_MODE_ATOMIC_TEST_ONLY |
> + DRM_MODE_ATOMIC_ALLOW_MODESET,
> + NULL);
> + if (!ret) {
> + *width = test_fb.width;
> + *height = test_fb.height;
> + } else {
> + igt_debug("Not using 64x64 plane size, atomic commit did not "
> + "accept 64x64 plane size\n");
> + }
> +
> + igt_remove_fb(data->drm_fd, &test_fb);
> +}
> +
> static bool test_format_plane(data_t *data, enum pipe pipe,
> igt_output_t *output, igt_plane_t *plane, igt_fb_t *primary_fb)
> {
> @@ -944,28 +978,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
> IGT_FORMAT_ARGS(ref.format), IGT_MODIFIER_ARGS(ref.modifier),
> kmstest_pipe_name(pipe), plane->index);
>
> - if (data->display.is_atomic) {
> - struct igt_fb test_fb;
> - int ret;
> -
> - igt_create_fb(data->drm_fd, 64, 64, ref.format,
> - DRM_FORMAT_MOD_LINEAR, &test_fb);
> -
> - igt_plane_set_fb(plane, &test_fb);
> -
> - ret = igt_display_try_commit_atomic(&data->display,
> - DRM_MODE_ATOMIC_TEST_ONLY |
> - DRM_MODE_ATOMIC_ALLOW_MODESET,
> - NULL);
> - if (!ret) {
> - width = test_fb.width;
> - height = test_fb.height;
> - }
> -
> - igt_plane_set_fb(plane, clear_fb);
> -
> - igt_remove_fb(data->drm_fd, &test_fb);
> - }
> + check_allowed_plane_size_64x64(data, plane, &width, &height, ref.format);
>
> capture_format_crcs_single(data, pipe, plane, ref.format, ref.modifier,
> width, height, IGT_COLOR_YCBCR_BT709,
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size
2023-06-02 10:50 [igt-dev] [PATCH i-g-t] tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size Juha-Pekka Heikkila
` (2 preceding siblings ...)
2023-06-05 12:46 ` [igt-dev] [PATCH i-g-t] " Zbigniew Kempczyński
@ 2023-06-05 15:25 ` Sharma, Swati2
2023-06-05 15:27 ` Sharma, Swati2
4 siblings, 0 replies; 6+ messages in thread
From: Sharma, Swati2 @ 2023-06-05 15:25 UTC (permalink / raw)
To: Juha-Pekka Heikkila, igt-dev
LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
On 02-Jun-23 4:20 PM, Juha-Pekka Heikkila wrote:
> Moved check for setting 64x64 plane size for pixel format tests into its own
> function and added debug prints if couldn't use smaller than full mode size
> plane for testing.
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> tests/kms_plane.c | 57 +++++++++++++++++++++++++++++------------------
> 1 file changed, 35 insertions(+), 22 deletions(-)
>
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 90b68a47..dfc6a8c5 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -896,6 +896,40 @@ struct format_mod {
> uint32_t format;
> };
>
> +/*
> + * See if test can go use 64x64 plane size for testing. If driver is not
> + * reporting to be atomic, will not try to use 64x64 plane size.
> +*/
> +static void check_allowed_plane_size_64x64(data_t *data, igt_plane_t *plane,
> + uint64_t *width, uint64_t *height,
> + uint32_t format)
> +{
> + struct igt_fb test_fb;
> + int ret;
> +
> + if (!data->display.is_atomic) {
> + igt_debug("Not using 64x64 plane size on non-atomic platform\n");
> + return;
> + }
> +
> + igt_create_fb(data->drm_fd, 64, 64, format, DRM_FORMAT_MOD_LINEAR, &test_fb);
> + igt_plane_set_fb(plane, &test_fb);
> +
> + ret = igt_display_try_commit_atomic(&data->display,
> + DRM_MODE_ATOMIC_TEST_ONLY |
> + DRM_MODE_ATOMIC_ALLOW_MODESET,
> + NULL);
> + if (!ret) {
> + *width = test_fb.width;
> + *height = test_fb.height;
> + } else {
> + igt_debug("Not using 64x64 plane size, atomic commit did not "
> + "accept 64x64 plane size\n");
> + }
> +
> + igt_remove_fb(data->drm_fd, &test_fb);
> +}
> +
> static bool test_format_plane(data_t *data, enum pipe pipe,
> igt_output_t *output, igt_plane_t *plane, igt_fb_t *primary_fb)
> {
> @@ -944,28 +978,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
> IGT_FORMAT_ARGS(ref.format), IGT_MODIFIER_ARGS(ref.modifier),
> kmstest_pipe_name(pipe), plane->index);
>
> - if (data->display.is_atomic) {
> - struct igt_fb test_fb;
> - int ret;
> -
> - igt_create_fb(data->drm_fd, 64, 64, ref.format,
> - DRM_FORMAT_MOD_LINEAR, &test_fb);
> -
> - igt_plane_set_fb(plane, &test_fb);
> -
> - ret = igt_display_try_commit_atomic(&data->display,
> - DRM_MODE_ATOMIC_TEST_ONLY |
> - DRM_MODE_ATOMIC_ALLOW_MODESET,
> - NULL);
> - if (!ret) {
> - width = test_fb.width;
> - height = test_fb.height;
> - }
> -
> - igt_plane_set_fb(plane, clear_fb);
> -
> - igt_remove_fb(data->drm_fd, &test_fb);
> - }
> + check_allowed_plane_size_64x64(data, plane, &width, &height, ref.format);
>
> capture_format_crcs_single(data, pipe, plane, ref.format, ref.modifier,
> width, height, IGT_COLOR_YCBCR_BT709,
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t] tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size
2023-06-02 10:50 [igt-dev] [PATCH i-g-t] tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size Juha-Pekka Heikkila
` (3 preceding siblings ...)
2023-06-05 15:25 ` Sharma, Swati2
@ 2023-06-05 15:27 ` Sharma, Swati2
4 siblings, 0 replies; 6+ messages in thread
From: Sharma, Swati2 @ 2023-06-05 15:27 UTC (permalink / raw)
To: Juha-Pekka Heikkila, igt-dev
LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
On 02-Jun-23 4:20 PM, Juha-Pekka Heikkila wrote:
> Moved check for setting 64x64 plane size for pixel format tests into its own
> function and added debug prints if couldn't use smaller than full mode size
> plane for testing.
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> tests/kms_plane.c | 57 +++++++++++++++++++++++++++++------------------
> 1 file changed, 35 insertions(+), 22 deletions(-)
>
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 90b68a47..dfc6a8c5 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -896,6 +896,40 @@ struct format_mod {
> uint32_t format;
> };
>
> +/*
> + * See if test can go use 64x64 plane size for testing. If driver is not
> + * reporting to be atomic, will not try to use 64x64 plane size.
> +*/
> +static void check_allowed_plane_size_64x64(data_t *data, igt_plane_t *plane,
> + uint64_t *width, uint64_t *height,
> + uint32_t format)
> +{
> + struct igt_fb test_fb;
> + int ret;
> +
> + if (!data->display.is_atomic) {
> + igt_debug("Not using 64x64 plane size on non-atomic platform\n");
> + return;
> + }
> +
> + igt_create_fb(data->drm_fd, 64, 64, format, DRM_FORMAT_MOD_LINEAR, &test_fb);
> + igt_plane_set_fb(plane, &test_fb);
> +
> + ret = igt_display_try_commit_atomic(&data->display,
> + DRM_MODE_ATOMIC_TEST_ONLY |
> + DRM_MODE_ATOMIC_ALLOW_MODESET,
> + NULL);
> + if (!ret) {
> + *width = test_fb.width;
> + *height = test_fb.height;
> + } else {
> + igt_debug("Not using 64x64 plane size, atomic commit did not "
> + "accept 64x64 plane size\n");
> + }
> +
> + igt_remove_fb(data->drm_fd, &test_fb);
> +}
> +
> static bool test_format_plane(data_t *data, enum pipe pipe,
> igt_output_t *output, igt_plane_t *plane, igt_fb_t *primary_fb)
> {
> @@ -944,28 +978,7 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
> IGT_FORMAT_ARGS(ref.format), IGT_MODIFIER_ARGS(ref.modifier),
> kmstest_pipe_name(pipe), plane->index);
>
> - if (data->display.is_atomic) {
> - struct igt_fb test_fb;
> - int ret;
> -
> - igt_create_fb(data->drm_fd, 64, 64, ref.format,
> - DRM_FORMAT_MOD_LINEAR, &test_fb);
> -
> - igt_plane_set_fb(plane, &test_fb);
> -
> - ret = igt_display_try_commit_atomic(&data->display,
> - DRM_MODE_ATOMIC_TEST_ONLY |
> - DRM_MODE_ATOMIC_ALLOW_MODESET,
> - NULL);
> - if (!ret) {
> - width = test_fb.width;
> - height = test_fb.height;
> - }
> -
> - igt_plane_set_fb(plane, clear_fb);
> -
> - igt_remove_fb(data->drm_fd, &test_fb);
> - }
> + check_allowed_plane_size_64x64(data, plane, &width, &height, ref.format);
>
> capture_format_crcs_single(data, pipe, plane, ref.format, ref.modifier,
> width, height, IGT_COLOR_YCBCR_BT709,
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-05 15:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-02 10:50 [igt-dev] [PATCH i-g-t] tests/kms_plane: Add debug prints for pixel format tests if couldn't use custom plane size Juha-Pekka Heikkila
2023-06-02 11:40 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-04 11:48 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-06-05 12:46 ` [igt-dev] [PATCH i-g-t] " Zbigniew Kempczyński
2023-06-05 15:25 ` Sharma, Swati2
2023-06-05 15:27 ` Sharma, Swati2
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox