Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "Joshi, Kunal1" <kunal1.joshi@intel.com>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 3/6] RFC tests/i915/kms_frontbuffer_tracking: xe doesn't support tiling as of now
Date: Thu, 1 Jun 2023 10:42:02 +0000	[thread overview]
Message-ID: <8c8f99e86bfd03f388491d9cd71f452cfc1b8e78.camel@intel.com> (raw)
In-Reply-To: <20230601050928.2487611-4-kunal1.joshi@intel.com>

On Thu, 2023-06-01 at 10:39 +0530, Kunal Joshi wrote:
> XE doesn't support tiling as of now, so set tiling to linear

Maybe this should be taken into account in opt_handler as well? I.e.
Trying to use tiling other than liner for Xe should result error.

> 
> v2: missed one tiling case
> 
> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
> ---
>  tests/i915/kms_frontbuffer_tracking.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/tests/i915/kms_frontbuffer_tracking.c
> b/tests/i915/kms_frontbuffer_tracking.c
> index 3bef46b6..de1a82a9 100644
> --- a/tests/i915/kms_frontbuffer_tracking.c
> +++ b/tests/i915/kms_frontbuffer_tracking.c
> @@ -1349,6 +1349,12 @@ static void setup_drm(void)
>          */
>         is_xe = is_xe_device(drm.fd);
>  
> +       /*
> +        * XE only support linear tiling
> +        */
> +       if (is_xe)
> +               opt.tiling = TILING_LINEAR;
> +
>         kmstest_set_vt_graphics_mode();
>         igt_display_require(&drm.display, drm.fd);
>  
> @@ -3642,6 +3648,9 @@ igt_main_args("", long_options, help_str,
> opt_handler, NULL)
>  
>                         for (t.tiling = TILING_LINEAR; t.tiling <
> TILING_COUNT;
>                              t.tiling++) {
> +                               if (is_xe && t.tiling !=
> TILING_LINEAR)
> +                                       continue;
> +
>                                 if (t.tiling == TILING_X)
>                                         continue;
>  


  reply	other threads:[~2023-06-01 10:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01  5:09 [igt-dev] [PATCH i-g-t 0/6] RFC Enable kms_frontbuffer_tracking on XE Kunal Joshi
2023-06-01  5:09 ` [igt-dev] [PATCH i-g-t 1/6] RFC tests/i915/kms_frontbuffer_tracking: Add xe support Kunal Joshi
2023-06-01  5:09 ` [igt-dev] [PATCH i-g-t 2/6] RFC Added is_xe to check if xe device Kunal Joshi
2023-06-01 10:11   ` Hogander, Jouni
2023-06-01 10:15     ` Joshi, Kunal1
2023-06-01  5:09 ` [igt-dev] [PATCH i-g-t 3/6] RFC tests/i915/kms_frontbuffer_tracking: xe doesn't support tiling as of now Kunal Joshi
2023-06-01 10:42   ` Hogander, Jouni [this message]
2023-06-01 11:09     ` Joshi, Kunal1
2023-06-01 11:23       ` Hogander, Jouni
2023-06-01 11:30         ` Joshi, Kunal1
2023-06-01  5:09 ` [igt-dev] [PATCH i-g-t 4/6] tests/i915/kms_frontbuffer_tracking: all gem ioctls are not supported for xe " Kunal Joshi
2023-06-01  5:09 ` [igt-dev] [PATCH i-g-t 5/6] RFC lib/ioctl_wrappers: GEM_SET_DOMAIN ioctl not supported on xe Kunal Joshi
2023-06-01  5:09 ` [igt-dev] [PATCH i-g-t 6/6] RFC tests/i915/kms_frontbuffer_tracking: xe only supports MMAP_WC, BLT, RENDER Kunal Joshi
2023-06-01  5:52 ` [igt-dev] ✓ Fi.CI.BAT: success for RFC Enable kms_frontbuffer_tracking on XE (rev2) Patchwork
2023-06-02 21:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-05-31 13:48 [igt-dev] [PATCH i-g-t 0/6] RFC Enable kms_frontbuffer_tracking on XE Kunal Joshi
2023-05-31 13:48 ` [igt-dev] [PATCH i-g-t 3/6] RFC tests/i915/kms_frontbuffer_tracking: xe doesn't support tiling as of now Kunal Joshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8c8f99e86bfd03f388491d9cd71f452cfc1b8e78.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kunal1.joshi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox