From: "Joshi, Kunal1" <kunal1.joshi@intel.com>
To: "Hogander, Jouni" <jouni.hogander@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 2/6] RFC Added is_xe to check if xe device
Date: Thu, 1 Jun 2023 15:45:36 +0530 [thread overview]
Message-ID: <8f9ce4d1-a8b6-bd74-d458-06bca5aac961@intel.com> (raw)
In-Reply-To: <c4c378943e9e1196ab5a9a8548a8af6e3e3b602b.camel@intel.com>
On 6/1/2023 3:41 PM, Hogander, Jouni wrote:
> Hello Kunal,
>
> Please check my comment below.
>
> On Thu, 2023-06-01 at 10:39 +0530, Kunal Joshi wrote:
>> Added is_xe for test to have XE checks
>>
>> Signed-off-by: Kunal Joshi <kunal1.joshi@intel.com>
>> ---
>> tests/i915/kms_frontbuffer_tracking.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/tests/i915/kms_frontbuffer_tracking.c
>> b/tests/i915/kms_frontbuffer_tracking.c
>> index c2b99670..3bef46b6 100644
>> --- a/tests/i915/kms_frontbuffer_tracking.c
>> +++ b/tests/i915/kms_frontbuffer_tracking.c
>> @@ -309,6 +309,8 @@ struct {
>> .stop = true,
>> };
>>
>> +static bool is_xe;
> Maybe you could just drop this and use is_xe_device() where you need to
> differentiate?
>
Hello Jouni,
Thanks for taking a look, will float changes as you suggested.
Regards
Kunal Joshi
next prev parent reply other threads:[~2023-06-01 10:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 5:09 [igt-dev] [PATCH i-g-t 0/6] RFC Enable kms_frontbuffer_tracking on XE Kunal Joshi
2023-06-01 5:09 ` [igt-dev] [PATCH i-g-t 1/6] RFC tests/i915/kms_frontbuffer_tracking: Add xe support Kunal Joshi
2023-06-01 5:09 ` [igt-dev] [PATCH i-g-t 2/6] RFC Added is_xe to check if xe device Kunal Joshi
2023-06-01 10:11 ` Hogander, Jouni
2023-06-01 10:15 ` Joshi, Kunal1 [this message]
2023-06-01 5:09 ` [igt-dev] [PATCH i-g-t 3/6] RFC tests/i915/kms_frontbuffer_tracking: xe doesn't support tiling as of now Kunal Joshi
2023-06-01 10:42 ` Hogander, Jouni
2023-06-01 11:09 ` Joshi, Kunal1
2023-06-01 11:23 ` Hogander, Jouni
2023-06-01 11:30 ` Joshi, Kunal1
2023-06-01 5:09 ` [igt-dev] [PATCH i-g-t 4/6] tests/i915/kms_frontbuffer_tracking: all gem ioctls are not supported for xe " Kunal Joshi
2023-06-01 5:09 ` [igt-dev] [PATCH i-g-t 5/6] RFC lib/ioctl_wrappers: GEM_SET_DOMAIN ioctl not supported on xe Kunal Joshi
2023-06-01 5:09 ` [igt-dev] [PATCH i-g-t 6/6] RFC tests/i915/kms_frontbuffer_tracking: xe only supports MMAP_WC, BLT, RENDER Kunal Joshi
2023-06-01 5:52 ` [igt-dev] ✓ Fi.CI.BAT: success for RFC Enable kms_frontbuffer_tracking on XE (rev2) Patchwork
2023-06-02 21:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-05-31 13:48 [igt-dev] [PATCH i-g-t 0/6] RFC Enable kms_frontbuffer_tracking on XE Kunal Joshi
2023-05-31 13:48 ` [igt-dev] [PATCH i-g-t 2/6] RFC Added is_xe to check if xe device Kunal Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f9ce4d1-a8b6-bd74-d458-06bca5aac961@intel.com \
--to=kunal1.joshi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jouni.hogander@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox