Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] tests/amdgpu: skips query-timestamp-while-idle test on raven/raven2
@ 2023-06-19  2:58 Jasber Chen
  2023-06-19 18:25 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 11+ messages in thread
From: Jasber Chen @ 2023-06-19  2:58 UTC (permalink / raw)
  To: igt-dev; +Cc: Jasber Chen, Christian König

tests/amdgpu: skips query-timestamp-while-idle test on raven/raven2.
Querying GPU clocks can not work as expected when GPU is idling.

Signed-off-by: Jasber Chen <yipeng.chen@amd.com>
---
 tests/amdgpu/amd_info.c | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/tests/amdgpu/amd_info.c b/tests/amdgpu/amd_info.c
index d6aea827..8e14e511 100644
--- a/tests/amdgpu/amd_info.c
+++ b/tests/amdgpu/amd_info.c
@@ -27,6 +27,7 @@
 
 #include <amdgpu.h>
 #include <amdgpu_drm.h>
+#include "lib/amdgpu/amdgpu_asic_addr.h"
 
 static amdgpu_device_handle dev;
 
@@ -124,6 +125,8 @@ IGT_TEST_DESCRIPTION("Test the consistency of the data provided through the "
 igt_main
 {
 	int fd = -1;
+	int r = -1;
+	struct amdgpu_gpu_info gpu_info = {0};
 
 	igt_fixture {
 		uint32_t major, minor;
@@ -136,6 +139,9 @@ igt_main
 
 		igt_info("Initialized amdgpu, driver version %d.%d\n",
 			 major, minor);
+
+		r = amdgpu_query_gpu_info(dev, &gpu_info);
+		igt_assert_eq(r, 0);
 	}
 
 	igt_describe("Make sure we can retrieve the firmware version");
@@ -149,8 +155,12 @@ igt_main
 
 	igt_describe("Check that the GPU time keeps on ticking, even during "
 		     "long idle times which could lead to clock/power gating");
-	igt_subtest("query-timestamp-while-idle")
+	igt_subtest("query-timestamp-while-idle") {
+		/* GPU on Raven/Raven2 may not work as expected when idling. */
+		igt_skip_on(ASICREV_IS_RAVEN(gpu_info.chip_external_rev) ||
+			    ASICREV_IS_RAVEN2(gpu_info.chip_external_rev));
 		query_timestamp_test(7000000, 1);
+	}
 
 	igt_fixture {
 		amdgpu_device_deinitialize(dev);
-- 
2.39.2

^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2023-06-20 13:46 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-19  2:58 [igt-dev] tests/amdgpu: skips query-timestamp-while-idle test on raven/raven2 Jasber Chen
2023-06-19 18:25 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2023-06-20  2:20 ` [igt-dev] " Jasber Chen
2023-06-20  6:00   ` Christian König
2023-06-20  4:46 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2023-06-20  5:41 ` [igt-dev] [PATCH] Subject: " Jasber Chen
2023-06-20  5:52 ` [igt-dev] " Jasber Chen
2023-06-20  6:44 ` Jasber Chen
2023-06-20  7:11   ` Christian König
2023-06-20  9:43 ` Jasber Chen
2023-06-20 13:46 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/amdgpu: skips query-timestamp-while-idle test on raven/raven2 (rev6) Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox