Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>,
	<igt-dev@lists.freedesktop.org>
Cc: John Harrison <John.Harrison@Igalia.com>,
	Kamil Konieczny <kamil.konieczny@linux.intel.com>,
	Harry Wentland <harry.wentland@amd.com>
Subject: Re: [PATCH i-g-t 2/2] tests/kms_properties: set client cap for color pipeline
Date: Wed, 22 Jul 2026 11:55:18 +0530	[thread overview]
Message-ID: <9299bbb2-b926-491f-840e-66d662746530@intel.com> (raw)
In-Reply-To: <20260714144532.351294-2-chaitanya.kumar.borah@intel.com>

Hi Chaitanya

On 14-07-2026 08:15 pm, Chaitanya Kumar Borah wrote:
> Set DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE for colorop subtests.
> Unset it when done.
>
> Cc: John Harrison <John.Harrison@Igalia.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Swati Sharma <swati2.sharma@intel.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> ---
>   tests/kms_properties.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/tests/kms_properties.c b/tests/kms_properties.c
> index f735839da..93bf1ea26 100644
> --- a/tests/kms_properties.c
> +++ b/tests/kms_properties.c
> @@ -340,10 +340,18 @@ static void colorop_properties(igt_display_t *display, bool atomic)
>   	bool found_any = false, found;
>   	igt_output_t *output;
>   	igt_crtc_t *crtc;
> +	int ret;
>   
>   	/* colorops are only available with atomic */
>   	igt_skip_on(!display->is_atomic);
>   
> +	ret = drmSetClientCap(display->drm_fd, DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE, 1);
> +	igt_skip_on_f(ret, "DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE not supported\n");
> +
> +	igt_display_fini(display);
> +	igt_display_require(display, display->drm_fd);
> +	display->has_plane_color_pipeline = true;
> +
>   	for_each_crtc(display, crtc) {
>   		found = false;
>   
> @@ -369,6 +377,12 @@ static void colorop_properties(igt_display_t *display, bool atomic)
>   		}
>   	}
>   
> +	ret = drmSetClientCap(display->drm_fd, DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE, 0);
> +	igt_assert_eq(ret, 0);
> +
> +	igt_display_fini(display);
> +	igt_display_require(display, display->drm_fd);
> +
>   	igt_skip_on(!found_any);
>   }

Patch LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

>   

  reply	other threads:[~2026-07-22  6:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-14 14:45 [PATCH i-g-t 1/2] Revert "lib/kms: Set display->has_plane_color_pipeline automatically" Chaitanya Kumar Borah
2026-07-14 14:45 ` [PATCH i-g-t 2/2] tests/kms_properties: set client cap for color pipeline Chaitanya Kumar Borah
2026-07-22  6:25   ` Sharma, Swati2 [this message]
2026-07-22 10:12   ` Kamil Konieczny
2026-07-22 10:14     ` Borah, Chaitanya Kumar
2026-07-14 19:50 ` ✓ Xe.CI.BAT: success for series starting with [i-g-t,1/2] Revert "lib/kms: Set display->has_plane_color_pipeline automatically" Patchwork
2026-07-14 20:01 ` ✗ i915.CI.BAT: failure " Patchwork
2026-07-15  3:44 ` ✓ Xe.CI.FULL: success " Patchwork
2026-07-17 10:33 ` ✓ Xe.CI.BAT: success for series starting with [i-g-t,1/2] Revert "lib/kms: Set display->has_plane_color_pipeline automatically" (rev2) Patchwork
2026-07-17 10:50 ` ✓ i915.CI.BAT: " Patchwork
2026-07-17 16:10 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-17 20:59 ` ✓ i915.CI.Full: " Patchwork
2026-07-21 10:55 ` [PATCH i-g-t 1/2] Revert "lib/kms: Set display->has_plane_color_pipeline automatically" Sharma, Swati2
2026-07-21 11:00   ` Borah, Chaitanya Kumar
2026-07-22  6:23     ` Sharma, Swati2
2026-07-22 10:59       ` Borah, Chaitanya Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9299bbb2-b926-491f-840e-66d662746530@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=John.Harrison@Igalia.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=harry.wentland@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox