Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH i-g-t 1/2] Revert "lib/kms: Set display->has_plane_color_pipeline automatically"
@ 2026-07-14 14:45 Chaitanya Kumar Borah
  2026-07-14 14:45 ` [PATCH i-g-t 2/2] tests/kms_properties: set client cap for color pipeline Chaitanya Kumar Borah
                   ` (8 more replies)
  0 siblings, 9 replies; 16+ messages in thread
From: Chaitanya Kumar Borah @ 2026-07-14 14:45 UTC (permalink / raw)
  To: igt-dev; +Cc: Chaitanya Kumar Borah, John Harrison, Kamil Konieczny,
	Swati Sharma

This reverts commit be4e98c3b79e8bb843f7bb762616742691fee72e.

Enabling DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE from the common
igt_display_require() path makes all IGT display clients opt into the
new plane color pipeline UAPI.

With the color pipeline client cap enabled, legacy plane COLOR_ENCODING
and COLOR_RANGE properties are ignored during commit preparation.
The driver cannot distinguish this case, because enum drm_color_encoding
and enum drm_color_range do not provide an explicit uninitialized value.

Revert the global opt-in and keep the cap enablement local to the
color-pipeline-aware tests. kms_properties colorop coverage shall be
preserved separately.

Cc: John Harrison <John.Harrison@Igalia.com>
Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
Cc: Swati Sharma <swati2.sharma@intel.com>
Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
---
 lib/igt_kms.c              | 2 --
 tests/kms_color_pipeline.c | 5 +++++
 tests/kms_colorop.c        | 4 ++++
 3 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/lib/igt_kms.c b/lib/igt_kms.c
index 2eefb773b..c56127c42 100644
--- a/lib/igt_kms.c
+++ b/lib/igt_kms.c
@@ -3201,8 +3201,6 @@ void igt_display_require(igt_display_t *display, int drm_fd)
 
 	if (drmSetClientCap(drm_fd, LOCAL_DRM_CLIENT_CAP_CURSOR_PLANE_HOTSPOT, 1) == 0)
 		display->has_virt_cursor_plane = 1;
-	if (drmSetClientCap(drm_fd, DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE, 1) == 0)
-		display->has_plane_color_pipeline = 1;
 
 	plane_resources = drmModeGetPlaneResources(display->drm_fd);
 	igt_assert(plane_resources);
diff --git a/tests/kms_color_pipeline.c b/tests/kms_color_pipeline.c
index 6119a830f..78860a845 100644
--- a/tests/kms_color_pipeline.c
+++ b/tests/kms_color_pipeline.c
@@ -349,6 +349,7 @@ run_tests_for_plane(data_t *data)
 
 int igt_main()
 {
+	int has_plane_color_pipeline = 0;
 	data_t data = {};
 
 	igt_fixture() {
@@ -363,9 +364,13 @@ int igt_main()
 		if (drmSetClientCap(data.drm_fd, DRM_CLIENT_CAP_ATOMIC, 1) == 0)
 			data.display.is_atomic = 1;
 
+		if (drmSetClientCap(data.drm_fd, DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE, 1) == 0)
+			has_plane_color_pipeline = 1;
+
 		kmstest_set_vt_graphics_mode();
 
 		igt_display_require(&data.display, data.drm_fd);
+		data.display.has_plane_color_pipeline = has_plane_color_pipeline;
 		igt_require(data.display.is_atomic);
 	}
 
diff --git a/tests/kms_colorop.c b/tests/kms_colorop.c
index 4db83470d..16db0b8ad 100644
--- a/tests/kms_colorop.c
+++ b/tests/kms_colorop.c
@@ -418,10 +418,14 @@ int igt_main_args("d", long_options, help_str, opt_handler, NULL)
 		igt_require_f(!ret, "error setting DRM_CLIENT_CAP_WRITEBACK_CONNECTORS\n");
 
 		igt_display_require(&display, display.drm_fd);
+		if (drmSetClientCap(display.drm_fd, DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE, 1) == 0)
+			display.has_plane_color_pipeline = 1;
 
 		kmstest_set_vt_graphics_mode();
 
 		igt_display_require(&display, display.drm_fd);
+		if (drmSetClientCap(display.drm_fd, DRM_CLIENT_CAP_PLANE_COLOR_PIPELINE, 1) == 0)
+			display.has_plane_color_pipeline = 1;
 
 		igt_require(display.is_atomic);
 	}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2026-07-22 10:59 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-14 14:45 [PATCH i-g-t 1/2] Revert "lib/kms: Set display->has_plane_color_pipeline automatically" Chaitanya Kumar Borah
2026-07-14 14:45 ` [PATCH i-g-t 2/2] tests/kms_properties: set client cap for color pipeline Chaitanya Kumar Borah
2026-07-22  6:25   ` Sharma, Swati2
2026-07-22 10:12   ` Kamil Konieczny
2026-07-22 10:14     ` Borah, Chaitanya Kumar
2026-07-14 19:50 ` ✓ Xe.CI.BAT: success for series starting with [i-g-t,1/2] Revert "lib/kms: Set display->has_plane_color_pipeline automatically" Patchwork
2026-07-14 20:01 ` ✗ i915.CI.BAT: failure " Patchwork
2026-07-15  3:44 ` ✓ Xe.CI.FULL: success " Patchwork
2026-07-17 10:33 ` ✓ Xe.CI.BAT: success for series starting with [i-g-t,1/2] Revert "lib/kms: Set display->has_plane_color_pipeline automatically" (rev2) Patchwork
2026-07-17 10:50 ` ✓ i915.CI.BAT: " Patchwork
2026-07-17 16:10 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-17 20:59 ` ✓ i915.CI.Full: " Patchwork
2026-07-21 10:55 ` [PATCH i-g-t 1/2] Revert "lib/kms: Set display->has_plane_color_pipeline automatically" Sharma, Swati2
2026-07-21 11:00   ` Borah, Chaitanya Kumar
2026-07-22  6:23     ` Sharma, Swati2
2026-07-22 10:59       ` Borah, Chaitanya Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox