* [igt-dev] [PATCH i-g-t 0/2] tools/intel_gpu_top: Fix Device selection issues
@ 2020-10-23 17:51 Ayaz A Siddiqui
2020-10-23 17:51 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan:Add function to get pci subsystem of requested card Ayaz A Siddiqui
` (4 more replies)
0 siblings, 5 replies; 9+ messages in thread
From: Ayaz A Siddiqui @ 2020-10-23 17:51 UTC (permalink / raw)
To: igt-dev; +Cc: Ayaz A Siddiqui
There was two issues identified during intel_gpu_top testing.
1. In case of multiple discrete GPU platform, if first card is not
intel card then execution failed with error. To solve this issue a check for
intel device (8086) is added during device selection.
2. Intel_gpu_top was failing to execute if device selection filter was other than
“pci”. intel_gpu_top requires card information and PCI_SLOT_NAME for dGPU.
Only pci subsystem contains both information.
In case of user filter is other than pci subsystem then we need card
information of associated pci subsystem which is stored as parent of
requested card if available.
Ayaz A Siddiqui (2):
lib/igt_device_scan:Add function to get pci subsystem of requested
card
lib/igt_device_scan: Select intel as default vendor for intel_gpu_top
lib/igt_device_scan.c | 95 +++++++++++++++++++++++++++----------------
lib/igt_device_scan.h | 2 +
tools/intel_gpu_top.c | 2 +-
3 files changed, 64 insertions(+), 35 deletions(-)
--
2.26.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan:Add function to get pci subsystem of requested card
2020-10-23 17:51 [igt-dev] [PATCH i-g-t 0/2] tools/intel_gpu_top: Fix Device selection issues Ayaz A Siddiqui
@ 2020-10-23 17:51 ` Ayaz A Siddiqui
2020-10-26 4:43 ` Zbigniew Kempczyński
2020-10-23 17:51 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: Select intel as default vendor for intel_gpu_top Ayaz A Siddiqui
` (3 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Ayaz A Siddiqui @ 2020-10-23 17:51 UTC (permalink / raw)
To: igt-dev; +Cc: Ayaz A Siddiqui, Petri Latvala
intel_gpu_top requires card information and PCI_SLOT_NAME for dGPU.
Only pci subsystem contains both information.
In case of user filter is other than pci subsystem then we need card
information of associated pci subsystem which is stored as parent of
requested card if available.
A new api has been added to cater intel_gpu_top requirement.
Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Zbigniew Kempczynski <zbigniew.kempczynski@intel.com>
Cc: Dixit Ashutosh <ashutosh.dixit@intel.com>
---
lib/igt_device_scan.c | 55 ++++++++++++++++++++++++++++++++-----------
lib/igt_device_scan.h | 2 ++
tools/intel_gpu_top.c | 2 +-
3 files changed, 44 insertions(+), 15 deletions(-)
diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index f4d43c733..55aa8159d 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -1237,18 +1237,9 @@ static bool igt_device_filter_apply(const char *fstr)
return true;
}
-/**
- * igt_device_card_match
- * @filter: filter string
- * @card: pointer to igt_device_card struct
- *
- * Function applies filter to match device from device array.
- *
- * Returns:
- * false - no card pointer was passed or card wasn't matched,
- * true - card matched and returned.
- */
-bool igt_device_card_match(const char *filter, struct igt_device_card *card)
+
+static bool __igt_device_card_match(const char *filter,
+ struct igt_device_card *card, bool request_pci_ss)
{
struct igt_device *dev = NULL;
@@ -1266,10 +1257,46 @@ bool igt_device_card_match(const char *filter, struct igt_device_card *card)
/* We take first one if more than one card matches filter */
dev = igt_list_first_entry(&igt_devs.filtered, dev, link);
+ if (request_pci_ss && !is_pci_subsystem(dev) && dev->parent
+ && is_pci_subsystem(dev->parent))
+ __copy_dev_to_card(dev->parent, card);
+ else
+ __copy_dev_to_card(dev, card);
+ return true;
+}
- __copy_dev_to_card(dev, card);
+/**
+ * igt_device_card_match
+ * @filter: filter string
+ * @card: pointer to igt_device_card struct
+ *
+ * Function applies filter to match device from device array.
+ *
+ * Returns:
+ * false - no card pointer was passed or card wasn't matched,
+ * true - card matched and returned.
+ */
+bool igt_device_card_match(const char *filter, struct igt_device_card *card)
+{
+ return __igt_device_card_match(filter, card, false);
+}
- return true;
+/**
+ * igt_device_card_match_pci
+ * @filter: filter string
+ * @card: pointer to igt_device_card struct
+ *
+ * Function applies filter to match device from device array.
+ * Populate associated pci subsystem data if available.
+ *
+ * Returns:
+ * false - no card pointer was passed or card wasn't matched,
+ * true - card matched and returned.
+ */
+bool igt_device_card_match_pci(const char *filter,
+ struct igt_device_card *card)
+{
+ return __igt_device_card_match(filter, card, true);
}
/**
diff --git a/lib/igt_device_scan.h b/lib/igt_device_scan.h
index bd937d227..544e982c4 100644
--- a/lib/igt_device_scan.h
+++ b/lib/igt_device_scan.h
@@ -68,6 +68,8 @@ const char *igt_device_filter_get(int num);
/* Use filter to match the device and fill card structure */
bool igt_device_card_match(const char *filter, struct igt_device_card *card);
+bool igt_device_card_match_pci(const char *filter,
+ struct igt_device_card *card);
bool igt_device_find_first_i915_discrete_card(struct igt_device_card *card);
int igt_open_card(struct igt_device_card *card);
int igt_open_render(struct igt_device_card *card);
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 79a936ffb..1b6c8633b 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -1393,7 +1393,7 @@ int main(int argc, char **argv)
}
if (opt_device != NULL) {
- ret = igt_device_card_match(opt_device, &card);
+ ret = igt_device_card_match_pci(opt_device, &card);
if (!ret)
fprintf(stderr, "Requested device %s not found!\n", opt_device);
free(opt_device);
--
2.26.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: Select intel as default vendor for intel_gpu_top
2020-10-23 17:51 [igt-dev] [PATCH i-g-t 0/2] tools/intel_gpu_top: Fix Device selection issues Ayaz A Siddiqui
2020-10-23 17:51 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan:Add function to get pci subsystem of requested card Ayaz A Siddiqui
@ 2020-10-23 17:51 ` Ayaz A Siddiqui
2020-10-26 4:43 ` Zbigniew Kempczyński
2020-10-23 18:40 ` [igt-dev] ✓ Fi.CI.BAT: success for tools/intel_gpu_top: Fix Device selection issues Patchwork
` (2 subsequent siblings)
4 siblings, 1 reply; 9+ messages in thread
From: Ayaz A Siddiqui @ 2020-10-23 17:51 UTC (permalink / raw)
To: igt-dev; +Cc: Ayaz A Siddiqui, Petri Latvala
intel_gpu_top is selecting first discrete device as default drm subsystem.
In case of multi-gpu system if the first device is not intel gpu
then it will lead to an error while running intel_gpu_top.
Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Zbigniew Kempczynski <zbigniew.kempczynski@intel.com>
Cc: Dixit Ashutosh <ashutosh.dixit@intel.com>
---
lib/igt_device_scan.c | 40 ++++++++++++++++++++--------------------
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index 55aa8159d..0967c6450 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -426,6 +426,25 @@ static struct igt_device *igt_device_find(const char *subsystem,
return NULL;
}
+static bool is_vendor_matched(struct igt_device *dev, const char *vendor)
+{
+ const char *vendor_id;
+
+ if (!dev->vendor || !vendor)
+ return false;
+
+ /* First we compare vendor id, like 8086 */
+ if (!strcasecmp(dev->vendor, vendor))
+ return true;
+
+ /* Likely we have vendor string instead of id */
+ vendor_id = get_pci_vendor_id_by_name(vendor);
+ if (!vendor_id)
+ return false;
+
+ return !strcasecmp(dev->vendor, vendor_id);
+}
+
static void
__copy_dev_to_card(struct igt_device *dev, struct igt_device_card *card)
{
@@ -457,7 +476,7 @@ bool igt_device_find_first_i915_discrete_card(struct igt_device_card *card)
igt_list_for_each_entry(dev, &igt_devs.all, link) {
- if (!is_pci_subsystem(dev))
+ if (!is_pci_subsystem(dev) || !is_vendor_matched(dev, "intel"))
continue;
if ((strncmp(dev->pci_slot_name, INTEGRATED_I915_GPU_PCI_ID, PCI_SLOT_NAME_SIZE)) != 0) {
@@ -893,25 +912,6 @@ static bool parse_filter(const char *fstr, struct filter *filter)
return false;
}
-static bool is_vendor_matched(struct igt_device *dev, const char *vendor)
-{
- const char *vendor_id;
-
- if (!dev->vendor || !vendor)
- return false;
-
- /* First we compare vendor id, like 8086 */
- if (!strcasecmp(dev->vendor, vendor))
- return true;
-
- /* Likely we have vendor string instead of id */
- vendor_id = get_pci_vendor_id_by_name(vendor);
- if (!vendor_id)
- return false;
-
- return !strcasecmp(dev->vendor, vendor_id);
-}
-
/* Filter which matches subsystem:/sys/... path.
* Used as first filter in chain.
*/
--
2.26.2
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [igt-dev] ✓ Fi.CI.BAT: success for tools/intel_gpu_top: Fix Device selection issues
2020-10-23 17:51 [igt-dev] [PATCH i-g-t 0/2] tools/intel_gpu_top: Fix Device selection issues Ayaz A Siddiqui
2020-10-23 17:51 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan:Add function to get pci subsystem of requested card Ayaz A Siddiqui
2020-10-23 17:51 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: Select intel as default vendor for intel_gpu_top Ayaz A Siddiqui
@ 2020-10-23 18:40 ` Patchwork
2020-10-23 22:14 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-10-26 8:44 ` [igt-dev] [PATCH i-g-t 0/2] " Petri Latvala
4 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2020-10-23 18:40 UTC (permalink / raw)
To: Ayaz A Siddiqui; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 4564 bytes --]
== Series Details ==
Series: tools/intel_gpu_top: Fix Device selection issues
URL : https://patchwork.freedesktop.org/series/83015/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_9191 -> IGTPW_5094
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/index.html
Known issues
------------
Here are the changes found in IGTPW_5094 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
- fi-icl-u2: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/fi-icl-u2/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
#### Possible fixes ####
* igt@gem_close_race@basic-threads:
- fi-apl-guc: [INCOMPLETE][3] ([i915#1635]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/fi-apl-guc/igt@gem_close_race@basic-threads.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/fi-apl-guc/igt@gem_close_race@basic-threads.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-bsw-kefka: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/fi-bsw-kefka/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_pm_rpm@module-reload:
- fi-byt-j1900: [DMESG-WARN][7] ([i915#1982]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/fi-byt-j1900/igt@i915_pm_rpm@module-reload.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: [DMESG-WARN][9] ([i915#165]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-kbl-7500u: [DMESG-WARN][11] ([i915#2203]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/fi-kbl-7500u/igt@kms_chamelium@hdmi-crc-fast.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/fi-kbl-7500u/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- {fi-kbl-7560u}: [DMESG-WARN][13] ([i915#1982]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/fi-kbl-7560u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/fi-kbl-7560u/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-icl-u2: [DMESG-WARN][15] ([i915#1982]) -> [PASS][16] +1 similar issue
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#165]: https://gitlab.freedesktop.org/drm/intel/issues/165
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203
Participating hosts (46 -> 39)
------------------------------
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5823 -> IGTPW_5094
CI-20190529: 20190529
CI_DRM_9191: 4b693bbb9b41fda404b5cd081bf5cd8dba240468 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5094: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/index.html
IGT_5823: 7dd2fe99bd9dde00456cc5abf7e5ef0c8d7d6118 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/index.html
[-- Attachment #1.2: Type: text/html, Size: 5626 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* [igt-dev] ✗ Fi.CI.IGT: failure for tools/intel_gpu_top: Fix Device selection issues
2020-10-23 17:51 [igt-dev] [PATCH i-g-t 0/2] tools/intel_gpu_top: Fix Device selection issues Ayaz A Siddiqui
` (2 preceding siblings ...)
2020-10-23 18:40 ` [igt-dev] ✓ Fi.CI.BAT: success for tools/intel_gpu_top: Fix Device selection issues Patchwork
@ 2020-10-23 22:14 ` Patchwork
2020-10-24 2:03 ` Siddiqui, Ayaz A
2020-10-26 8:44 ` [igt-dev] [PATCH i-g-t 0/2] " Petri Latvala
4 siblings, 1 reply; 9+ messages in thread
From: Patchwork @ 2020-10-23 22:14 UTC (permalink / raw)
To: Ayaz A Siddiqui; +Cc: igt-dev
[-- Attachment #1.1: Type: text/plain, Size: 14644 bytes --]
== Series Details ==
Series: tools/intel_gpu_top: Fix Device selection issues
URL : https://patchwork.freedesktop.org/series/83015/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_9191_full -> IGTPW_5094_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with IGTPW_5094_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_5094_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/index.html
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in IGTPW_5094_full:
### IGT changes ###
#### Possible regressions ####
* igt@gem_ctx_persistence@engines-hostile@bcs0:
- shard-glk: [PASS][1] -> [FAIL][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-glk2/igt@gem_ctx_persistence@engines-hostile@bcs0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-glk5/igt@gem_ctx_persistence@engines-hostile@bcs0.html
* igt@gem_ctx_persistence@engines-hostile@rcs0:
- shard-tglb: [PASS][3] -> [FAIL][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-tglb6/igt@gem_ctx_persistence@engines-hostile@rcs0.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-tglb7/igt@gem_ctx_persistence@engines-hostile@rcs0.html
* igt@gem_exec_parallel@contexts@bcs0:
- shard-hsw: [PASS][5] -> [FAIL][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-hsw7/igt@gem_exec_parallel@contexts@bcs0.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-hsw2/igt@gem_exec_parallel@contexts@bcs0.html
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@core_hotunplug@hotrebind}:
- shard-hsw: NOTRUN -> [WARN][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-hsw2/igt@core_hotunplug@hotrebind.html
* {igt@gem_exec_capture@pi@vecs0}:
- shard-tglb: [PASS][8] -> [INCOMPLETE][9]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-tglb5/igt@gem_exec_capture@pi@vecs0.html
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-tglb6/igt@gem_exec_capture@pi@vecs0.html
Known issues
------------
Here are the changes found in IGTPW_5094_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_exec_parallel@contexts@vecs0:
- shard-hsw: [PASS][10] -> [FAIL][11] ([i915#1888]) +2 similar issues
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-hsw7/igt@gem_exec_parallel@contexts@vecs0.html
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-hsw2/igt@gem_exec_parallel@contexts@vecs0.html
* igt@gem_exec_reloc@basic-many-active@vecs0:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#2389]) +2 similar issues
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-glk4/igt@gem_exec_reloc@basic-many-active@vecs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-glk1/igt@gem_exec_reloc@basic-many-active@vecs0.html
* igt@gem_exec_whisper@basic-contexts-forked:
- shard-iclb: [PASS][14] -> [INCOMPLETE][15] ([i915#1895])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-iclb7/igt@gem_exec_whisper@basic-contexts-forked.html
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-iclb3/igt@gem_exec_whisper@basic-contexts-forked.html
* igt@gem_softpin@softpin:
- shard-glk: [PASS][16] -> [INCOMPLETE][17] ([i915#1888])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-glk6/igt@gem_softpin@softpin.html
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-glk2/igt@gem_softpin@softpin.html
* igt@gem_userptr_blits@coherency-unsync:
- shard-snb: [PASS][18] -> [INCOMPLETE][19] ([i915#82])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-snb4/igt@gem_userptr_blits@coherency-unsync.html
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-snb7/igt@gem_userptr_blits@coherency-unsync.html
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
- shard-hsw: [PASS][20] -> [FAIL][21] ([i915#2370])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1:
- shard-glk: [PASS][22] -> [FAIL][23] ([i915#79])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1.html
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-glk4/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-dp1:
- shard-kbl: [PASS][24] -> [FAIL][25] ([i915#2122])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-kbl4/igt@kms_flip@plain-flip-ts-check-interruptible@c-dp1.html
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-kbl1/igt@kms_flip@plain-flip-ts-check-interruptible@c-dp1.html
* igt@kms_frontbuffer_tracking@fbc-badstride:
- shard-kbl: [PASS][26] -> [DMESG-WARN][27] ([i915#1982])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-badstride.html
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-badstride.html
- shard-snb: [PASS][28] -> [FAIL][29] ([i915#2546])
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-snb2/igt@kms_frontbuffer_tracking@fbc-badstride.html
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-snb5/igt@kms_frontbuffer_tracking@fbc-badstride.html
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu:
- shard-tglb: [PASS][30] -> [DMESG-WARN][31] ([i915#1982]) +1 similar issue
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
- shard-kbl: [PASS][32] -> [INCOMPLETE][33] ([i915#155])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html
* igt@kms_psr@psr2_cursor_render:
- shard-iclb: [PASS][34] -> [SKIP][35] ([fdo#109441]) +1 similar issue
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-iclb6/igt@kms_psr@psr2_cursor_render.html
* igt@kms_setmode@basic:
- shard-apl: [PASS][36] -> [FAIL][37] ([i915#1635] / [i915#31])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-apl1/igt@kms_setmode@basic.html
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-apl7/igt@kms_setmode@basic.html
* igt@sw_sync@sync_expired_merge:
- shard-iclb: [PASS][38] -> [DMESG-WARN][39] ([i915#1982])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-iclb8/igt@sw_sync@sync_expired_merge.html
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-iclb2/igt@sw_sync@sync_expired_merge.html
#### Possible fixes ####
* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- shard-glk: [DMESG-WARN][40] ([i915#1982]) -> [PASS][41] +1 similar issue
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-glk3/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-glk5/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
- shard-kbl: [DMESG-WARN][42] ([i915#180]) -> [PASS][43]
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
- shard-hsw: [FAIL][44] ([i915#96]) -> [PASS][45]
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html
* igt@kms_flip@flip-vs-suspend@c-hdmi-a1:
- shard-hsw: [INCOMPLETE][46] ([i915#2055]) -> [PASS][47]
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-hsw1/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-hsw6/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
- shard-snb: [INCOMPLETE][48] ([i915#82]) -> [PASS][49]
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-snb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-snb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
- shard-kbl: [DMESG-WARN][50] ([i915#1982]) -> [PASS][51] +1 similar issue
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu:
- shard-glk: [FAIL][52] ([i915#49]) -> [PASS][53]
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
- shard-tglb: [DMESG-WARN][54] ([i915#1982]) -> [PASS][55] +1 similar issue
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html
* igt@kms_psr@psr2_cursor_blt:
- shard-iclb: [SKIP][56] ([fdo#109441]) -> [PASS][57] +2 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-iclb7/igt@kms_psr@psr2_cursor_blt.html
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html
#### Warnings ####
* igt@i915_pm_rc6_residency@rc6-idle:
- shard-iclb: [FAIL][58] ([i915#1515]) -> [WARN][59] ([i915#1515])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html
* igt@kms_content_protection@lic:
- shard-apl: [FAIL][60] ([fdo#110321] / [i915#1635]) -> [TIMEOUT][61] ([i915#1319] / [i915#1635])
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-apl4/igt@kms_content_protection@lic.html
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-apl2/igt@kms_content_protection@lic.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110321]: https://bugs.freedesktop.org/show_bug.cgi?id=110321
[i915#1319]: https://gitlab.freedesktop.org/drm/intel/issues/1319
[i915#1515]: https://gitlab.freedesktop.org/drm/intel/issues/1515
[i915#155]: https://gitlab.freedesktop.org/drm/intel/issues/155
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888
[i915#1895]: https://gitlab.freedesktop.org/drm/intel/issues/1895
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055
[i915#2122]: https://gitlab.freedesktop.org/drm/intel/issues/2122
[i915#2370]: https://gitlab.freedesktop.org/drm/intel/issues/2370
[i915#2389]: https://gitlab.freedesktop.org/drm/intel/issues/2389
[i915#2521]: https://gitlab.freedesktop.org/drm/intel/issues/2521
[i915#2546]: https://gitlab.freedesktop.org/drm/intel/issues/2546
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#49]: https://gitlab.freedesktop.org/drm/intel/issues/49
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#82]: https://gitlab.freedesktop.org/drm/intel/issues/82
[i915#96]: https://gitlab.freedesktop.org/drm/intel/issues/96
Participating hosts (11 -> 8)
------------------------------
Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5823 -> IGTPW_5094
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_9191: 4b693bbb9b41fda404b5cd081bf5cd8dba240468 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5094: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/index.html
IGT_5823: 7dd2fe99bd9dde00456cc5abf7e5ef0c8d7d6118 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/index.html
[-- Attachment #1.2: Type: text/html, Size: 16753 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] ✗ Fi.CI.IGT: failure for tools/intel_gpu_top: Fix Device selection issues
2020-10-23 22:14 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-10-24 2:03 ` Siddiqui, Ayaz A
0 siblings, 0 replies; 9+ messages in thread
From: Siddiqui, Ayaz A @ 2020-10-24 2:03 UTC (permalink / raw)
To: igt-dev@lists.freedesktop.org; +Cc: Latvala, Petri
[-- Attachment #1.1: Type: text/plain, Size: 14161 bytes --]
Changes are in tools and will only impact intel_gpu_top.
So reported issue are false alarm.
Regards
-Ayaz
From: Patchwork <patchwork@emeril.freedesktop.org>
Sent: Saturday, October 24, 2020 3:44 AM
To: Siddiqui, Ayaz A <ayaz.siddiqui@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: ✗ Fi.CI.IGT: failure for tools/intel_gpu_top: Fix Device selection issues
Patch Details
Series:
tools/intel_gpu_top: Fix Device selection issues
URL:
https://patchwork.freedesktop.org/series/83015/
State:
Failure
Details:
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/index.html
CI Bug Log - changes from CI_DRM_9191_full -> IGTPW_5094_full
Summary
FAILURE
Serious unknown changes coming with IGTPW_5094_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in IGTPW_5094_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/index.html
Possible new issues
Here are the unknown changes that may have been introduced in IGTPW_5094_full:
IGT changes
Possible regressions
* igt@gem_ctx_persistence@engines-hostile@bcs0:
* shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-glk2/igt@gem_ctx_persistence@engines-hostile@bcs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-glk5/igt@gem_ctx_persistence@engines-hostile@bcs0.html>
* igt@gem_ctx_persistence@engines-hostile@rcs0:
* shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-tglb6/igt@gem_ctx_persistence@engines-hostile@rcs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-tglb7/igt@gem_ctx_persistence@engines-hostile@rcs0.html>
* igt@gem_exec_parallel@contexts@bcs0:
* shard-hsw: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-hsw7/igt@gem_exec_parallel@contexts@bcs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-hsw2/igt@gem_exec_parallel@contexts@bcs0.html>
Suppressed
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* {igt@core_hotunplug@hotrebind}:
* shard-hsw: NOTRUN -> WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-hsw2/igt@core_hotunplug@hotrebind.html>
* {igt@gem_exec_capture@pi@vecs0}:
* shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-tglb5/igt@gem_exec_capture@pi@vecs0.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-tglb6/igt@gem_exec_capture@pi@vecs0.html>
Known issues
Here are the changes found in IGTPW_5094_full that come from known issues:
IGT changes
Issues hit
* igt@gem_exec_parallel@contexts@vecs0:
* shard-hsw: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-hsw7/igt@gem_exec_parallel@contexts@vecs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-hsw2/igt@gem_exec_parallel@contexts@vecs0.html> (i915#1888<https://gitlab.freedesktop.org/drm/intel/issues/1888>) +2 similar issues
* igt@gem_exec_reloc@basic-many-active@vecs0:
* shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-glk4/igt@gem_exec_reloc@basic-many-active@vecs0.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-glk1/igt@gem_exec_reloc@basic-many-active@vecs0.html> (i915#2389<https://gitlab.freedesktop.org/drm/intel/issues/2389>) +2 similar issues
* igt@gem_exec_whisper@basic-contexts-forked:
* shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-iclb7/igt@gem_exec_whisper@basic-contexts-forked.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-iclb3/igt@gem_exec_whisper@basic-contexts-forked.html> (i915#1895<https://gitlab.freedesktop.org/drm/intel/issues/1895>)
* igt@gem_softpin@softpin:
* shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-glk6/igt@gem_softpin@softpin.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-glk2/igt@gem_softpin@softpin.html> (i915#1888<https://gitlab.freedesktop.org/drm/intel/issues/1888>)
* igt@gem_userptr_blits@coherency-unsync:
* shard-snb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-snb4/igt@gem_userptr_blits@coherency-unsync.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-snb7/igt@gem_userptr_blits@coherency-unsync.html> (i915#82<https://gitlab.freedesktop.org/drm/intel/issues/82>)
* igt@kms_cursor_legacy@cursor-vs-flip-toggle:
* shard-hsw: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-hsw4/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-hsw6/igt@kms_cursor_legacy@cursor-vs-flip-toggle.html> (i915#2370<https://gitlab.freedesktop.org/drm/intel/issues/2370>)
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1:
* shard-glk: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-glk6/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-glk4/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a1.html> (i915#79<https://gitlab.freedesktop.org/drm/intel/issues/79>)
* igt@kms_flip@plain-flip-ts-check-interruptible@c-dp1:
* shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-kbl4/igt@kms_flip@plain-flip-ts-check-interruptible@c-dp1.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-kbl1/igt@kms_flip@plain-flip-ts-check-interruptible@c-dp1.html> (i915#2122<https://gitlab.freedesktop.org/drm/intel/issues/2122>)
* igt@kms_frontbuffer_tracking@fbc-badstride:
* shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-kbl6/igt@kms_frontbuffer_tracking@fbc-badstride.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-badstride.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>)
* shard-snb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-snb2/igt@kms_frontbuffer_tracking@fbc-badstride.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-snb5/igt@kms_frontbuffer_tracking@fbc-badstride.html> (i915#2546<https://gitlab.freedesktop.org/drm/intel/issues/2546>)
* igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu:
* shard-tglb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-tglb1/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-tglb2/igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-mmap-cpu.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) +1 similar issue
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
* shard-kbl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html> -> INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes.html> (i915#155<https://gitlab.freedesktop.org/drm/intel/issues/155>)
* igt@kms_psr@psr2_cursor_render:
* shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-iclb2/igt@kms_psr@psr2_cursor_render.html> -> SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-iclb6/igt@kms_psr@psr2_cursor_render.html> (fdo#109441<https://bugs.freedesktop.org/show_bug.cgi?id=109441>) +1 similar issue
* igt@kms_setmode@basic:
* shard-apl: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-apl1/igt@kms_setmode@basic.html> -> FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-apl7/igt@kms_setmode@basic.html> (i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635> / i915#31<https://gitlab.freedesktop.org/drm/intel/issues/31>)
* igt@sw_sync@sync_expired_merge:
* shard-iclb: PASS<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-iclb8/igt@sw_sync@sync_expired_merge.html> -> DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-iclb2/igt@sw_sync@sync_expired_merge.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>)
Possible fixes
* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
* shard-glk: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-glk3/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-glk5/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html> +1 similar issue
* igt@kms_cursor_crc@pipe-c-cursor-suspend:
* shard-kbl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-kbl6/igt@kms_cursor_crc@pipe-c-cursor-suspend.html> (i915#180<https://gitlab.freedesktop.org/drm/intel/issues/180>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-kbl7/igt@kms_cursor_crc@pipe-c-cursor-suspend.html>
* igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic:
* shard-hsw: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-hsw6/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html> (i915#96<https://gitlab.freedesktop.org/drm/intel/issues/96>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-hsw4/igt@kms_cursor_legacy@2x-long-cursor-vs-flip-atomic.html>
* igt@kms_flip@flip-vs-suspend@c-hdmi-a1:
* shard-hsw: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-hsw1/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html> (i915#2055<https://gitlab.freedesktop.org/drm/intel/issues/2055>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-hsw6/igt@kms_flip@flip-vs-suspend@c-hdmi-a1.html>
* igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt:
* shard-snb: INCOMPLETE<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-snb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html> (i915#82<https://gitlab.freedesktop.org/drm/intel/issues/82>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-snb5/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-blt.html>
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu:
* shard-kbl: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-kbl4/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-cpu.html> +1 similar issue
* igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu:
* shard-glk: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-glk9/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu.html> (i915#49<https://gitlab.freedesktop.org/drm/intel/issues/49>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-glk3/igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu.html>
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt:
* shard-tglb: DMESG-WARN<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-tglb3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html> (i915#1982<https://gitlab.freedesktop.org/drm/intel/issues/1982>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-gtt.html> +1 similar issue
* igt@kms_psr@psr2_cursor_blt:
* shard-iclb: SKIP<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-iclb7/igt@kms_psr@psr2_cursor_blt.html> (fdo#109441<https://bugs.freedesktop.org/show_bug.cgi?id=109441>) -> PASS<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-iclb2/igt@kms_psr@psr2_cursor_blt.html> +2 similar issues
Warnings
* igt@i915_pm_rc6_residency@rc6-idle:
* shard-iclb: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-iclb5/igt@i915_pm_rc6_residency@rc6-idle.html> (i915#1515<https://gitlab.freedesktop.org/drm/intel/issues/1515>) -> WARN<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-iclb2/igt@i915_pm_rc6_residency@rc6-idle.html> (i915#1515<https://gitlab.freedesktop.org/drm/intel/issues/1515>)
* igt@kms_content_protection@lic:
* shard-apl: FAIL<https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_9191/shard-apl4/igt@kms_content_protection@lic.html> (fdo#110321<https://bugs.freedesktop.org/show_bug.cgi?id=110321> / i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635>) -> TIMEOUT<https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/shard-apl2/igt@kms_content_protection@lic.html> (i915#1319<https://gitlab.freedesktop.org/drm/intel/issues/1319> / i915#1635<https://gitlab.freedesktop.org/drm/intel/issues/1635>)
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
Participating hosts (11 -> 8)
Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7
Build changes
* CI: CI-20190529 -> None
* IGT: IGT_5823 -> IGTPW_5094
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_9191: 4b693bbb9b41fda404b5cd081bf5cd8dba240468 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_5094: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_5094/index.html
IGT_5823: 7dd2fe99bd9dde00456cc5abf7e5ef0c8d7d6118 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
[-- Attachment #1.2: Type: text/html, Size: 40739 bytes --]
[-- Attachment #2: Type: text/plain, Size: 154 bytes --]
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan:Add function to get pci subsystem of requested card
2020-10-23 17:51 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan:Add function to get pci subsystem of requested card Ayaz A Siddiqui
@ 2020-10-26 4:43 ` Zbigniew Kempczyński
0 siblings, 0 replies; 9+ messages in thread
From: Zbigniew Kempczyński @ 2020-10-26 4:43 UTC (permalink / raw)
To: Ayaz A Siddiqui; +Cc: igt-dev, Petri Latvala
On Fri, Oct 23, 2020 at 11:21:57PM +0530, Ayaz A Siddiqui wrote:
> intel_gpu_top requires card information and PCI_SLOT_NAME for dGPU.
> Only pci subsystem contains both information.
> In case of user filter is other than pci subsystem then we need card
> information of associated pci subsystem which is stored as parent of
> requested card if available.
>
> A new api has been added to cater intel_gpu_top requirement.
>
> Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Zbigniew Kempczynski <zbigniew.kempczynski@intel.com>
> Cc: Dixit Ashutosh <ashutosh.dixit@intel.com>
> ---
> lib/igt_device_scan.c | 55 ++++++++++++++++++++++++++++++++-----------
> lib/igt_device_scan.h | 2 ++
> tools/intel_gpu_top.c | 2 +-
> 3 files changed, 44 insertions(+), 15 deletions(-)
>
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index f4d43c733..55aa8159d 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -1237,18 +1237,9 @@ static bool igt_device_filter_apply(const char *fstr)
> return true;
> }
>
> -/**
> - * igt_device_card_match
> - * @filter: filter string
> - * @card: pointer to igt_device_card struct
> - *
> - * Function applies filter to match device from device array.
> - *
> - * Returns:
> - * false - no card pointer was passed or card wasn't matched,
> - * true - card matched and returned.
> - */
> -bool igt_device_card_match(const char *filter, struct igt_device_card *card)
> +
> +static bool __igt_device_card_match(const char *filter,
> + struct igt_device_card *card, bool request_pci_ss)
> {
> struct igt_device *dev = NULL;
>
> @@ -1266,10 +1257,46 @@ bool igt_device_card_match(const char *filter, struct igt_device_card *card)
>
> /* We take first one if more than one card matches filter */
> dev = igt_list_first_entry(&igt_devs.filtered, dev, link);
> + if (request_pci_ss && !is_pci_subsystem(dev) && dev->parent
> + && is_pci_subsystem(dev->parent))
> + __copy_dev_to_card(dev->parent, card);
> + else
> + __copy_dev_to_card(dev, card);
> + return true;
> +}
>
> - __copy_dev_to_card(dev, card);
> +/**
> + * igt_device_card_match
> + * @filter: filter string
> + * @card: pointer to igt_device_card struct
> + *
> + * Function applies filter to match device from device array.
> + *
> + * Returns:
> + * false - no card pointer was passed or card wasn't matched,
> + * true - card matched and returned.
> + */
> +bool igt_device_card_match(const char *filter, struct igt_device_card *card)
> +{
> + return __igt_device_card_match(filter, card, false);
> +}
>
> - return true;
> +/**
> + * igt_device_card_match_pci
> + * @filter: filter string
> + * @card: pointer to igt_device_card struct
> + *
> + * Function applies filter to match device from device array.
> + * Populate associated pci subsystem data if available.
> + *
> + * Returns:
> + * false - no card pointer was passed or card wasn't matched,
> + * true - card matched and returned.
> + */
> +bool igt_device_card_match_pci(const char *filter,
> + struct igt_device_card *card)
> +{
> + return __igt_device_card_match(filter, card, true);
> }
>
> /**
> diff --git a/lib/igt_device_scan.h b/lib/igt_device_scan.h
> index bd937d227..544e982c4 100644
> --- a/lib/igt_device_scan.h
> +++ b/lib/igt_device_scan.h
> @@ -68,6 +68,8 @@ const char *igt_device_filter_get(int num);
>
> /* Use filter to match the device and fill card structure */
> bool igt_device_card_match(const char *filter, struct igt_device_card *card);
> +bool igt_device_card_match_pci(const char *filter,
> + struct igt_device_card *card);
> bool igt_device_find_first_i915_discrete_card(struct igt_device_card *card);
> int igt_open_card(struct igt_device_card *card);
> int igt_open_render(struct igt_device_card *card);
> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
> index 79a936ffb..1b6c8633b 100644
> --- a/tools/intel_gpu_top.c
> +++ b/tools/intel_gpu_top.c
> @@ -1393,7 +1393,7 @@ int main(int argc, char **argv)
> }
>
> if (opt_device != NULL) {
> - ret = igt_device_card_match(opt_device, &card);
> + ret = igt_device_card_match_pci(opt_device, &card);
> if (!ret)
> fprintf(stderr, "Requested device %s not found!\n", opt_device);
> free(opt_device);
> --
> 2.26.2
>
LGTM:
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: Select intel as default vendor for intel_gpu_top
2020-10-23 17:51 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: Select intel as default vendor for intel_gpu_top Ayaz A Siddiqui
@ 2020-10-26 4:43 ` Zbigniew Kempczyński
0 siblings, 0 replies; 9+ messages in thread
From: Zbigniew Kempczyński @ 2020-10-26 4:43 UTC (permalink / raw)
To: Ayaz A Siddiqui; +Cc: igt-dev, Petri Latvala
On Fri, Oct 23, 2020 at 11:21:58PM +0530, Ayaz A Siddiqui wrote:
> intel_gpu_top is selecting first discrete device as default drm subsystem.
> In case of multi-gpu system if the first device is not intel gpu
> then it will lead to an error while running intel_gpu_top.
>
> Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Zbigniew Kempczynski <zbigniew.kempczynski@intel.com>
> Cc: Dixit Ashutosh <ashutosh.dixit@intel.com>
> ---
> lib/igt_device_scan.c | 40 ++++++++++++++++++++--------------------
> 1 file changed, 20 insertions(+), 20 deletions(-)
>
> diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
> index 55aa8159d..0967c6450 100644
> --- a/lib/igt_device_scan.c
> +++ b/lib/igt_device_scan.c
> @@ -426,6 +426,25 @@ static struct igt_device *igt_device_find(const char *subsystem,
> return NULL;
> }
>
> +static bool is_vendor_matched(struct igt_device *dev, const char *vendor)
> +{
> + const char *vendor_id;
> +
> + if (!dev->vendor || !vendor)
> + return false;
> +
> + /* First we compare vendor id, like 8086 */
> + if (!strcasecmp(dev->vendor, vendor))
> + return true;
> +
> + /* Likely we have vendor string instead of id */
> + vendor_id = get_pci_vendor_id_by_name(vendor);
> + if (!vendor_id)
> + return false;
> +
> + return !strcasecmp(dev->vendor, vendor_id);
> +}
> +
> static void
> __copy_dev_to_card(struct igt_device *dev, struct igt_device_card *card)
> {
> @@ -457,7 +476,7 @@ bool igt_device_find_first_i915_discrete_card(struct igt_device_card *card)
>
> igt_list_for_each_entry(dev, &igt_devs.all, link) {
>
> - if (!is_pci_subsystem(dev))
> + if (!is_pci_subsystem(dev) || !is_vendor_matched(dev, "intel"))
> continue;
>
> if ((strncmp(dev->pci_slot_name, INTEGRATED_I915_GPU_PCI_ID, PCI_SLOT_NAME_SIZE)) != 0) {
> @@ -893,25 +912,6 @@ static bool parse_filter(const char *fstr, struct filter *filter)
> return false;
> }
>
> -static bool is_vendor_matched(struct igt_device *dev, const char *vendor)
> -{
> - const char *vendor_id;
> -
> - if (!dev->vendor || !vendor)
> - return false;
> -
> - /* First we compare vendor id, like 8086 */
> - if (!strcasecmp(dev->vendor, vendor))
> - return true;
> -
> - /* Likely we have vendor string instead of id */
> - vendor_id = get_pci_vendor_id_by_name(vendor);
> - if (!vendor_id)
> - return false;
> -
> - return !strcasecmp(dev->vendor, vendor_id);
> -}
> -
> /* Filter which matches subsystem:/sys/... path.
> * Used as first filter in chain.
> */
> --
> 2.26.2
>
LGTM:
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [igt-dev] [PATCH i-g-t 0/2] tools/intel_gpu_top: Fix Device selection issues
2020-10-23 17:51 [igt-dev] [PATCH i-g-t 0/2] tools/intel_gpu_top: Fix Device selection issues Ayaz A Siddiqui
` (3 preceding siblings ...)
2020-10-23 22:14 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
@ 2020-10-26 8:44 ` Petri Latvala
4 siblings, 0 replies; 9+ messages in thread
From: Petri Latvala @ 2020-10-26 8:44 UTC (permalink / raw)
To: Ayaz A Siddiqui; +Cc: igt-dev
On Fri, Oct 23, 2020 at 11:21:56PM +0530, Ayaz A Siddiqui wrote:
> There was two issues identified during intel_gpu_top testing.
> 1. In case of multiple discrete GPU platform, if first card is not
> intel card then execution failed with error. To solve this issue a check for
> intel device (8086) is added during device selection.
> 2. Intel_gpu_top was failing to execute if device selection filter was other than
> “pci”. intel_gpu_top requires card information and PCI_SLOT_NAME for dGPU.
> Only pci subsystem contains both information.
> In case of user filter is other than pci subsystem then we need card
> information of associated pci subsystem which is stored as parent of
> requested card if available.
>
> Ayaz A Siddiqui (2):
> lib/igt_device_scan:Add function to get pci subsystem of requested
> card
> lib/igt_device_scan: Select intel as default vendor for intel_gpu_top
>
> lib/igt_device_scan.c | 95 +++++++++++++++++++++++++++----------------
> lib/igt_device_scan.h | 2 +
> tools/intel_gpu_top.c | 2 +-
> 3 files changed, 64 insertions(+), 35 deletions(-)
>
Merged, thanks.
--
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-10-26 8:44 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-23 17:51 [igt-dev] [PATCH i-g-t 0/2] tools/intel_gpu_top: Fix Device selection issues Ayaz A Siddiqui
2020-10-23 17:51 ` [igt-dev] [PATCH i-g-t 1/2] lib/igt_device_scan:Add function to get pci subsystem of requested card Ayaz A Siddiqui
2020-10-26 4:43 ` Zbigniew Kempczyński
2020-10-23 17:51 ` [igt-dev] [PATCH i-g-t 2/2] lib/igt_device_scan: Select intel as default vendor for intel_gpu_top Ayaz A Siddiqui
2020-10-26 4:43 ` Zbigniew Kempczyński
2020-10-23 18:40 ` [igt-dev] ✓ Fi.CI.BAT: success for tools/intel_gpu_top: Fix Device selection issues Patchwork
2020-10-23 22:14 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2020-10-24 2:03 ` Siddiqui, Ayaz A
2020-10-26 8:44 ` [igt-dev] [PATCH i-g-t 0/2] " Petri Latvala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox