Re: [PATCH] lib/amd: add memleak functions

[vitaly prosyak <vprosyak@amd.com>]

Hi Kamil,

Thanks for raising this question. Currently, only a single test uses the memleak feature. However, we are planning to add more. This effort requires careful selection, as we want to avoid unnecessary overhead or burden. Enabling the memleak configuration significantly slows down test execution—potentially increasing the duration by 2-3 times.

Additionally, we aim to reach internal consensus on which tests should have this feature enabled. We also want to avoid enabling both KASAN and memleak simultaneously. These considerations are the reason for the delay.

Thanks for your understanding!

Vitaly

On 2025-02-19 05:41, Kamil Konieczny wrote:
> Hi Vitaly,
> On 2025-02-18 at 06:43:41 -0500, vitaly.prosyak@amd.com wrote:
>> From: Vitaly Prosyak <vitaly.prosyak@amd.com>
>>
>> refactor memory leak functions and add
>> them to the library for reuse across different tests.
>>
>> Cc: Christian Koenig <christian.koenig@amd.com>
>> Cc: Alexander Deucher <alexander.deucher@amd.com>
>> Cc: Jesse Zhang <jesse.zhang@amd.com>
>> Cc: Harry Wentland <harry.wentland@amd.com>
>>
>> Signed-off-by: Vitaly Prosyak <vitaly.prosyak@amd.com>
>> ---
>>  lib/amdgpu/amd_mem_leak.c   | 112 ++++++++++++++++++++++++++++++++++++
>>  lib/amdgpu/amd_mem_leak.h   |  17 ++++++
>>  lib/meson.build             |   1 +
>>  tests/amdgpu/amd_mem_leak.c |  88 ++--------------------------
>>
> [...cut...]
>
> Why moving to library when there is only one user?
>
> Regards,
> Kamil
>