Re: [PATCH] lib/amd: add memleak functions

[Peter Senna Tschudin <peter.senna@linux.intel.com>]

On 27.02.2025 06:08, vitaly prosyak wrote:
[...]

Hi Vataly,

Thank you for your message.

> Hi Peter,
> 
> Thanks for the update! I really appreciate the effort you’ve put into making the approach more global and vendor-agnostic—great work!
> 
> It would be incredibly useful to have both --kmemleak options available (for the entire test list and individual tests).
> 
> Could you kindly provide guidance on how to add these options (-konce or -keach) to igt-runner? For example, how should I modify the following commands to include them?

The kmemleak patch has not been merged yet. If you'd like to try it before it
gets merged, you can find the patches here:

https://patchwork.freedesktop.org/series/143996/

Regarding the kmemleak integration, I apologize for any confusion in the
discussion. The intended usage is as follows:
 - Create a test list that includes only the tests you want kmemleak to
   scan.
 - Pass the -keach option to igt_runner.

> 
> sudo ./scripts/run-tests.sh -t -v /home/vprosyak/src/igt-gpu-tools/build/tests/amd/amd_basic

I'm assuming this script calls igt_runner. If so, please add -keach as an
additional command-line argument to igt_runner.

Once the patch is merged, this will enable igt_runner to generate a file
named kmemleak.txt in the results directory. The file will include entries
like:

 "kmemleaks found after running test@name"

to separate different scans within the same file.

Additionally, you can modify your test list to include only the tests you
want kmemleak to scan. This is where I unintentionally added noise to
the discussion.

Since you can create a custom test list and use it with -keach, there is
no need to extend the kmemleak library to support a separate test list.

> 
> or
> 
> sudo ./scripts/run-tests.sh -v -T /home/infra/igt/custom.testlist  
> 
> Thanks again for your great work and support!

Happy to help, let me know if you need anything else!

Peter

> 
> Vitaly
>> [...]