Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/intel/xe_vm: Correct stride to avoid address range collision
@ 2023-11-09  8:16 janga.rahul.kumar
  2023-11-09  8:58 ` Karolina Stolarek
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: janga.rahul.kumar @ 2023-11-09  8:16 UTC (permalink / raw)
  To: igt-dev, ramadevi.gandi, janga.rahul.kumar; +Cc: lucas.demarchi

From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>

For XE2, the minimum page size for both VRAM and system memory is only 4K.

Minimum page size was used as the address stride, which is 4K.
When attempting to bind a 4K range, consecutive VM BIND IOCTL calls
resulted in a range collision. Update stride based on bo size.

v2: Address review comments (Karolina)

Cc: Karolina Stolarek <karolina.stolarek@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
---
 tests/intel/xe_vm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c
index eeb49122a..f1ccd6c21 100644
--- a/tests/intel/xe_vm.c
+++ b/tests/intel/xe_vm.c
@@ -417,6 +417,9 @@ shared_pte_page(int fd, struct drm_xe_engine_class_instance *eci, int n_bo,
 	bo_size = ALIGN(bo_size + xe_cs_prefetch_size(fd),
 			xe_get_default_alignment(fd));
 
+	if (addr_stride <= bo_size)
+		addr_stride = addr_stride + bo_size;
+
 	for (i = 0; i < n_bo; ++i) {
 		bo[i] = xe_bo_create_flags(fd, vm, bo_size,
 					   visible_vram_if_possible(fd, eci->gt_id));
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/intel/xe_vm: Correct stride to avoid address range collision
@ 2023-11-07  8:30 janga.rahul.kumar
  2023-11-07 10:30 ` Karolina Stolarek
  0 siblings, 1 reply; 8+ messages in thread
From: janga.rahul.kumar @ 2023-11-07  8:30 UTC (permalink / raw)
  To: igt-dev, ramadevi.gandi, janga.rahul.kumar; +Cc: lucas.demarchi

From: Janga Rahul Kumar <janga.rahul.kumar@intel.com>

For XE2, the minimum page size for both VRAM and system memory is only 4K.

Minimum page size was used as the address stride, which is 4K.
When attempting to bind a 4K range, consecutive VM BIND IOCTL calls
resulted in a range collision. Update stride based on bo size.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
---
 tests/intel/xe_vm.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tests/intel/xe_vm.c b/tests/intel/xe_vm.c
index dd3302337..2aead9427 100644
--- a/tests/intel/xe_vm.c
+++ b/tests/intel/xe_vm.c
@@ -377,6 +377,10 @@ shared_pte_page(int fd, struct drm_xe_engine_class_instance *eci, int n_bo,
 	bo_size = ALIGN(bo_size + xe_cs_prefetch_size(fd),
 			xe_get_default_alignment(fd));
 
+	if (addr_stride <= bo_size) {
+		addr_stride = addr_stride + bo_size;
+	}
+
 	for (i = 0; i < n_bo; ++i) {
 		bo[i] = xe_bo_create_flags(fd, vm, bo_size,
 					   visible_vram_if_possible(fd, eci->gt_id));
-- 
2.25.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-11-09 17:26 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-09  8:16 [igt-dev] [PATCH i-g-t] tests/intel/xe_vm: Correct stride to avoid address range collision janga.rahul.kumar
2023-11-09  8:58 ` Karolina Stolarek
2023-11-09  8:59 ` [igt-dev] ✓ CI.xeBAT: success for tests/intel/xe_vm: Correct stride to avoid address range collision (rev2) Patchwork
2023-11-09  9:04 ` [igt-dev] ✓ Fi.CI.BAT: " Patchwork
2023-11-09 17:26 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2023-11-07  8:30 [igt-dev] [PATCH i-g-t] tests/intel/xe_vm: Correct stride to avoid address range collision janga.rahul.kumar
2023-11-07 10:30 ` Karolina Stolarek
2023-11-09  8:15   ` Kumar, Janga Rahul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox