* [igt-dev] [PATCH i-g-t] overlay: Believe in 0MHz
@ 2019-11-28 18:04 Chris Wilson
2019-11-28 18:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-11-29 11:37 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2019-11-28 18:04 UTC (permalink / raw)
To: intel-gfx; +Cc: igt-dev
Tvrtko proposed reporting 0MHz when idle, but the overlay didn't believe
that would be possible and stripped from its graphs!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
overlay/overlay.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/overlay/overlay.c b/overlay/overlay.c
index dd4fca29e..77302181c 100644
--- a/overlay/overlay.c
+++ b/overlay/overlay.c
@@ -599,10 +599,8 @@ static void show_gpu_freq(struct overlay_context *ctx, struct overlay_gpu_freq *
}
if (has_freq) {
- if (gf->gpu_freq.current)
- chart_add_sample(&gf->current, gf->gpu_freq.current);
- if (gf->gpu_freq.request)
- chart_add_sample(&gf->request, gf->gpu_freq.request);
+ chart_add_sample(&gf->current, gf->gpu_freq.current);
+ chart_add_sample(&gf->request, gf->gpu_freq.request);
chart_draw(&gf->request, ctx->cr);
chart_draw(&gf->current, ctx->cr);
@@ -647,9 +645,8 @@ static void show_gpu_freq(struct overlay_context *ctx, struct overlay_gpu_freq *
cairo_text_extents_t extents;
len = sprintf(buf, "Frequency: %dMHz", gf->gpu_freq.current);
- if (gf->gpu_freq.request)
cairo_set_source_rgba(ctx->cr, 1, 1, 1, 1);
- sprintf(buf + len, " (requested %dMHz)", gf->gpu_freq.request);
+ sprintf(buf + len, " (requested %dMHz)", gf->gpu_freq.request);
cairo_move_to(ctx->cr, PAD, y);
cairo_show_text(ctx->cr, buf);
y += 12;
--
2.24.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 3+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for overlay: Believe in 0MHz
2019-11-28 18:04 [igt-dev] [PATCH i-g-t] overlay: Believe in 0MHz Chris Wilson
@ 2019-11-28 18:52 ` Patchwork
2019-11-29 11:37 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2019-11-28 18:52 UTC (permalink / raw)
To: Chris Wilson; +Cc: igt-dev
== Series Details ==
Series: overlay: Believe in 0MHz
URL : https://patchwork.freedesktop.org/series/70173/
State : success
== Summary ==
CI Bug Log - changes from IGT_5315 -> IGTPW_3780
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3780/index.html
Known issues
------------
Here are the changes found in IGTPW_3780 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_pm_rpm@module-reload:
- fi-skl-6770hq: [PASS][1] -> [FAIL][2] ([fdo#108511])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5315/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3780/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
#### Possible fixes ####
* igt@gem_exec_create@basic:
- {fi-tgl-u}: [INCOMPLETE][3] ([fdo#111736]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5315/fi-tgl-u/igt@gem_exec_create@basic.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3780/fi-tgl-u/igt@gem_exec_create@basic.html
* igt@i915_pm_rpm@basic-pci-d3-state:
- fi-icl-dsi: [INCOMPLETE][5] ([fdo#107713] / [fdo#108840]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5315/fi-icl-dsi/igt@i915_pm_rpm@basic-pci-d3-state.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3780/fi-icl-dsi/igt@i915_pm_rpm@basic-pci-d3-state.html
* igt@i915_selftest@live_gem_contexts:
- fi-skl-lmem: [INCOMPLETE][7] ([fdo#111700]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5315/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3780/fi-skl-lmem/igt@i915_selftest@live_gem_contexts.html
#### Warnings ####
* igt@i915_module_load@reload-with-fault-injection:
- fi-icl-u2: [DMESG-WARN][9] ([fdo#110595]) -> [INCOMPLETE][10] ([fdo#107713])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5315/fi-icl-u2/igt@i915_module_load@reload-with-fault-injection.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3780/fi-icl-u2/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_flip@basic-flip-vs-dpms:
- fi-kbl-x1275: [DMESG-WARN][11] ([fdo#103558] / [fdo#105602]) -> [DMESG-WARN][12] ([fdo#103558] / [fdo#105602] / [fdo#105763]) +1 similar issue
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5315/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-dpms.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3780/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-dpms.html
* igt@kms_flip@basic-flip-vs-modeset:
- fi-kbl-x1275: [DMESG-WARN][13] ([fdo#103558] / [fdo#105602] / [fdo#105763]) -> [DMESG-WARN][14] ([fdo#103558] / [fdo#105602]) +8 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_5315/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3780/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
[fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
[fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
[fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
[fdo#109964]: https://bugs.freedesktop.org/show_bug.cgi?id=109964
[fdo#110595]: https://bugs.freedesktop.org/show_bug.cgi?id=110595
[fdo#111700]: https://bugs.freedesktop.org/show_bug.cgi?id=111700
[fdo#111736]: https://bugs.freedesktop.org/show_bug.cgi?id=111736
[fdo#112298]: https://bugs.freedesktop.org/show_bug.cgi?id=112298
Participating hosts (52 -> 44)
------------------------------
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-kbl-7500u fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* CI: CI-20190529 -> None
* IGT: IGT_5315 -> IGTPW_3780
CI-20190529: 20190529
CI_DRM_7438: 8a2661592e79e48bcba9c24565b2b16edafbcbaa @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_3780: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3780/index.html
IGT_5315: 58705eb1bd29414244f4d0cfa08a9f0ce42d6545 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_3780/index.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [igt-dev] [PATCH i-g-t] overlay: Believe in 0MHz
2019-11-28 18:04 [igt-dev] [PATCH i-g-t] overlay: Believe in 0MHz Chris Wilson
2019-11-28 18:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2019-11-29 11:37 ` Tvrtko Ursulin
1 sibling, 0 replies; 3+ messages in thread
From: Tvrtko Ursulin @ 2019-11-29 11:37 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: igt-dev
On 28/11/2019 18:04, Chris Wilson wrote:
> Tvrtko proposed reporting 0MHz when idle, but the overlay didn't believe
> that would be possible and stripped from its graphs!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> overlay/overlay.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/overlay/overlay.c b/overlay/overlay.c
> index dd4fca29e..77302181c 100644
> --- a/overlay/overlay.c
> +++ b/overlay/overlay.c
> @@ -599,10 +599,8 @@ static void show_gpu_freq(struct overlay_context *ctx, struct overlay_gpu_freq *
> }
>
> if (has_freq) {
> - if (gf->gpu_freq.current)
> - chart_add_sample(&gf->current, gf->gpu_freq.current);
> - if (gf->gpu_freq.request)
> - chart_add_sample(&gf->request, gf->gpu_freq.request);
> + chart_add_sample(&gf->current, gf->gpu_freq.current);
> + chart_add_sample(&gf->request, gf->gpu_freq.request);
>
> chart_draw(&gf->request, ctx->cr);
> chart_draw(&gf->current, ctx->cr);
> @@ -647,9 +645,8 @@ static void show_gpu_freq(struct overlay_context *ctx, struct overlay_gpu_freq *
> cairo_text_extents_t extents;
>
> len = sprintf(buf, "Frequency: %dMHz", gf->gpu_freq.current);
> - if (gf->gpu_freq.request)
> cairo_set_source_rgba(ctx->cr, 1, 1, 1, 1);
> - sprintf(buf + len, " (requested %dMHz)", gf->gpu_freq.request);
> + sprintf(buf + len, " (requested %dMHz)", gf->gpu_freq.request);
> cairo_move_to(ctx->cr, PAD, y);
> cairo_show_text(ctx->cr, buf);
> y += 12;
>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
For if/when we decide to go with it. You made me a little bit unsure
with the sysfs angle although from the other hand I don't see that it is
useful to report non-zero while idle.
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-29 11:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-28 18:04 [igt-dev] [PATCH i-g-t] overlay: Believe in 0MHz Chris Wilson
2019-11-28 18:52 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-11-29 11:37 ` [igt-dev] [PATCH i-g-t] " Tvrtko Ursulin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox