Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Rob Clark <robdclark@gmail.com>, igt-dev@lists.freedesktop.org
Cc: Rob Clark <robdclark@chromium.org>
Subject: Re: [igt-dev] [PATCH 1/2] tests/kms_plane: Handle hw without legacy gamma support
Date: Tue, 8 Aug 2023 10:51:19 +0300	[thread overview]
Message-ID: <95ae5549-8e22-3feb-51f2-0f1936970a4a@gmail.com> (raw)
In-Reply-To: <20230807201245.214280-1-robdclark@gmail.com>

Those ci reported issues are not relating to these changes.

On 7.8.2023 23.12, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
> 
> Skip the tests which require legacy gamma, instead of failing, if the hw
> does not support legacy gamma.
> 
> v2: igt_require(lut_size > 0) instead
> v3: simplify patch

I think this description need to be adjusted a bit to reflect current 
change. With this description fixed these two patches are

Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>

> 
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
>   tests/kms_plane.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index 67cff61d6cd1..a444cdca23e2 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -469,6 +469,10 @@ static void set_legacy_lut(data_t *data, enum pipe pipe,
>   	lut_size = crtc->gamma_size;
>   	drmModeFreeCrtc(crtc);
>   
> +	/* Skip if legacy LUT is not supported: */
> +	if (!lut_size)
> +		return;
> +
>   	lut = malloc(sizeof(uint16_t) * lut_size);
>   
>   	for (i = 0; i < lut_size; i++)

  parent reply	other threads:[~2023-08-08  7:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07 20:12 [igt-dev] [PATCH 1/2] tests/kms_plane: Handle hw without legacy gamma support Rob Clark
2023-08-07 20:12 ` [igt-dev] [PATCH 2/2] tests/kms_plane: Skip QCOM_COMPRESSED Rob Clark
2023-08-08  0:52 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [1/2] tests/kms_plane: Handle hw without legacy gamma support Patchwork
2023-08-08  0:55 ` [igt-dev] ○ CI.xeBAT: info " Patchwork
2023-08-08  7:18 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2023-08-08  7:51 ` Juha-Pekka Heikkila [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-08-08 14:53 [igt-dev] [PATCH 1/2] " Rob Clark
2023-08-08 16:55 ` Abhinav Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95ae5549-8e22-3feb-51f2-0f1936970a4a@gmail.com \
    --to=juhapekka.heikkila@gmail.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=robdclark@chromium.org \
    --cc=robdclark@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox