From: Rob Clark <robdclark@gmail.com>
To: igt-dev@lists.freedesktop.org
Cc: Rob Clark <robdclark@chromium.org>
Subject: [igt-dev] [PATCH 1/2] tests/kms_plane: Handle hw without legacy gamma support
Date: Tue, 8 Aug 2023 07:53:33 -0700 [thread overview]
Message-ID: <20230808145334.24277-1-robdclark@gmail.com> (raw)
From: Rob Clark <robdclark@chromium.org>
Skip the legacy gamma on hw that doesn't support it, instead of failing.
The legacy LUT support was used to drop the precision down to 6 bits, to
paper over errors introduced y RGB<->YCbCr conversion, but this isn't
necessarily needed on all hw.
v2: igt_require(lut_size > 0) instead
v3: simplify patch
Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
tests/kms_plane.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index 67cff61d6cd1..a444cdca23e2 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -469,6 +469,10 @@ static void set_legacy_lut(data_t *data, enum pipe pipe,
lut_size = crtc->gamma_size;
drmModeFreeCrtc(crtc);
+ /* Skip if legacy LUT is not supported: */
+ if (!lut_size)
+ return;
+
lut = malloc(sizeof(uint16_t) * lut_size);
for (i = 0; i < lut_size; i++)
--
2.41.0
next reply other threads:[~2023-08-08 14:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 14:53 Rob Clark [this message]
2023-08-08 14:53 ` [igt-dev] [PATCH 2/2] tests/kms_plane: Skip QCOM_COMPRESSED Rob Clark
2023-08-08 15:18 ` Juha-Pekka Heikkila
2023-08-08 16:57 ` Abhinav Kumar
2023-08-08 15:58 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [1/2] tests/kms_plane: Handle hw without legacy gamma support Patchwork
2023-08-08 16:32 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-08 16:55 ` [igt-dev] [PATCH 1/2] " Abhinav Kumar
2023-08-08 20:32 ` [igt-dev] ○ CI.xeBAT: info for series starting with [1/2] " Patchwork
2023-08-09 1:49 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-08-07 20:12 [igt-dev] [PATCH 1/2] " Rob Clark
2023-08-08 7:51 ` Juha-Pekka Heikkila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808145334.24277-1-robdclark@gmail.com \
--to=robdclark@gmail.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=robdclark@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox