From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Rob Clark <robdclark@gmail.com>, <igt-dev@lists.freedesktop.org>
Cc: Rob Clark <robdclark@chromium.org>
Subject: Re: [igt-dev] [PATCH 2/2] tests/kms_plane: Skip QCOM_COMPRESSED
Date: Tue, 8 Aug 2023 09:57:21 -0700 [thread overview]
Message-ID: <c33b3960-4a45-3e97-6728-26eabc4f36ec@quicinc.com> (raw)
In-Reply-To: <20230808145334.24277-2-robdclark@gmail.com>
On 8/8/2023 7:53 AM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> We don't know how to generate valid compressed/UBWC data in igt, so
> don't try.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
Tested-by: Abhinav Kumar <quic_abhinavk@quicinc.com> # sc7280
> ---
> tests/kms_plane.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index a444cdca23e2..8e7dc75d349c 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -1011,6 +1011,11 @@ static bool test_format_plane(data_t *data, enum pipe pipe,
> f.modifier != DRM_FORMAT_MOD_LINEAR)
> continue;
>
> + /* igt doesn't know how to sw generate UBWC: */
> + if (is_msm_device(data->drm_fd) &&
> + f.modifier == DRM_FORMAT_MOD_QCOM_COMPRESSED)
> + continue;
> +
> if (f.format == ref.format &&
> f.modifier == ref.modifier)
> continue;
next prev parent reply other threads:[~2023-08-08 16:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 14:53 [igt-dev] [PATCH 1/2] tests/kms_plane: Handle hw without legacy gamma support Rob Clark
2023-08-08 14:53 ` [igt-dev] [PATCH 2/2] tests/kms_plane: Skip QCOM_COMPRESSED Rob Clark
2023-08-08 15:18 ` Juha-Pekka Heikkila
2023-08-08 16:57 ` Abhinav Kumar [this message]
2023-08-08 15:58 ` [igt-dev] ✗ GitLab.Pipeline: warning for series starting with [1/2] tests/kms_plane: Handle hw without legacy gamma support Patchwork
2023-08-08 16:32 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-08-08 16:55 ` [igt-dev] [PATCH 1/2] " Abhinav Kumar
2023-08-08 20:32 ` [igt-dev] ○ CI.xeBAT: info for series starting with [1/2] " Patchwork
2023-08-09 1:49 ` [igt-dev] ✓ Fi.CI.IGT: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-08-07 20:12 [igt-dev] [PATCH 1/2] " Rob Clark
2023-08-07 20:12 ` [igt-dev] [PATCH 2/2] tests/kms_plane: Skip QCOM_COMPRESSED Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c33b3960-4a45-3e97-6728-26eabc4f36ec@quicinc.com \
--to=quic_abhinavk@quicinc.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox