Re: [PATCH i-g-t] tools: rename HDMI compliance utility

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Vital

Can you please rb if everything looks good at your end?

On 28-08-2026 08:26 pm, vitaly prosyak wrote:
> On 2026-08-28 10:53, Zuo, Jerry wrote:
>> AMD General
>>
>>> -----Original Message-----
>>> From: Wentland, Harry <Harry.Wentland@amd.com>
>>> Sent: Friday, August 28, 2026 09:35
>>> To: Prosyak, Vitaly <Vitaly.Prosyak@amd.com>; Kamil Konieczny
>>> <kamil.konieczny@linux.intel.com>; Swati Sharma
>>> <swati2.sharma@intel.com>; igt-dev@lists.freedesktop.org;
>>> chaitanya.kumar.borah@intel.com; Zuo, Jerry <Jerry.Zuo@amd.com>;
>>> Broadworth, Mark <Mark.Broadworth@amd.com>; Prosyak, Vitaly
>>> <Vitaly.Prosyak@amd.com>; Hung, Alex <Alex.Hung@amd.com>
>>> Subject: Re: [PATCH i-g-t] tools: rename HDMI compliance utility
>>>
>>>
>>>
>>> On 2026-08-28 07:04, vitaly prosyak wrote:
>>>> Added Alex
>>>>
>>>> Hi Kamil
>>>>
>>>> On 2026-08-28 05:58, Kamil Konieczny wrote:
>>>>> Hi Swati,
>>>>> On 2026-08-28 at 00:23:55 +0530, Swati Sharma wrote:
>>>>>> Rename the AMD-specific HDMI compliance utility to a generic
>>>>>> igt_hdmi_compliance binary and update the build rule.
>>>>>>
>>>>>> Keep the existing AMD debugfs flow for pixel-format forcing. Skip
>>>>>> that operation on Intel devices until a driver-supported interface
>>>>>> for selecting the pixel encoding is available.
>>>>>>
>>>>>> Assisted-by: GitHub Copilot:Claude Opus 4.6
>>>>>> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
>>>>> I will forward this to few AMD GPU dev to make sure it will work for
>>>>> them, +cc Fangzhi Zuo <Jerry.Zuo@amd.com> Harry Wentland
>>>>> <harry.wentland@amd.com> Mark Broadworth
>>> <Mark.Broadworth@amd.com>
>>>>> Vitaly Prosyak <vitaly.prosyak@amd.com>
>>>>>
>>>>> Vitaly, can you forward this to your devs and/or CI team and help us
>>>>> here, please.
>>>>>
>>>> Added push for testing to our internal CI :
>>>>
>>>> https://gerrit.core.linux.amd.com/c/upstream/gitlab.freedesktop.org/dr
>>>> m/igt-gpu-tools/+/1951
>>>>
>>>> Hi Harry and Alex,
>>>> I hope you are both having a good week.
>>>> I am not entirely sure if the DAL CI is executing the new remote gerrit
>>> correctly. When you have a moment, could you please help me look into this?
>>>> Thank you so much for your time
>>> Not sure, but I think things in `tools` would require a manual run anyways.
>>>
>>> Jerry, can you have a look and review this change?
>>>
>>> Harry
>> We ran amd_hdmi_compliance from CLI. The only change is to replace with new name igt_hdmi_compliance with the same parameters (-e -y -b -t).
>>
>> Should be good.
>>
>> Regards,
>> Jerry
> Thanks a lot Jerry and Harry for fast responses!
>
> Vitaly
>
>>>> Vitaly
>>>>> Regards,
>>>>> Kamil
>>>>>
>>>>>> ---
>>>>>>   tools/{amd_hdmi_compliance.c => igt_hdmi_compliance.c} | 9 ++++++---
>>>>>>   tools/meson.build                                      | 2 +-
>>>>>>   2 files changed, 7 insertions(+), 4 deletions(-)  rename
>>>>>> tools/{amd_hdmi_compliance.c => igt_hdmi_compliance.c} (99%)
>>>>>>
>>>>>> diff --git a/tools/amd_hdmi_compliance.c
>>>>>> b/tools/igt_hdmi_compliance.c similarity index 99% rename from
>>>>>> tools/amd_hdmi_compliance.c rename to tools/igt_hdmi_compliance.c
>>>>>> index 2af4c0bab..ece0abd1d 100644
>>>>>> --- a/tools/amd_hdmi_compliance.c
>>>>>> +++ b/tools/igt_hdmi_compliance.c
>>>>>> @@ -833,12 +833,15 @@ static void force_pixel_format(data_t *data,
>>>>>> int pixel_format, int conn_id)
>>>>>>
>>>>>>    test_init(data, conn_id);
>>>>>>
>>>>>> - fd = igt_debugfs_connector_dir(data->fd, data->output->name,
>>> O_RDONLY);
>>>>>> - igt_assert(fd >= 0);
>>>>>> -
>>>>>>    igt_info("Setting %d on connector id %d\n",
>>>>>>                    pixel_format, data->output->config.connector-
>>>> connector_id);
>>>>>> + igt_skip_on_f(is_intel_device(data->fd),
>>>>>> +                       "pixel-format forcing is not supported on Intel
>>>>>> +devices\n");
>>>>>> +
>>>>>> + fd = igt_debugfs_connector_dir(data->fd, data->output->name,
>>> O_RDONLY);
>>>>>> + igt_assert(fd >= 0);
>>>>>> +
>>>>>>    switch (pixel_format) {
>>>>>>    case 1:
>>>>>>            entry_name = "force_rgb_output";
>>>>>> diff --git a/tools/meson.build b/tools/meson.build index
>>>>>> fbc6c0a00..68c31da92 100644
>>>>>> --- a/tools/meson.build
>>>>>> +++ b/tools/meson.build
>>>>>> @@ -183,7 +183,7 @@ executable('intel_gpu_top', 'intel_gpu_top.c',
>>>>>>       dependencies :
>>> [lib_igt_perf,lib_igt_device_scan,lib_igt_drm_clients,lib_igt_drm_fdinfo,
>>>>>>                       lib_igt_drm_stub, lib_igt_tools_stub, math])
>>>>>>
>>>>>> -executable('amd_hdmi_compliance', 'amd_hdmi_compliance.c',
>>>>>> +executable('igt_hdmi_compliance', 'igt_hdmi_compliance.c',
>>>>>>       dependencies : [tool_deps],
>>>>>>       install_rpath : bindir_rpathdir,
>>>>>>       install : true)
>>>>>> --
>>>>>> 2.25.1
>>>>>>