Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Harry Wentland <harry.wentland@amd.com>
To: Swati Sharma <swati2.sharma@intel.com>, igt-dev@lists.freedesktop.org
Cc: chaitanya.kumar.borah@intel.com
Subject: Re: [PATCH i-g-t] tools: rename HDMI compliance utility
Date: Tue, 1 Sep 2026 11:03:16 -0400	[thread overview]
Message-ID: <cd87af6c-9e84-455b-b6e5-7d27595fa17c@amd.com> (raw)
In-Reply-To: <20260827185355.378279-1-swati2.sharma@intel.com>



On 2026-08-27 14:53, Swati Sharma wrote:
> Rename the AMD-specific HDMI compliance utility to a generic
> igt_hdmi_compliance binary and update the build rule.
> 
> Keep the existing AMD debugfs flow for pixel-format forcing. Skip
> that operation on Intel devices until a driver-supported interface
> for selecting the pixel encoding is available.
> 
> Assisted-by: GitHub Copilot:Claude Opus 4.6
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  tools/{amd_hdmi_compliance.c => igt_hdmi_compliance.c} | 9 ++++++---
>  tools/meson.build                                      | 2 +-
>  2 files changed, 7 insertions(+), 4 deletions(-)
>  rename tools/{amd_hdmi_compliance.c => igt_hdmi_compliance.c} (99%)
> 
> diff --git a/tools/amd_hdmi_compliance.c b/tools/igt_hdmi_compliance.c
> similarity index 99%
> rename from tools/amd_hdmi_compliance.c
> rename to tools/igt_hdmi_compliance.c
> index 2af4c0bab..ece0abd1d 100644
> --- a/tools/amd_hdmi_compliance.c
> +++ b/tools/igt_hdmi_compliance.c
> @@ -833,12 +833,15 @@ static void force_pixel_format(data_t *data, int pixel_format, int conn_id)
>  
>  	test_init(data, conn_id);
>  
> -	fd = igt_debugfs_connector_dir(data->fd, data->output->name, O_RDONLY);
> -	igt_assert(fd >= 0);
> -
>  	igt_info("Setting %d on connector id %d\n",
>  			pixel_format, data->output->config.connector->connector_id);
>  
> +	igt_skip_on_f(is_intel_device(data->fd),
> +			      "pixel-format forcing is not supported on Intel devices\n");
> +
> +	fd = igt_debugfs_connector_dir(data->fd, data->output->name, O_RDONLY);
> +	igt_assert(fd >= 0);
> +
>  	switch (pixel_format) {
>  	case 1:
>  		entry_name = "force_rgb_output";
> diff --git a/tools/meson.build b/tools/meson.build
> index fbc6c0a00..68c31da92 100644
> --- a/tools/meson.build
> +++ b/tools/meson.build
> @@ -183,7 +183,7 @@ executable('intel_gpu_top', 'intel_gpu_top.c',
>  	   dependencies : [lib_igt_perf,lib_igt_device_scan,lib_igt_drm_clients,lib_igt_drm_fdinfo,
>  	                   lib_igt_drm_stub, lib_igt_tools_stub, math])
>  
> -executable('amd_hdmi_compliance', 'amd_hdmi_compliance.c',
> +executable('igt_hdmi_compliance', 'igt_hdmi_compliance.c',
>  	   dependencies : [tool_deps],
>  	   install_rpath : bindir_rpathdir,
>  	   install : true)


      parent reply	other threads:[~2026-09-01 15:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-27 18:53 [PATCH i-g-t] tools: rename HDMI compliance utility Swati Sharma
2026-08-27 21:13 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-08-27 21:26 ` ✓ i915.CI.BAT: " Patchwork
2026-08-27 23:17 ` ✓ Xe.CI.FULL: " Patchwork
2026-08-28  3:23 ` ✗ i915.CI.Full: failure " Patchwork
2026-08-28  9:58 ` [PATCH i-g-t] " Kamil Konieczny
2026-08-28 11:04   ` vitaly prosyak
2026-08-28 13:35     ` Harry Wentland
2026-08-28 14:53       ` Zuo, Jerry
2026-08-28 14:56         ` vitaly prosyak
2026-09-01  8:43           ` Sharma, Swati2
2026-09-01 15:13             ` vitaly prosyak
2026-09-01 16:41               ` Kamil Konieczny
2026-09-01 15:03 ` Harry Wentland [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd87af6c-9e84-455b-b6e5-7d27595fa17c@amd.com \
    --to=harry.wentland@amd.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox