[igt-dev] [PATCH i-g-t] lib: Add Cometlake platform definition

[igt-dev] [PATCH i-g-t] lib: Add Cometlake platform definition

[Petri Latvala]

Commit a794f28f01f2 ("lib: sync with the newer i915_pciids.h from the
Kernel") added CML PCI IDs but did not update intel_device_info.c

Signed-off-by: Petri Latvala <petri.latvala@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110514
Cc: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: José Roberto de Souza <jose.souza@intel.com>
---
 lib/intel_chipset.h     |  1 +
 lib/intel_device_info.c | 18 ++++++++++++++++++
 2 files changed, 19 insertions(+)

diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
index 40170b7b..7fc9bd77 100644
--- a/lib/intel_chipset.h
+++ b/lib/intel_chipset.h
@@ -66,6 +66,7 @@ struct intel_device_info {
 	bool is_kabylake : 1;
 	bool is_geminilake : 1;
 	bool is_coffeelake : 1;
+	bool is_cometlake : 1;
 	bool is_cannonlake : 1;
 	bool is_icelake : 1;
 	const char *codename;
diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
index 2bca5183..3f51211f 100644
--- a/lib/intel_device_info.c
+++ b/lib/intel_device_info.c
@@ -277,6 +277,21 @@ static const struct intel_device_info intel_coffeelake_gt3_info = {
 	.gt = 3,
 };
 
+#define COMETLAKE_FIELDS \
+	.gen = BIT(8), \
+	.is_cometlake = true, \
+	.codename = "cometlake"
+
+static const struct intel_device_info intel_cometlake_gt1_info = {
+	COMETLAKE_FIELDS,
+	.gt = 1,
+};
+
+static const struct intel_device_info intel_cometlake_gt2_info = {
+	COMETLAKE_FIELDS,
+	.gt = 2,
+};
+
 static const struct intel_device_info intel_cannonlake_info = {
 	.gen = BIT(9),
 	.is_cannonlake = true,
@@ -360,6 +375,9 @@ static const struct pci_id_match intel_device_match[] = {
 	INTEL_WHL_U_GT3_IDS(&intel_coffeelake_gt3_info),
 	INTEL_AML_CFL_GT2_IDS(&intel_coffeelake_gt2_info),
 
+	INTEL_CML_GT1_IDS(&intel_cometlake_gt1_info),
+	INTEL_CML_GT2_IDS(&intel_cometlake_gt2_info),
+
 	INTEL_CNL_IDS(&intel_cannonlake_info),
 
 	INTEL_ICL_11_IDS(&intel_icelake_info),
-- 
2.19.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib: Add Cometlake platform definition

[Patchwork]

== Series Details ==

Series: lib: Add Cometlake platform definition
URL   : https://patchwork.freedesktop.org/series/59940/
State : success

== Summary ==

CI Bug Log - changes from IGT_4966 -> IGTPW_2919
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59940/revisions/1/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2919:

### IGT changes ###

#### Suppressed ####

  The following results come from untrusted machines, tests, or statuses.
  They do not affect the overall result.

  * igt@gem_exec_basic@basic-bsd1:
    - {fi-cml-u}:         NOTRUN -> [SKIP][1] +10 similar issues
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/fi-cml-u/igt@gem_exec_basic@basic-bsd1.html

  * igt@gem_workarounds@basic-read:
    - {fi-cml-u}:         NOTRUN -> [FAIL][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/fi-cml-u/igt@gem_workarounds@basic-read.html

  * igt@kms_chamelium@dp-edid-read:
    - {fi-icl-u2}:        NOTRUN -> [FAIL][3] +3 similar issues
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/fi-icl-u2/igt@kms_chamelium@dp-edid-read.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).



Participating hosts (28 -> 41)
------------------------------

  Additional (18): fi-byt-j1900 fi-skl-6770hq fi-skl-guc fi-icl-u2 fi-skl-6260u fi-apl-guc fi-snb-2520m fi-bwr-2160 fi-kbl-guc fi-whl-u fi-kbl-x1275 fi-bxt-j4205 fi-icl-y fi-byt-n2820 fi-byt-clapper fi-kbl-r fi-skl-6700k2 fi-cml-u 
  Missing    (5): fi-kbl-soraka fi-ilk-m540 fi-byt-squawks fi-gdg-551 fi-bdw-samus 


Build changes
-------------

  * IGT: IGT_4966 -> IGTPW_2919

  CI_DRM_5999: bde6790dd103ba3c4c127bbc061b90ea3f406762 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2919: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/
  IGT_4966: a75429544f5721316b04a36551c57573e0c79486 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib: Add Cometlake platform definition

[Antonio Argenziano]

On 25/04/19 06:00, Petri Latvala wrote:
> Commit a794f28f01f2 ("lib: sync with the newer i915_pciids.h from the
> Kernel") added CML PCI IDs but did not update intel_device_info.c

LGTM,

Acked-by: Antonio Argenziano <antonio.argenziano@intel.com>

> 
> Signed-off-by: Petri Latvala <petri.latvala@intel.com>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110514
> Cc: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: José Roberto de Souza <jose.souza@intel.com>
> ---
>   lib/intel_chipset.h     |  1 +
>   lib/intel_device_info.c | 18 ++++++++++++++++++
>   2 files changed, 19 insertions(+)
> 
> diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> index 40170b7b..7fc9bd77 100644
> --- a/lib/intel_chipset.h
> +++ b/lib/intel_chipset.h
> @@ -66,6 +66,7 @@ struct intel_device_info {
>   	bool is_kabylake : 1;
>   	bool is_geminilake : 1;
>   	bool is_coffeelake : 1;
> +	bool is_cometlake : 1;
>   	bool is_cannonlake : 1;
>   	bool is_icelake : 1;
>   	const char *codename;
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index 2bca5183..3f51211f 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -277,6 +277,21 @@ static const struct intel_device_info intel_coffeelake_gt3_info = {
>   	.gt = 3,
>   };
>   
> +#define COMETLAKE_FIELDS \
> +	.gen = BIT(8), \
> +	.is_cometlake = true, \
> +	.codename = "cometlake"
> +
> +static const struct intel_device_info intel_cometlake_gt1_info = {
> +	COMETLAKE_FIELDS,
> +	.gt = 1,
> +};
> +
> +static const struct intel_device_info intel_cometlake_gt2_info = {
> +	COMETLAKE_FIELDS,
> +	.gt = 2,
> +};
> +
>   static const struct intel_device_info intel_cannonlake_info = {
>   	.gen = BIT(9),
>   	.is_cannonlake = true,
> @@ -360,6 +375,9 @@ static const struct pci_id_match intel_device_match[] = {
>   	INTEL_WHL_U_GT3_IDS(&intel_coffeelake_gt3_info),
>   	INTEL_AML_CFL_GT2_IDS(&intel_coffeelake_gt2_info),
>   
> +	INTEL_CML_GT1_IDS(&intel_cometlake_gt1_info),
> +	INTEL_CML_GT2_IDS(&intel_cometlake_gt2_info),
> +
>   	INTEL_CNL_IDS(&intel_cannonlake_info),
>   
>   	INTEL_ICL_11_IDS(&intel_icelake_info),
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for lib: Add Cometlake platform definition

[Patchwork]

== Series Details ==

Series: lib: Add Cometlake platform definition
URL   : https://patchwork.freedesktop.org/series/59940/
State : success

== Summary ==

CI Bug Log - changes from IGT_4966_full -> IGTPW_2919_full
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/59940/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2919_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_tiled_swapping@non-threaded:
    - shard-glk:          [PASS][1] -> [DMESG-WARN][2] ([fdo#108686])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-glk6/igt@gem_tiled_swapping@non-threaded.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-glk7/igt@gem_tiled_swapping@non-threaded.html

  * igt@kms_cursor_crc@cursor-128x128-onscreen:
    - shard-kbl:          [PASS][3] -> [FAIL][4] ([fdo#103232]) +1 similar issue
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-kbl2/igt@kms_cursor_crc@cursor-128x128-onscreen.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-kbl3/igt@kms_cursor_crc@cursor-128x128-onscreen.html

  * igt@kms_cursor_crc@cursor-128x128-random:
    - shard-apl:          [PASS][5] -> [FAIL][6] ([fdo#103232]) +1 similar issue
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-apl2/igt@kms_cursor_crc@cursor-128x128-random.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-apl6/igt@kms_cursor_crc@cursor-128x128-random.html

  * igt@kms_dp_dsc@basic-dsc-enable-edp:
    - shard-iclb:         [PASS][7] -> [SKIP][8] ([fdo#109349])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-iclb1/igt@kms_dp_dsc@basic-dsc-enable-edp.html

  * igt@kms_flip@flip-vs-suspend-interruptible:
    - shard-kbl:          [PASS][9] -> [DMESG-WARN][10] ([fdo#108566])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-kbl1/igt@kms_flip@flip-vs-suspend-interruptible.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible.html

  * igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
    - shard-iclb:         [PASS][11] -> [FAIL][12] ([fdo#103167]) +5 similar issues
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html

  * igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
    - shard-glk:          [PASS][13] -> [FAIL][14] ([fdo#103167])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-glk7/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-glk1/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
    - shard-apl:          [PASS][15] -> [FAIL][16] ([fdo#103167])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-apl5/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-apl5/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
    - shard-kbl:          [PASS][17] -> [FAIL][18] ([fdo#103167])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary.html

  * igt@kms_plane_lowres@pipe-a-tiling-x:
    - shard-iclb:         [PASS][19] -> [FAIL][20] ([fdo#103166])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-iclb7/igt@kms_plane_lowres@pipe-a-tiling-x.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-x.html

  * igt@kms_psr@psr2_cursor_render:
    - shard-iclb:         [PASS][21] -> [SKIP][22] ([fdo#109441]) +3 similar issues
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-iclb2/igt@kms_psr@psr2_cursor_render.html
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-iclb1/igt@kms_psr@psr2_cursor_render.html

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-kbl:          [PASS][23] -> [FAIL][24] ([fdo#109016])
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-kbl1/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-kbl5/igt@kms_rotation_crc@multiplane-rotation-cropping-top.html

  * igt@kms_vblank@pipe-c-ts-continuation-suspend:
    - shard-apl:          [PASS][25] -> [DMESG-WARN][26] ([fdo#108566]) +5 similar issues
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-apl1/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-apl7/igt@kms_vblank@pipe-c-ts-continuation-suspend.html

  
#### Possible fixes ####

  * igt@gem_workarounds@suspend-resume:
    - shard-apl:          [DMESG-WARN][27] ([fdo#108566]) -> [PASS][28] +4 similar issues
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-apl8/igt@gem_workarounds@suspend-resume.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-apl5/igt@gem_workarounds@suspend-resume.html

  * igt@kms_cursor_legacy@all-pipes-torture-bo:
    - shard-hsw:          [INCOMPLETE][29] ([fdo#103540]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-hsw7/igt@kms_cursor_legacy@all-pipes-torture-bo.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-hsw5/igt@kms_cursor_legacy@all-pipes-torture-bo.html

  * igt@kms_flip@flip-vs-suspend:
    - shard-kbl:          [DMESG-WARN][31] ([fdo#108566]) -> [PASS][32] +2 similar issues
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-kbl6/igt@kms_flip@flip-vs-suspend.html
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-kbl1/igt@kms_flip@flip-vs-suspend.html

  * igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render:
    - shard-iclb:         [FAIL][33] ([fdo#103167]) -> [PASS][34] +8 similar issues
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-iclb1/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-render.html

  * igt@kms_plane_scaling@pipe-b-scaler-with-rotation:
    - shard-glk:          [SKIP][35] ([fdo#109271] / [fdo#109278]) -> [PASS][36] +1 similar issue
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-glk2/igt@kms_plane_scaling@pipe-b-scaler-with-rotation.html
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-glk9/igt@kms_plane_scaling@pipe-b-scaler-with-rotation.html

  * igt@kms_psr@psr2_primary_mmap_cpu:
    - shard-iclb:         [SKIP][37] ([fdo#109441]) -> [PASS][38] +2 similar issues
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-iclb7/igt@kms_psr@psr2_primary_mmap_cpu.html
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-iclb2/igt@kms_psr@psr2_primary_mmap_cpu.html

  * igt@kms_rotation_crc@multiplane-rotation:
    - shard-kbl:          [INCOMPLETE][39] ([fdo#103665]) -> [PASS][40]
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-kbl7/igt@kms_rotation_crc@multiplane-rotation.html
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-kbl1/igt@kms_rotation_crc@multiplane-rotation.html

  
#### Warnings ####

  * igt@i915_pm_rpm@i2c:
    - shard-iclb:         [DMESG-FAIL][41] ([fdo#110271]) -> [FAIL][42] ([fdo#104097])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/IGT_4966/shard-iclb2/igt@i915_pm_rpm@i2c.html
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/shard-iclb1/igt@i915_pm_rpm@i2c.html

  
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103540]: https://bugs.freedesktop.org/show_bug.cgi?id=103540
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
  [fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
  [fdo#108686]: https://bugs.freedesktop.org/show_bug.cgi?id=108686
  [fdo#109016]: https://bugs.freedesktop.org/show_bug.cgi?id=109016
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
  [fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
  [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
  [fdo#110271]: https://bugs.freedesktop.org/show_bug.cgi?id=110271


Participating hosts (7 -> 6)
------------------------------

  Missing    (1): shard-skl 


Build changes
-------------

  * IGT: IGT_4966 -> IGTPW_2919

  CI_DRM_5999: bde6790dd103ba3c4c127bbc061b90ea3f406762 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2919: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/
  IGT_4966: a75429544f5721316b04a36551c57573e0c79486 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2919/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev