Re: [i-g-t,1/2] lib/igt_kms: Added library functions for LOBF status

["Joshi, Kunal1" <kunal1.joshi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2108 bytes --]

Hello Jeevan

On 7/22/2024 1:20 PM, Jeevan B wrote:
> Added helper functions to check LOBF status to check weather
> it is enabled or disabled.
>
> v2: rename function name.
>
> Signed-off-by: Jeevan B<jeevan.b@intel.com>
> ---
>   lib/igt_kms.c | 23 +++++++++++++++++++++++
>   lib/igt_kms.h |  1 +
>   2 files changed, 24 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 64318ef7f..e030b35a6 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -6071,6 +6071,29 @@ void igt_dump_crtcs_fd(int drmfd)
>   	drmModeFreeResources(mode_resources);
>   }
>   
> +/**
> + * igt_get_i915_edp_lobf_status
> + * @drmfd: A drm file descriptor
> + * @connector_name: Name of the libdrm connector we're going to use
> + *
> + * Return: True if its enabled.
> + */
> +bool igt_get_i915_edp_lobf_status(int drmfd, char *connector_name)
> +{
> +	char buf[24];
> +	int fd, res;
> +
> +	fd = igt_debugfs_connector_dir(drmfd, connector_name, O_RDONLY);
> +	igt_assert(fd >= 0);

Do we have any constraints for i915_edp_lobf_inf, like platform etc etc? 
If so lets have has_i915_edp_lobf_infoso we can skip instead of asserting.

Apart from that, LGTM
Reviewed-by: Kunal Joshi <kunal1.joshi@intel.com>
> +
> +	res = igt_debugfs_simple_read(fd, "i915_edp_lobf_info", buf, sizeof(buf));
> +	igt_require(res > 0);
> +
> +	close(fd);
> +
> +	return strstr(buf, "LOBF status: enabled");
> +}
> +
>   /**
>    * igt_get_output_max_bpc:
>    * @drmfd: A drm file descriptor
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 501d48763..e8582a45b 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -1195,6 +1195,7 @@ void igt_require_pipe(igt_display_t *display,
>   void igt_dump_connectors_fd(int drmfd);
>   void igt_dump_crtcs_fd(int drmfd);
>   bool igt_override_all_active_output_modes_to_fit_bw(igt_display_t *display);
> +bool igt_get_i915_edp_lobf_status(int drmfd, char *connector_name);
>   unsigned int igt_get_output_max_bpc(int drmfd, char *connector_name);
>   unsigned int igt_get_pipe_current_bpc(int drmfd, enum pipe pipe);
>   void igt_assert_output_bpc_equal(int drmfd, enum pipe pipe,

[-- Attachment #2: Type: text/html, Size: 2706 bytes --]