Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Joshi, Kunal1" <kunal1.joshi@intel.com>
To: Jeevan B <jeevan.b@intel.com>, igt-dev@lists.freedesktop.org
Cc: animesh.manna@intel.com
Subject: Re: [i-g-t,1/2] lib/igt_kms: Added library functions for LOBF status
Date: Wed, 17 Jul 2024 10:15:29 +0530	[thread overview]
Message-ID: <b95d46cb-ef23-4ea7-a3c9-74a6234f2ee5@intel.com> (raw)
In-Reply-To: <20240626191537.1507452-2-jeevan.b@intel.com>

[-- Attachment #1: Type: text/plain, Size: 2099 bytes --]

Hello Jeevan,

On 6/27/2024 12:45 AM, Jeevan B wrote:
> Added helper functions to check LOBF status to check weather
> it is enabled or disabled.
>
> Signed-off-by: Jeevan B<jeevan.b@intel.com>
> ---
>   lib/igt_kms.c | 23 +++++++++++++++++++++++
>   lib/igt_kms.h |  1 +
>   2 files changed, 24 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 174bbe6c4..1f0243eb6 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -6071,6 +6071,29 @@ void igt_dump_crtcs_fd(int drmfd)
>   	drmModeFreeResources(mode_resources);
>   }
>   
> +/**
> + * igt_get_i915_edp_lobf_info
> + * @drmfd: A drm file descriptor
> + * @connector_name: Name of the libdrm connector we're going to use
> + *
> + * Return: True if its enabled.
> + */
> +bool igt_get_i915_edp_lobf_info(int drmfd, char *connector_name)
Small nitpick, can this be igt_get_i915_edp_lobf_status, since we are 
not reading other info. Also do we need to use aux wake alpm / aux less 
alpm status or that doesn't matter? Animesh any thoughts from you here? 
Thanks and Regards Kunal Joshi
> +{
> +	char buf[24];
> +	int fd, res;
> +
> +	fd = igt_debugfs_connector_dir(drmfd, connector_name, O_RDONLY);
> +	igt_assert(fd >= 0);
> +
> +	res = igt_debugfs_simple_read(fd, "i915_edp_lobf_info", buf, sizeof(buf));
> +	igt_require(res > 0);
> +
> +	close(fd);
> +
> +	return strstr(buf, "LOBF status: enabled");
> +}
> +
>   /**
>    * igt_get_output_max_bpc:
>    * @drmfd: A drm file descriptor
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 01604dac9..5b1591631 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -1195,6 +1195,7 @@ void igt_require_pipe(igt_display_t *display,
>   void igt_dump_connectors_fd(int drmfd);
>   void igt_dump_crtcs_fd(int drmfd);
>   bool igt_override_all_active_output_modes_to_fit_bw(igt_display_t *display);
> +bool igt_get_i915_edp_lobf_info(int drmfd, char *connector_name);
>   unsigned int igt_get_output_max_bpc(int drmfd, char *connector_name);
>   unsigned int igt_get_pipe_current_bpc(int drmfd, enum pipe pipe);
>   void igt_assert_output_bpc_equal(int drmfd, enum pipe pipe,

[-- Attachment #2: Type: text/html, Size: 2505 bytes --]

  reply	other threads:[~2024-07-17  4:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-26 19:15 [PATCH i-g-t 0/2] New test to validate link-off between active regions (LOBF) Jeevan B
2024-06-26 19:15 ` [PATCH i-g-t 1/2] lib/igt_kms: Added library functions for LOBF status Jeevan B
2024-07-17  4:45   ` Joshi, Kunal1 [this message]
2024-07-17  8:51     ` [i-g-t,1/2] " Manna, Animesh
2024-06-26 19:15 ` [PATCH i-g-t 2/2] RFC: tests/kms_vrr: Add new test to validate LOBF Jeevan B
2024-07-03 10:16   ` [i-g-t,2/2] " Joshi, Kunal1
2024-07-03 10:19     ` B, Jeevan
2024-07-03 11:55       ` Manna, Animesh
2024-06-26 21:39 ` ✓ Fi.CI.BAT: success for New test to validate link-off between active regions (LOBF) Patchwork
2024-06-26 21:51 ` ✓ CI.xeBAT: " Patchwork
2024-06-27  7:41 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-28  2:32 ` ✗ Fi.CI.IGT: " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-07-22  7:50 [PATCH i-g-t 1/2] lib/igt_kms: Added library functions for LOBF status Jeevan B
2024-07-22  9:05 ` [i-g-t,1/2] " Joshi, Kunal1

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b95d46cb-ef23-4ea7-a3c9-74a6234f2ee5@intel.com \
    --to=kunal1.joshi@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox