From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution
Date: Wed, 10 Apr 2019 13:11:40 +0100 [thread overview]
Message-ID: <9adb5eb4-0e32-611d-55e4-3d72aacf426d@linux.intel.com> (raw)
In-Reply-To: <155489693247.3516.17172100544939191386@skylake-alporthouse-com>
On 10/04/2019 12:48, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-04-10 12:43:22)
>> @@ -754,8 +768,8 @@ static void test_flip(int i915, int vgem, unsigned hang)
>> uint32_t offsets[4] = {};
>> int fd;
>>
>> - bo[i].width = 1024;
>> - bo[i].height = 768;
>> + bo[i].width = mode->hdisplay;
>> + bo[i].height = mode->vdisplay;
>> bo[i].bpp = 32;
>> vgem_create(vgem, &bo[i]);
>
> That may not result in a buffer that we are able to flip to. :|
> width = ALIGN(hdisplay, 16); vdisplay should be ok.
Oh.. well I don't know. Maarten helpfully described in the BZ that the
skip is due BO being too small for the FB. Aligning width would then
make it too large. Is that OK? Who assigned this display related IGT bug
to me anyway? :))
> I would query what happened to the scalers though :)
Are they supposed to automagicaly apply any fb to any output? Or an
explicit step is required? Regardless - it may be better to involve less
of the driver and hardware stack in a simple test.
Regards,
Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-04-10 12:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 11:43 [Intel-gfx] [RFT i-g-t] tests/prime_vgem/basic-fence-flip: Probe display resolution Tvrtko Ursulin
2019-04-10 11:48 ` [igt-dev] " Chris Wilson
2019-04-10 12:11 ` Tvrtko Ursulin [this message]
2019-05-07 8:14 ` Tvrtko Ursulin
2019-05-09 10:51 ` Kahola, Mika
2019-05-09 12:14 ` Tvrtko Ursulin
2019-04-10 12:31 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-04-10 12:36 ` Tvrtko Ursulin
2019-04-10 17:20 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9adb5eb4-0e32-611d-55e4-3d72aacf426d@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox