Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: add invalid parameter tests
@ 2023-02-09 11:51 Juha-Pekka Heikkila
  2023-02-09 13:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_plane_scaling: add invalid parameter tests (rev3) Patchwork
                   ` (5 more replies)
  0 siblings, 6 replies; 9+ messages in thread
From: Juha-Pekka Heikkila @ 2023-02-09 11:51 UTC (permalink / raw)
  To: igt-dev

Add skeleton for adding invalid parameter tests and add
two tests which are expected to return -EINVAL or -ERANGE

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_plane_scaling.c | 71 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 71 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 887a55e63..30a839f15 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -819,6 +819,75 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
 	igt_assert_eq(ret1 && ret2, 0);
 }
 
+static void invalid_parameter_tests(data_t *d) {
+	enum pipe pipe = PIPE_A;
+	igt_output_t *output;
+	igt_fb_t fb;
+	igt_plane_t* plane;
+	int rval;
+
+	const struct {
+		const char* testname;
+		uint32_t planesize[2];
+		struct {
+			enum igt_atomic_plane_properties prop;
+			uint32_t value;
+		} params[8];
+	} paramtests[] = {
+		{
+			.testname = "less-than-1-height-src",
+			.planesize = {256, 8},
+			.params = {{IGT_PLANE_SRC_H, IGT_FIXED(0, 30) }, {~0}}
+		},
+		{
+			.testname = "less-than-1-width-src",
+			.planesize = {8, 256},
+			.params = {{IGT_PLANE_SRC_W, IGT_FIXED(0, 30) }, {~0}}
+		},
+	};
+
+	igt_fixture {
+		output = igt_get_single_output_for_pipe(&d->display, pipe);
+		igt_require(output);
+
+		igt_output_set_pipe(output, pipe);
+		plane = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+
+		igt_create_fb(d->drm_fd, 256, 256,
+			DRM_FORMAT_XRGB8888,
+			DRM_FORMAT_MOD_NONE,
+			&fb);
+	}
+
+	igt_describe("test parameters which should not be accepted");
+	igt_subtest_with_dynamic("invalid-parameters") {
+		for (uint32_t i = 0; i < ARRAY_SIZE(paramtests); i++) {
+			igt_dynamic(paramtests[i].testname) {
+				igt_plane_set_position(plane, 0, 0);
+				igt_plane_set_fb(plane, &fb);
+				igt_plane_set_size(plane,
+							paramtests[i].planesize[0],
+							paramtests[i].planesize[1]);
+
+
+				for (uint32_t j = 0; paramtests[i].params[j].prop != ~0; j++)
+					igt_plane_set_prop_value(plane,
+									paramtests[i].params[j].prop,
+									paramtests[i].params[j].value);
+
+				rval = 	igt_display_try_commit2(&d->display, COMMIT_ATOMIC);
+
+				igt_assert(rval == -EINVAL || rval == -ERANGE);
+			}
+		}
+	}
+
+	igt_fixture {
+		igt_remove_fb(d->drm_fd, &fb);
+		igt_output_set_pipe(output, PIPE_NONE);
+	}
+}
+
 static int opt_handler(int opt, int opt_index, void *_data)
 {
 	data_t *data = _data;
@@ -982,6 +1051,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 	igt_subtest_f("2x-scaler-multi-pipe")
 		test_scaler_with_multi_pipe_plane(&data);
 
+	invalid_parameter_tests(&data);
+
 	igt_fixture {
 		igt_display_fini(&data.display);
 		close(data.drm_fd);
-- 
2.39.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread
* [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: add invalid parameter tests
@ 2023-01-15 21:03 Juha-Pekka Heikkila
  0 siblings, 0 replies; 9+ messages in thread
From: Juha-Pekka Heikkila @ 2023-01-15 21:03 UTC (permalink / raw)
  To: igt-dev; +Cc: Drew Davenport

Add skeleton for adding invalid parameter tests and add two tests which are
expected to return -EINVAL

Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_plane_scaling.c | 71 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 71 insertions(+)

diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 887a55e63..96713128b 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -819,6 +819,75 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
 	igt_assert_eq(ret1 && ret2, 0);
 }
 
+static void invalid_parameter_tests(data_t *d) {
+	enum pipe pipe = PIPE_A;
+	igt_output_t *output;
+	igt_fb_t fb;
+	igt_plane_t* plane;
+	int32_t rval;
+
+	const struct {
+		const char* testname;
+		uint32_t planesize[2];
+		struct {
+			enum igt_atomic_plane_properties prop;
+			uint32_t value;
+		} params[8];
+	} paramtests[] = {
+		{
+			.testname = "less-than-1-height-src",
+			.planesize = {256, 8},
+			.params = {{IGT_PLANE_SRC_H, IGT_FIXED(0, 30) }, {~0}}
+		},
+		{
+			.testname = "less-than-1-width-src",
+			.planesize = {8, 256},
+			.params = {{IGT_PLANE_SRC_W, IGT_FIXED(0, 30) }, {~0}}
+		},
+	};
+
+	igt_fixture {
+		output = igt_get_single_output_for_pipe(&d->display, pipe);
+		igt_require(output);
+
+		igt_output_set_pipe(output, pipe);
+		plane = igt_output_get_plane_type(output, DRM_PLANE_TYPE_PRIMARY);
+
+		igt_create_fb(d->drm_fd, 256, 256,
+			DRM_FORMAT_XRGB8888,
+			DRM_FORMAT_MOD_NONE,
+			&fb);
+	}
+
+	igt_subtest_group {
+		igt_describe("test parameters which should not be accepted");
+		igt_subtest_with_dynamic("invalid-parameters") {
+			for (uint32_t i = 0; i < ARRAY_SIZE(paramtests); i++) {
+				igt_dynamic(paramtests[i].testname) {
+					igt_plane_set_position(plane, 0, 0);
+					igt_plane_set_fb(plane, &fb);
+					igt_plane_set_size(plane,
+							   paramtests[i].planesize[0],
+							   paramtests[i].planesize[1]);
+
+
+					for (uint32_t j = 0; paramtests[i].params[j].prop != ~0; j++)
+						igt_plane_set_prop_value(plane,
+									 paramtests[i].params[j].prop,
+									 paramtests[i].params[j].value);
+
+					rval = 	igt_display_try_commit2(&d->display, COMMIT_ATOMIC);
+
+					igt_assert(rval == -EINVAL);
+				}
+			}
+		}
+	}
+
+	igt_fixture
+		igt_remove_fb(d->drm_fd, &fb);
+}
+
 static int opt_handler(int opt, int opt_index, void *_data)
 {
 	data_t *data = _data;
@@ -982,6 +1051,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
 	igt_subtest_f("2x-scaler-multi-pipe")
 		test_scaler_with_multi_pipe_plane(&data);
 
+	invalid_parameter_tests(&data);
+
 	igt_fixture {
 		igt_display_fini(&data.display);
 		close(data.drm_fd);
-- 
2.39.0

^ permalink raw reply related	[flat|nested] 9+ messages in thread
end of thread, other threads:[~2023-02-10 14:08 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-09 11:51 [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: add invalid parameter tests Juha-Pekka Heikkila
2023-02-09 13:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_plane_scaling: add invalid parameter tests (rev3) Patchwork
2023-02-09 14:09 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_plane_scaling: add invalid parameter tests (rev4) Patchwork
2023-02-09 15:32 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_plane_scaling: add invalid parameter tests (rev5) Patchwork
2023-02-09 20:02 ` [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: add invalid parameter tests Luca Coelho
2023-02-10 11:58 ` [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_plane_scaling: add invalid parameter tests (rev5) Patchwork
2023-02-10 13:22 ` [igt-dev] [PATCH i-g-t] tests/kms_plane_scaling: add invalid parameter tests Kamil Konieczny
2023-02-10 14:07   ` Juha-Pekka Heikkila
  -- strict thread matches above, loose matches on Subject: below --
2023-01-15 21:03 Juha-Pekka Heikkila

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox