From: "Bernatowicz, Marcin" <marcin.bernatowicz@linux.intel.com>
To: Jakub Kolakowski <jakub1.kolakowski@intel.com>,
igt-dev@lists.freedesktop.org
Cc: Harish Chegondi <harish.chegondi@intel.com>,
Ashutosh Dixit <ashutosh.dixit@intel.com>,
Adam Miszczak <adam.miszczak@linux.intel.com>,
Lukasz Laguna <lukasz.laguna@intel.com>
Subject: Re: [PATCH i-g-t] tests/intel/xe_eu_stall: Skip test on SR-IOV VF
Date: Fri, 23 May 2025 12:40:28 +0200 [thread overview]
Message-ID: <9eb53198-a170-4cb2-9f31-db5f3dbeb60d@linux.intel.com> (raw)
In-Reply-To: <20250522172441.3914198-1-jakub1.kolakowski@intel.com>
On 5/22/2025 7:24 PM, Jakub Kolakowski wrote:
> EU stall sampling is not supported on SR-IOV VF. Skip the test on SR-IOV
> VF.
>
> Cc: Harish Chegondi <harish.chegondi@intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Cc: Adam Miszczak <adam.miszczak@linux.intel.com>
> Cc: Lukasz Laguna <lukasz.laguna@intel.com>
> Cc: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
> Signed-off-by: Jakub Kolakowski <jakub1.kolakowski@intel.com>
> ---
> tests/intel/xe_eu_stall.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel/xe_eu_stall.c b/tests/intel/xe_eu_stall.c
> index 411c30871..aa94d9565 100644
> --- a/tests/intel/xe_eu_stall.c
> +++ b/tests/intel/xe_eu_stall.c
> @@ -44,6 +44,7 @@
>
> #include "igt.h"
> #include "igt_core.h"
> +#include "igt_sriov_device.h"
> #include "xe_drm.h"
> #include "xe/xe_ioctl.h"
>
> @@ -653,7 +654,7 @@ igt_main_args("e:g:o:r:u:w:", long_options, help_str, opt_handler, NULL)
> drm_fd = drm_open_driver(DRIVER_XE);
> igt_require_fd(drm_fd);
> devid = intel_get_drm_devid(drm_fd);
> - igt_require(IS_PONTEVECCHIO(devid) || intel_graphics_ver(devid) >= IP_VER(20, 0));
> + igt_require(!intel_is_vf_device(drm_fd) && (IS_PONTEVECCHIO(devid) || intel_graphics_ver(devid) >= IP_VER(20, 0)));
> igt_require_f(igt_get_gpgpu_fillfunc(devid), "no gpgpu-fill function\n");
> igt_require_f(!stat(OBSERVATION_PARANOID, &sb), "no observation_paranoid file\n");
> if (output_file) {
Don't we have another option to check the feature is unavailable (ex. an
ioctl returning ENODEV) ?
next prev parent reply other threads:[~2025-05-23 10:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 17:24 [PATCH i-g-t] tests/intel/xe_eu_stall: Skip test on SR-IOV VF Jakub Kolakowski
2025-05-22 19:17 ` ✗ i915.CI.BAT: failure for " Patchwork
2025-05-22 19:30 ` ✓ Xe.CI.BAT: success " Patchwork
2025-05-23 6:51 ` [PATCH i-g-t] " Harish Chegondi
2025-05-23 10:40 ` Bernatowicz, Marcin [this message]
2025-05-23 12:23 ` Kolakowski, Jakub1
2025-05-23 13:11 ` Bernatowicz, Marcin
2025-05-23 13:56 ` Bernatowicz, Marcin
2025-05-23 16:06 ` Dixit, Ashutosh
2025-05-23 10:47 ` Kamil Konieczny
2025-05-23 12:20 ` ✗ Xe.CI.Full: failure for " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2025-05-23 12:44 [PATCH i-g-t] " Jakub Kolakowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9eb53198-a170-4cb2-9f31-db5f3dbeb60d@linux.intel.com \
--to=marcin.bernatowicz@linux.intel.com \
--cc=adam.miszczak@linux.intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=harish.chegondi@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=jakub1.kolakowski@intel.com \
--cc=lukasz.laguna@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox